He was the managing editor of Rose al-Yūsuf magazine. In France he worked as a professor of Arabic poetry at the Paris 8 University and the new Sorbonne University. He returned to Cairo and worked for Al-Ahram newspaper. He served as editor-in-chief of Ibdaa magazine from 1990 to 2002 when he resigned from the post. He was reappointed editor-in-chief of the magazine in 2006.