Taffy was born in Ebbw Vale, Wales and joined Tottenham from Ebbw Vale in 1925, making his debut for the first team in January 1927 against Everton F.C., having impressed with his two-footed play and accurate passing. Again in 1928 he impressed against Everton, scoring four goals in February of that year.
Taffy helped the team achieve promotion back to Football League First Division at the end of the 1932–33 season and in the following year was a key member of the side known as the ‘greyhounds’ as they played with speed and style. During his time at Spurs he made 252 league appearances scoring 93 goals and a further six in eleven FA Cup matches for the club.
He was transferred to Leicester City in March 1935 although playing once again for Tottenham as a ’guest’ during the war years at the time when the Football League had been suspended. After the war he went on to a coaching role at Fulham F.C..
His first cap for Wales was won in May 1929 and he went on to play a further eleven times at International level.