Template talk:WikiProject Military history

From Wikipedia, the free encyclopedia
Jump to: navigation, search
WikiProject Military history
MILHIST This template is within the scope of the Military history WikiProject. If you would like to participate, please visit the project page, where you can join the project and see a list of open tasks. To use this banner, please see the full instructions.
Temp Templates do not require a rating on the quality assessment scale.

Something is wrong with this template[edit]

If I add this template with the parameter 'class=Start', 'class=B', 'class=C', or 'class=A' it causes page saves to take at least 35 seconds (or occasionally timeout) and it displays the class as 'Start' in all of those cases. If I add this template without a class parameter or with 'class=Stub', 'class=GA', or 'class=FA' it works fine and page saves take the normal ~10 seconds. Kaldari (talk) 00:16, 31 October 2012 (UTC)

Some preliminary findings:
  • The performance impact appears to be proportional to the preprocessor visited node count (reported in the page HTML source).
  • The main contributor to the preprocessor node count is the class evaluation statement in the template:
{{WikiProject Military history/Class|class={{{class|}}} |list={{{list|}}} |A-Class={{{A-Class|}}} |B-Class-1={{WikiProject Military history/Any|{{{B-Class-1|}}}|{{{B-1|}}}|{{{B1|}}}|{{{b-1|}}}|{{{b1|}}}}} |B-Class-2={{WikiProject Military history/Any|{{{B-Class-2|}}}|{{{B-2|}}}|{{{B2|}}}|{{{b-2|}}}|{{{b2|}}}}} |B-Class-3={{WikiProject Military history/Any|{{{B-Class-3|}}}|{{{B-3|}}}|{{{B3|}}}|{{{b-3|}}}|{{{b3|}}}}} |B-Class-4={{WikiProject Military history/Any|{{{B-Class-4|}}}|{{{B-4|}}}|{{{B4|}}}|{{{b-4|}}}|{{{b4|}}}}} |B-Class-5={{WikiProject Military history/Any|{{{B-Class-5|}}}|{{{B-5|}}}|{{{B5|}}}|{{{b-5|}}}|{{{b5|}}}}}}}
  • The node count of the statement in question varies dramatically according to the value of the parameter; passing in "Start" produces a node count of approximately 4K, while passing in "FA" produces a node count of approximately 50.
Kirill [talk] 02:41, 31 October 2012 (UTC)
The culprit appears to have been {{WikiProject Military history/Any}}. I've reduced the number of checked parameters in it from 16 to 5, and eliminated some unnecessary invocations in {{WikiProject Military history}} for mutually exclusive parameter names; the net effect has been a reduction in visited preprocessor nodes from 120K to 15K for a fully loaded template. Hopefully this resolves the save time issue people were seeing; if the problem is still there, please let me know. Kirill [talk] 03:06, 31 October 2012 (UTC)
I was just looking at the talk page for HMS Shannon for the contest and it shows the article as assessed as start even though it's classified as B and all of the criteria =y. I tried capitalizing the criteria and didn't make any difference. No problem though with loading time.--Sturmvogel 66 (talk) 03:45, 31 October 2012 (UTC)
Load time has definitely improved though. Kaldari (talk) 03:57, 31 October 2012 (UTC)
Taking out the redundant /Any checks caused a problem with recognizing shortened parameter values (e.g. "y" instead of "yes") in some of the calls; I've fixed that now. Kirill [talk] 07:44, 31 October 2012 (UTC)

Technical issues with template (project tag needs fixing)[edit]

Hi all, could someone have a look at my queries here Wikipedia_talk:WikiProject_Military_history#Project_tag_problems? Thanks, Peacemaker67 (send... over) 01:23, 16 December 2012 (UTC)

Unassessed[edit]

The template code is confusing me. There's a switch that defaults to put articles into Category:Unassessed military history articles. There isn't an "importance" switch like there are in other WikiProject templates that would normally control this behavior. What am I missing? Chris Troutman (talk) 00:37, 1 June 2013 (UTC)

The error occurs if the article is a class of "stub" or less, but not if "start" or better. Chris Troutman (talk) 01:05, 1 June 2013 (UTC)
The Military history WikiProject doesn't use importance ratings, so that's why there's no code for them in the banner. Was this the only issue you were seeing, or is there some other issue you've encountered with the template? Kirill [talk] 09:27, 1 June 2013 (UTC)
That's the only issue. I've been trying to sort through the unassessed history articles and I don't want to leave the stub WPMILHIST articles in that category unnecessarily. Chris Troutman (talk) 16:56, 1 June 2013 (UTC)

Feature brainstorm for Module:WikiProjectBanner[edit]

I'm in the early stages of developing a Lua-based replacement for {{WPBannerMeta}}, and I would appreciate peoples ideas for features. If there is anything that you have wanted to do with your WikiProject template, but haven't been able to due to limitations in the meta-template, I would be very interested to hear it. The discussion is over at Template talk:WPBannerMeta. — Mr. Stradivarius ♪ talk ♪ 12:24, 18 June 2013 (UTC)

Quick and dirty insertions[edit]

Hi all. Could you give some example insertions reviewers can use without signing up for a three year course in it? Something that signals a decent start, that kind of thing. Thanks. Jennie Matthews 97 (talk) 03:11, 24 December 2013 (UTC)

If you really do not want to take the time to figure out the details simply use the banner without any parameters, someone will add them later. Roger (Dodger67) (talk) 12:08, 24 May 2014 (UTC)

Post-Cold War[edit]

The template needs a "Post-Cold War" era parameter. A lot of history has happened since the Wall came down. Roger (Dodger67) (talk) 12:04, 24 May 2014 (UTC)