User talk:Rjwilmsi/Archives/2009/January

From Wikipedia, the free encyclopedia
Jump to: navigation, search

Serial commas

Thank you for improving the footnotes in the Robert McFerrin article. I took a look at your user page after I read your work listed on the McFerrin history page. I see you have feelings about the serial comma. Do you happen to be a fan of Patrick O'Brian? His choice of using and avoiding the serial comma is interesting and is noted under "Narrative style" in the Aubrey-Maturin series article. I wrote the article on his earlier novel, The Road to Samarcand, but I did not encounter those long strings of adjectives in this 1954 publication. (I think the first novel of Aubrey-Maturin series was published in 1970.) Thanks again for the beautiful footnote work -- I say that because I can't help feeling a little proprietal after spending all that time working on the piece. I hope I learned somthing from your edit. —Preceding unsigned comment added by Hammerdrill (talkcontribs) 17:23, 5 January 2009 (UTC)

Quotes

Could you have your bot exclude quotes that contain errors? I think I've had to revert this bot in the MUD article before. --Scandum (talk) 00:52, 6 January 2009 (UTC)

My apologies, there was already logic to exclude quotes but it didn't handle citation templates with one field per line. I've changed the logic so it does now. Thanks Rjwilmsi 08:11, 6 January 2009 (UTC)

Thomas Levett

Thanks for the catch on the typo on 'daughter.' But I've restored the 'imployed' with a [sic] as the misspelling is in the original source document . Regards,MarmadukePercy (talk) 21:30, 6 January 2009 (UTC)

Okay, I've updated the article to use a {{sic}} template for consistency. Thanks Rjwilmsi 21:54, 6 January 2009 (UTC)
Many thanks for your help. Regards,MarmadukePercy (talk) 21:56, 6 January 2009 (UTC)

Please don't change cited titles using AWB

This edit corrected the style of the title of a cited web page. Please correct the edit, and pay closer attention in the future. Thanks. Michael Z. 2009-01-07 06:27 z

My apologies, I had not added exceptions to catch quoted text in curly double quotes (I'd only allowed for straight double quotes). I've amended my script. Rjwilmsi 08:10, 7 January 2009 (UTC)

Proposed deletion of GiftCardLab.com

Ambox warning yellow.svg

A proposed deletion template has been added to the article GiftCardLab.com, suggesting that it be deleted according to the proposed deletion process because of the following concern:

Non-notable, spammy web-content with long history.

All contributions are appreciated, but this article may not satisfy Wikipedia's criteria for inclusion, and the deletion notice should explain why (see also "What Wikipedia is not" and Wikipedia's deletion policy). You may prevent the proposed deletion by removing the {{dated prod}} notice, but please explain why you disagree with the proposed deletion in your edit summary or on its talk page.

Please consider improving the article to address the issues raised because, even though removing the deletion notice will prevent deletion through the proposed deletion process, the article may still be deleted if it matches any of the speedy deletion criteria or it can be sent to Articles for Deletion, where it may be deleted if consensus to delete is reached. Call me Bubba (talk) 04:10, 8 January 2009 (UTC)

Your script

Hi, I have been using your script lately, it is great, that ref fixing feature is very good rgds --Typ932 T·C 12:09, 10 January 2009 (UTC)

I'm pleased you find it useful. Please check regularly for updated versions with any bugfixes. Rjwilmsi 12:12, 10 January 2009 (UTC)

revert

Sorry, my revert may have been a bit hurried. Initially appeared to be vandalism. May not be. --Sulfis (talk) 20:58, 10 January 2009 (UTC)

Okay, I've reinstated my edit, though I thought there was an 'established user' whitelist for these vandal monitoring tools. Rjwilmsi 21:13, 10 January 2009 (UTC)

Sorting key

Hello Rjwilmsi please do not do changes like changing [[Category:Public transport in Auckland| Public transport in Auckland]] to [[Category:Public transport in Auckland|Public transport in Auckland]]. The extra space is there intentionally, because the article "Public transport in Auckland" should be listed at the very beginning (NOT alphabetically sorted somewhere in the cat) of the cat "Public transport in Auckland". Same applies for sub-categories or articles with the qualifiers "in" or "by" (for example if there was a subcategory "Public transport in Auckland by mode", then the correct sorting key would be [[Category:Public transport in Auckland| Public transport in Auckland by mode]] - note the extra space and the need for full name in the sort key. This ensures that WITHIN the preempted articles / categories alphabetic order is retained internally as well.

Cheers and happy editing. Ingolfson (talk) 07:02, 11 January 2009 (UTC)

Issue has already been resolved: see here. Rjwilmsi 08:57, 11 January 2009 (UTC)

AWB Bug Clearing

Hey Rjwilmsi, MaxSem has left en.wp, possibly indefinately, so I'm currently down to being the only AWB Developer. He said he'll help out, but he's not going to be as active as he has been..

As you've probably noticed, i'm starting to really work my way through the bugs on the bug page...

You've got those couple of big external link bugs and such open... Would you mind trying to help me finish them off so i can close them?

Reedy 15:28, 9 January 2009 (UTC)

I've left a message on Reedy's talk page with an offer to help where I can. Rjwilmsi 19:19, 9 January 2009 (UTC)
Great, thanks. Will have a look properly at them later today =) Reedy 00:28, 10 January 2009 (UTC)

Changes

Wikipedia_talk:AutoWikiBrowser/Bugs#HTTP.2FFTP_format_fixes_applied_to_text_within_external_links.2C_rather_than_just_the_start, parsers.FixSyntax() is to blame. Added your unit tests in rev 3673. Hopefully that at least gives you a bit more clarification. If you want to know how to debug using VS, i can help you out. Thanks! Reedy 22:52, 10 January 2009 (UTC)

Now sorted, thanks. Regarding the "Bug in regex to correct double bracketed external links", rev 3687 disables the tests for now. I shall archive the bug, and link it back on the unit tests.. Its then there as a known "bug", but its not major. Thanks, Reedy 20:11, 12 January 2009 (UTC)

Wikipedia_talk:AutoWikiBrowser/Bugs#find_.26_replace_applied_to_images_when_ignore_images_set

Circa line 67 in HideText.cs, is what hides the images:

            if (HideImages)
            {
               Replace(WikiRegexes.Images.Matches(ArticleText), ref ArticleText);
            }

What do you suggest for a regex update for this bug? Reedy 20:19, 12 January 2009 (UTC)

Is it okay for me to have SVN access on sf.net to avoid us messing around with patches? I could probably help with some other stuff to around regexes & test cases. Thanks Rjwilmsi 20:39, 12 January 2009 (UTC)
Sorted, was going to ask you if you wanted it... You'll need to change the checkout link to the https link for checking in Reedy 20:46, 12 January 2009 (UTC)
Oh, and do you use IRC? Reedy 20:46, 12 January 2009 (UTC)

Edit Julleuchter

Hello Rjwilmsi, I like how you “set identical references to use existing ref name” On article Julleuchter. I was wondering if you could help out by doing it again. There are other sources that are used over again. Sources 2,3,6,11,29 “On the history and ritual use...”are all from the same place, also source 20 and 21 “candleholders...” are the same, source 32 and 33 “Chris Meyer’s...” are the same, and sources 9 and 28 “Khaynrikh Shil’d...” are the same. I would like to do what you did for “Puryear, Mark. The Nature of Asatru:” but I do not know how to do so. If you could do it I think it would make the article better.Nicholasweed (talk) 12:51, 13 January 2009 (UTC)

Done. See the documentaiton for named references at WP:REFNAME. There are two entries for the same 'candle holders' reference left over for you to combine for practise. Thanks Rjwilmsi 21:07, 13 January 2009 (UTC)

Thanks =

Minor Barnstar.png The Minor Barnstar
Thanks for cleaning up a bunch of nits in cites in Rachel Pollack.

Seems like wonderful but usually unrecognized work to clean up this sort of thing.Anniepoo (talk) 01:40, 14 January 2009 (UTC)

And god said, let there be colo(u)?r, and there was!

rev 3697

Not quite perfect, but its pretty much there


Good Work!

Reedy 17:52, 14 January 2009 (UTC)

rev 3694

Hey, Just a minor tweak/heads up to the above - rev 3699.

Saves a few cpu cycles as theres no use trying to see if there are any typo matches if the title would mean it wouldn't actually be used, so an earlier return


Reedy 18:05, 14 January 2009 (UTC)

Many thanks for this and above addition of colour to pre-parse mode. I don't expect to write perfect code so you're welcome to refactor where appropriate. My aim in the first instance is to write stuff that works. Rjwilmsi 18:10, 14 January 2009 (UTC)
I'm going to go and fixup Main.cs later on, although your way works, its a lot of (un-necesserily) duplicated code... Not a major problem, but should be tidied up, if only for a maintainability PoV. =] Some of it may need to be partially duplicated, which, if is the case, i'll function it out a bit.. Thanks! Reedy 18:16, 14 January 2009 (UTC)

IM or similar?

Hey, Do you use an Instant Messengers/Similar?

Would be useful, feel free to email me an address if you use one.

Cheers

Reedy 19:11, 14 January 2009 (UTC) I've got <my_user_name> at gmail and Skype. Don't have IM per se. Rjwilmsi 19:15, 14 January 2009 (UTC)

Duplicate refs errors

In a recent AWB edit to Lothian, Borders & Angus Co-operative Society, you attempted to "tidy up duplicate named refs", but actually deleted some references that were different. As you can see by the "pages=5" parameter in this edit, one referred to a specific page of the same document, which AWB deleted.

Could you take a look, please, to see if AWB has done this in any other of your recent edits?

--Hroðulf (or Hrothulf) (Talk) 12:50, 14 January 2009 (UTC)

Hmm, my apologies, one slipped through. I'm introducing logic in my script to ensure that references aren't tidied if they refer to different pages (I might then try to split them out as different references), so this shouldn't happen again. Rjwilmsi 13:42, 14 January 2009 (UTC)
Thanks. It is a shame someone hasn't designed a reference template that allows a single ref to refer to different pages. --Hroðulf (or Hrothulf) (Talk) 11:25, 16 January 2009 (UTC)

More FR's..

I suspect both of those are up your street...

Good work on what you've implemented so far!

Reedy 21:10, 15 January 2009 (UTC)

I was actually working on the first when you posted me this message. It's done now but I need to put in more unit tests for HideMore. I'll look at the second as well, but I'm not sure it will be easy to do accurately. We'll see. Rjwilmsi 22:16, 15 January 2009 (UTC)
Heh. I'll give you a hand with the first, as setting up for the Unit tests might be a bit funny.. For the latter, i do agree, as we've got `"' plus loads more non english used ones... Hmmm... Dont worry about that too much ;) Reedy 22:26, 15 January 2009 (UTC)

Incorrect Correction

Your correction here http://en.wikipedia.org/w/index.php?title=Double-Tongued_Dictionary&action=history of "Wrester" to "Wrestler" is wrong. Please undo it. It should not be "Wrestler," but "Wrester," meaning a person who wrests, or takes, something from someone or somewhere else. The Double-Tongued Dictionary is my site, so I know for certain that I am correct. I would caution you from making changes that depend upon your own knowledge of vocabulary. You could have verified your correction by checking the "About" page of the Double-Tongued Dictionary web site. GrantBarrett (talk) 13:09, 16 January 2009 (UTC)

My apologies, I'll look at adding an exception to cover that. Rjwilmsi 13:54, 16 January 2009 (UTC)

Pre Parse Idea

I was thinking about it... and it seems to make sense.

How about using the API to load the article text for the pre-parsing?

Doing so, to then put into a web control and save makes no sense, but for pre parsing, where we only want the article text so we can force it out and process it...

Reedy 14:03, 17 January 2009 (UTC)

What difference would it make then? Rjwilmsi 14:05, 17 January 2009 (UTC)
It *should* be quicker, as it can be a semi background operation, literally just loading page text from the API, parsing it and ignoring as applicable. Even on the simple skin AWB uses, more stuff is loaded than needed, it has then got to be extracted from the web browser etc etc. Will have a play and see. Reedy 14:12, 17 January 2009 (UTC)
Yup, although slightly buggy with how i've worked the code in (ie stop doesnt work...), it is quite a lot faster. Will create a branch later on for you to see. Reedy 16:07, 17 January 2009 (UTC)

rev 3783, seems pretty good to me... Reedy 23:27, 17 January 2009 (UTC)

More Pre Parse: Suggestions

Good work it seems again today, you've been busy! =)

Couple of things i've noticed (/are minor errors), wanted your opinion.

The Auto saving of the settings file. "Optional 'Pre-parse' / 'skipability' / 'dry run mode': AWB will automatically run through a list of articles and skip them based on the skip conditions, leaving those remaining in the list for the user to work through later, and periodically saving the settings file (designed to be used when 'save page list with settings' is enabled)" is how you've listed it on the change log. I'd agree with doing it like that, so, shouldn't AWB actually check if that checkbox is checked when trying to save automatically in pre-parse (as having save page list not enabled just defeats the point of doing this anyway)?

Came about as i noticed my default settings were being overwritten, which I use for debugging... It was overwritten, but i didn't want it to be.

Do you think/agree the settings should only be saved IF the setting is indeed checked (as per the change log)? Would make sense for the 2 settings to be used together...

Leading on from that, the user could be given a Messagebox asking if they want to enable save settings and save page list if they are not enabled... (easy enough to do).


After the list preparsing is done, would it be worth giving the user a messagebox saying "Complete"? And offering to turn off preparse mode for them?


And a final thing (i'll possibly look at it later), the Delayed restart timer seems to get rather high by the time that you've pre-processed a large list


Reedy 17:00, 17 January 2009 (UTC)

My understanding of the AWB functionality at the moment is that it is both how I intended it to be and how it should be: firstly, there is an option to automatically save the settings file every 10 saved edits, which will operate whether in pre-pass mode or not (though, in pre-pass mode no edits will be saved so it wouldn't actually fire). This functionality has nothing to do with pre-pass mode it is just an option, set off by default, for the settings file to be automatically saved. If the user checks it then they must expect that their settings file will be changed without them being advised of it each time. Secondly, when in pre-pass mode the settings file is automatically saved every 10 ignored edits. I believe that this is the sensible thing to do because users may wish to pre-pass several thousand edits overnight, and without this automatic saving any crash on their computer or AWB itself would mean they would lose their work.
Perhaps though, the sensible solution is to implement a pop-up message when the user checks the pre-pass mode option, to remind them that in pre-pass mode their settings file will be automatically saved every 10 skipped pages, and provide them with a cancel option if they don't want to do this. If you are able to do this (I wouldn't know how to add such event handling) then please go ahead, though I don't think it is strictly necessary –the idea of introducing this pre-pass mode was to make it a simple solution before moving fully to API editing. Again, a message box on finishing of the pre-parsing could be useful, though I don't think it's essential -- pre-parsing will obviously be finished when it reaches the last article.
I'm not really sure about any problems with the delay timer, because the Internet on my PC is a bit screwed up at the moment, so I wasn't sure whether any timeouts were due to the code changes or just my Internet. However, I agree it would be sensible to cap the restart timer at something like 30 seconds when in pre-pass mode. Thanks Rjwilmsi 17:37, 17 January 2009 (UTC)

AfD nomination of Allan Cox (author)

Ambox warning pn.svg

An article that you have been involved in editing, Allan Cox (author), has been listed for deletion. If you are interested in the deletion discussion, please participate by adding your comments at Wikipedia:Articles for deletion/Allan Cox (author). Thank you. Reboot (talk) 18:35, 17 January 2009 (UTC)

Warnings

January 2009

Information.svg Welcome to Wikipedia. It might not have been your intention, but your recent edit removed content from Monstermob. When removing text, please specify a reason in the edit summary and discuss edits that are likely to be controversial on the article's talk page. If this was a mistake, don't worry; the text has been restored, as you can see from the page history. Take a look at the welcome page to learn more about contributing to this encyclopedia, and if you would like to experiment, please use the sandbox. Thank you.--Auric (talk) 14:57, 18 January 2009 (UTC)

Japanese era name

I don't understand your edit -- here?

My first blush response is to think your change to the in-line citation was an unhelpful step away from a difficult, multi-sourced and cross-referenced precision.

Will you please explain a bit more about your intentions and reasoning? --Tenmei (talk) 01:22, 20 January 2009 (UTC)

Simply to combine references 52 and 53 which were the same into references 52a,b (based on this revision). The same style has been used for reference 3 etc. Rjwilmsi 06:21, 20 January 2009 (UTC)
Aha -- I missed the point. Of course, I now see that your edit should have been recognized as obvious, clearly an improvement. Sorry for having been so oddly confused. --Tenmei (talk) 17:33, 21 January 2009 (UTC)

Re:Time for AWB 4.5 release?

Sounds good to me. My last january exam was this morning (yay!), so now have 6 days with not a lot to do...

Gonna spend this afternoon fiddling with AWB - more using it to see if there is anything else that should be changed, then i'll probably do a release tonight. Will be on skype throughout the day.

Was something else i was going to say, but my minds gone blank...

Reedy 12:56, 26 January 2009 (UTC)

Not sure if its a preparse bug or not (will check), but the AutoWikiBrowser disappears from the title during pre-parse, " - Page Title", and looks funny Reedy 13:03, 26 January 2009 (UTC)
Nah, there all the time (seems the title update has just got changed accidentally). Will fix after this run Reedy 13:19, 26 January 2009 (UTC)
Okay, I'll be on Skype in about 5 hours in case there's any last minute changes needed. Just need to pretend to work for a while first. Rjwilmsi 13:40, 26 January 2009 (UTC)
rev 3827 - Seems to be only when it loads default settings (when no file exists) Reedy 14:26, 26 January 2009 (UTC)

RealVNC

Would you please specify/explain the change you've made in line 24 of RealVNC? The diff seems to indicate that you've deleted the paragraph and reinserted something indistinguishable back. Yet a difference is nevertheless indicated. Perhaps it's something in the associated reference? Thanks, --Dan.tsafrir (talk) 07:29, 27 January 2009 (UTC)

I removed some trailing whitespace from the end of that paragraph. The diff isn't very good at showing such changes. Rjwilmsi 08:16, 27 January 2009 (UTC)

new AWB version

It seems to have bug? it adds this {{Uncategorizedstub|date={{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}}}} to many pages even there are real categories, I tried some earlier "mid" version and it had orphan bug,,, maybe same error causing it? --Typ932 T·C 08:26, 27 January 2009 (UTC)

I've not seen this myself. Please report a bug on the AWB Bugs page with examples of incorrect edits. Rjwilmsi 08:29, 27 January 2009 (UTC)
Can you try eg. Petrol engine page --Typ932 T·C 08:46, 27 January 2009 (UTC)
I maintain the tagger code is teh suxx0rs (though, tis my fault) - rev 3844. Rob, think we should make sure we overhaul the code before the next release (whether minor bugfixing or otherwise) Reedy 11:46, 27 January 2009 (UTC)
rev 3846 splits up the Tag Adding/Removing in the code, doesn't do anything gui wise though Reedy 14:28, 27 January 2009 (UTC)

4.5 Followup

Definately going to be needed, seeing as i made a mess with AutoTag... And you've found a few regex bugs and such...

Reedy 19:22, 28 January 2009 (UTC)

Okay. What's the plan? Rjwilmsi 19:24, 28 January 2009 (UTC)
Finishing off the overhaul/improvements to AutoTag would be great. As would that languages bug... If we could reproduce it, it would be rather useful... Any other bugs that we can fix (i'll look at that autosave one tonight too).... Then probably push out an update at the weekend... Reedy 19:29, 28 January 2009 (UTC)
Think i've fixed the edit count bug. Reedy 19:54, 28 January 2009 (UTC)

Did you add unit tests to cover the uncagetgorised tag bug? Rjwilmsi 23:49, 29 January 2009 (UTC)

No, the tagger code needs it though as a whole... Reedy 00:08, 30 January 2009 (UTC)

Tagger Tests

Making a start - rev 3882..

Ever get the feeling you shouldn't have started something? lol

Reedy 22:09, 30 January 2009 (UTC)

Upto rev 3888.. Unit tests, a couple more Tool tests... Not finished, but the Tagger Add tests i think are done, just need to look at finishing the Remove() ones. Reedy 00:04, 31 January 2009 (UTC)

Thanks

...for helping on the USMA tags fix. — BQZip01 — talk 01:07, 31 January 2009 (UTC)