As a midfielder, Saleh had a very successful run with the Egyptian club Al Ahly. He was also an international midfielder for the Egyptian national team. With his club, Al Ahly, he won three Egyptian league titles. He also had spells with Egypt's Al Masry, Kuwaiti club Tadamon, and the Lebanese Nejmeh Sporting Club.
As a manager, Saleh's greatest successes came while managing the Egyptian football club, Ismaily. He led them to an Egyptian Cup title in 2000 as well as an Egyptian League title in 2002. He also has a 2nd division League title for Saudi Arabian club El-Watany to his name. As an assistant coach, Saleh helped his former club Al Ahly to two Egyptian league titles. In 2002 the Egyptian Football Association awarded Saleh with the 'Best Coach of the Year' title for that year.
1979: Ahly Junior Team (Egypt) 1980: El-Khaleeg (Saudi Arabia) 1981-1984: El-Ain Junior Team (United Arab Emirates) 1984-1985: El-Ahly (United Arab Emirates) (Assistant) 1985-1988: El-Watany (Saudi Arabia) (Saudi 2nd division League Champion 1987) 1988-1989: Port Foad (Egypt) (Qualified to the Egyptian Premier League after long absesnce) 1990-1991: Masry (Egypt) 1991-1992: Mirbat (Oman) 1994: Egyptian National Team (Assistant) 1994: Egyptian Youth Team U19 1995: Egyptian National Team 1996-1997: Negma (Lebanon) 1997-1999: Masry (Egypt) (African Cup semifinal 1999) 1999-2002: Ismaily (Egypt) (Egyptian Cup Champion 2000 / CAF winners' Cup runner-Up 2000 / Egyptian League runner-up 2000 / Egyptian League Champion 2002) 2002-2004: Egyptian National Team 2004: Nasr (Saudi Arabia) 2006: Libyan National Football Team 2007: Yemeni National Football Team 2008-2009: Yemeni National Football Team 2009: Hazem (Saudi Arabia) 2010: Semoha (Egypt) August-2010: Saleh retired from coaching