Neil started his senior career with Hibernian. He played in the 1896 Scottish Cup Final, which Hibs lost 3–1 against Heart of Midlothian. After a spell with Liverpool, Neil joined Rangers in 1897. During his seven-year spell with Rangers he amassed four Scottish league championships, one Scottish Cup, three Glasgow Cups and two Charity Cups. He made 109 first class appearances for Rangers and scored 28 goals.
Neil gained two Scotland caps during his career, both coming against Wales. He scored two goals on his debut, a 4–0 win for Scotland on 21 March 1896. His second cap, which ended in a 5–2 win for Scotland, was on 3 February 1900.
After retirement he became a restaurateur, but died in March 1913 aged thirty-seven.
- Brown, Alan; Tossani, Gabriele (17 March 2016). "Scotland - International Matches 1891-1900". RSSSF. Retrieved 28 September 2016.