I originally wrote this article, and if you check in the history, you will notice that the original version was much more cogent and error-free than the piece of crap that it currently is.
In a minute, I will be fixing it.
Loisel 22:36, 19 December 2005 (UTC)
Someone added tags to merge in brick-wall filter; I support that, even though the brick-wall filter is a bit more general, as it can be a bandpass or highpass; but it's still nothing but a difference of sinc filters in the most complex case, and doesn't really need a separate small article. Dicklyon (talk) 15:42, 30 July 2009 (UTC)
- Merges work best when articles are synonymous with what they merge into, but these aren't synonymous. You would have to merge into electronic filter or something. On balance I think they're better separate.- (User) Wolfkeeper (Talk) 16:39, 30 July 2009 (UTC)
- Agreed. Sticking to simplest case semantics, it's better that the two topics are separate. Most people will be looking for them as separate articles. Of course, including a note (or just a see also) in both pointing to the other one is a good idea. —TedPavlic (talk/contrib/@) 16:57, 30 July 2009 (UTC)
- Well, I disagree. Merges are good when concepts are so closely related that one article makes a more coherent presentation than two. I think that would be the case here, if brick-wall bandpass and highpass filters were treated in a section of sinc filter. Merging brick-wall filter into electronic filter seems like a bad idea, as it's merging a mathematical abstraction into a very concrete non-ideal topic. Dicklyon (talk) 17:15, 30 July 2009 (UTC)
- Thing is, sinc filter is a particular case of brick wall filter; so that should be the primary article topic. But I sense that this wouldn't be good either. I think on balance you're better leaving it as is. And I agree about the mathematic abstraction thing as well.- (User) Wolfkeeper (Talk) 01:19, 31 July 2009 (UTC)
In explaining that the brick-wall filter is not physically realizable: "(i.e., its compact support in the Fourier transform forces its time response to be ever lasting)" I changed it to: "(i.e., its compact support in the frequency domain forces its time response not to have compact support meaning that it is ever-lasting)"
It seems intuitive but a reference to why this is necessarily true would be nice.
- It is related to the relationship between the Fourier transform and the Uncertainty principle. See Mathematics of the Discrete Fourier Transform, Appendix C for instance. SpinningSpark 15:59, 9 October 2010 (UTC)
Problem with this filter
The filter shown in here is 2*CutoffFreq*sin(2*pi*CutoffFreq*t)/2*pi*CutoffFreq*t
So I tried to implement this in Visual Basic. I calculated t = m/SR (where SR is the samplerate of 8000 samples/second, and m is the sample number for the filter, and n is the sample number is the waveform to be processed).
My code is:
dim wave() as single
dim wave2() as single
const Pi as single = 3.14159
const SR as long = 8000
const CutoffFreq as single = 1000 'this is 1000 Hz
dim n as long
dim m as long
dim t as single
redim wave(SR-1) 'waveform lasts one second, and since the lower bound is zero, the upper bound is SR-1
for n = 0 to SR-1
for n = 20 to SR-1-20
for m = -20 to 20
if m=0 then
t=(m+0.0001)/SR 'this is needed to prevent a divide by zero error.
wave2(n)=wave2(n) + wave(n+m) * 2*CutoffFreq*sin(2*pi*CutoffFreq*t)/(2*pi*CutoffFreq*t) 'same arrangement shown in the Wikipedia article here, so it should work
'additional code down here saves the array wave2() to a file in raw (uncompressed) form for viewing waveform and audio playback in other software, but is not shown here as it is unimportant to the filter being discussed.
Ok, so that was my code, but there's a problem. The filter should only be able to reduce the signal's total strength (by cutting off some of its frequencies. It should not be able to strengthen the signal's intensity, at least not if it is properly implemented. Well the implementation I used is DIRECTLY FROM this Wikipedia article. And in this implementation I find that the signal output is 10s of decibels stronger than the input!!!!! This should not be happening. It seems that something is really wrong with the formula shown here on Wikipedia for a sinc lowpass filter. Can someone please figure out where the error is, and correct it. Benhut1 (talk) 01:16, 17 January 2014 (UTC)
Benhut1 The scaling issue you were seeing most probably comes from the incorrect sinc implementation. When implementing filter equation in code, you need to make sure that your sinc is correctly scaled near zero index. Otherwise the resulting filters will have amplification, but still correct frequency behaviour. — Preceding unsigned comment added by 18.104.22.168 (talk) 07:46, 23 September 2016 (UTC)
What is "f" in this article?
Ok, I FINALLY figured out what the article is talking about
This article, first off was VERY poorly written. It used variables in equations without defining exactly what the variables meant. For example, for the cutoff frequency (variable B), it didn't bother to mention how that frequency was being defined. Was it in terms of Hertz (for example values 0 to 24000 inclusive, are valid for a device with a 48000Hz sample rate)? Was it a relative frequency, relative to the Nyquist limit (any value from 0 to 1 inclusive, would be valid)? Well, it turns out to be neither of these. Finally (no thanks to this article) I was able to determine how the frequency was defined. It's a relative frequency, relative to the sample rate (with values 0 to 0.5 inclusive, being valid values). And how was time (variable t) defined? Again, this article didn't help. It could either refer to actual time (as measured in seconds), or the current sample number. Turns out it refers to the sample number. Again, I had to discover this on my own, because the person who wrote this article didn't bother to include this important information. And yes it is important. When somebody provides you with a formula to use, you shouldn't have to experiment around with it to figure out how to use it. It should be able to be used "right out of the box". If you can't use it "right out of the box" it means that the formula didn't come with enough explanation of how to use it (in this case a lack of explanation of how the variables were defined. This was just a very poorly written article. I hope the creator of this article reads this comment, and implements the changes in the article, so other people reading it (and who plan to use it, like I did) don't have to go through what I just went through. Benhut1 (talk) 02:32, 30 November 2016 (UTC)
- @Benhut1: The article was created in 2003 and the editor who created it has not been active since 2008. In any case, the page has been changed enormously since then by a whole procession of different editors. Wikipedia is the encyclopaedia that anyone can edit. That includes you. Feel free to improve the article. SpinningSpark 11:16, 30 November 2016 (UTC)