Wikipedia talk:AutoWikiBrowser/Bugs/Archive 9

From Wikipedia, the free encyclopedia
Jump to navigation Jump to search
Archive 8 Archive 9 Archive 10


Contents

Edit summary

Status Yes check.svg Fixed in the next release
Description When you start it without an edit summary, it gives you message telling you to add one. That's good, but it shouldn't start going through the pages giving you the message every time until you stop it and add one. Also, it should check to see if "Add replacements to edit summary" is checked. If it is, nothing more should be required since that's a pretty complete summary in itself. Rocket000 (talk) 02:02, 9 August 2008 (UTC)
To duplicate: Just press start it without an edit summary.
Operating system Windows XP
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


rev 3589. Will display it once, then stop processing Reedy 21:52, 23 December 2008 (UTC)

InvalidOperationException in TypoGroup.FixTypos

Status Yes check.svg Fixed in the next release
Description Thread: DB Scanner thread
Exception:InvalidOperationException
Message:Collection was modified; enumeration operation may not execute.
Call stack:
   at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
   at System.Collections.Generic.List`1.Enumerator.MoveNext()
   at WikiFunctions.Parse.TypoGroup.FixTypos(String& ArticleText, String& summary)
   at WikiFunctions.Parse.RegExTypoFix.PerformTypoFixes(String ArticleText, Boolean& NoChange, String& Summary)
   at WikiFunctions.Parse.RegExTypoFix.DetectTypo(String ArticleText)
   at WikiFunctions.DBScanner.Typo.Check(String& ArticleText, String& ArticleTitle, String ArticleTimestamp, String ArticleRestrictions)
   at WikiFunctions.DBScanner.MainProcess.ScanArticle(ArticleInfo ai)
   at WikiFunctions.DBScanner.MainProcess.Process()

Rich Farmbrough, 04:47 16 December 2008 (UTC). 04:47, 16 December 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6000.0
.NET FW Version Unknown
AWB version 4.4.2.0, revision 3552 (2008-12-13 22:16:46)
Workaround None
Fixed in version Unknown


Doesn't seem to like late loading of typos (on a seperate thread) - rev 3637. Still erroring though Reedy 13:37, 8 January 2009 (UTC)

rev 3639 Reedy 14:03, 8 January 2009 (UTC)

General fixes remove spaces from category sortkeys

Status Yes check.svg Fixed in the next release
Description General fixes are improperly removing spaces from right after the pipe before a sortkey.
To duplicate: Run general fixes on Category:Defunct Alabama railroads.
Operating system XP
.NET FW Version Unknown
AWB version 4.4.2.0
Workaround
Fixed in version Unknown


--NE2 13:31, 23 December 2008 (UTC)

This is causing me problems too. Lightmouse (talk) 00:20, 6 January 2009 (UTC)
rev 3642, it won't remove any whitespace from the piped bit of a category. Does it still need to remove trailing whitepsace (presumably..)?? As the leading whitespace being trimmed was the problem above. Reedy 16:47, 8 January 2009 (UTC)

Thanks. The leading space is an issue with sorting. A trailing space has no bearing on sorting and nobody has given any other valid reason for trailing spaces. So I think all trailing spaces (before the pipe and before the close brackets) should be removed. Lightmouse (talk) 22:04, 8 January 2009 (UTC)

rev 3649 Reedy 22:34, 8 January 2009 (UTC)

Loop event when attempting to edit another user's .css/.js

Status Yes check.svg Fixed in the next release
Description When an attempt is made to save an edit to another user's .css or .js subpage, the edit fails (inevitably) but the software then attempts to load the same page again, creating a loop. Happymelon 17:44, 2 January 2009 (UTC)
To duplicate: Attempt to edit a User:Foo/bar.css or .js page.
Operating system Vista
.NET FW Version Unknown
AWB version 4.4.2.0
Workaround
Fixed in version Unknown


I suspect as an admin this wont occur... Reedy 22:37, 2 January 2009 (UTC)
rev 3624, now checks and skips if the user cant edit the page Reedy 23:15, 2 January 2009 (UTC)

Database scanner. Namespace options in title tab don't appear to work

Status Yes check.svg Fixed in the next release
Description Database scanner. Namespace options in title tab don't appear to work. I was creating a list of templates only so I ticked the 'Template' option. It gave me lots of non-template results. Unfortunately, it took a long time and exceeded the 'limit results to <30,000>'. Lightmouse (talk) 19:48, 6 January 2009 (UTC)
To duplicate:
Operating system
.NET FW Version Unknown
AWB version svn3614
Workaround Write 'Template:' in 'Title contains'.
Fixed in version Unknown


Just the template namespace? Reedy 20:23, 6 January 2009 (UTC)

I don't know. I was only looking for templates and didn't test any others. It is extremely slow at parsing the big database so I didn't experiment. If you want me to run some tests, feel free to give me suggestions. Lightmouse (talk) 20:29, 6 January 2009 (UTC)

I tested each of the 'Namespaces' options in turn by adding a tick and unticking the others. Each of them produced results that were not confined to the selected namespace. Lightmouse (talk) 12:33, 8 January 2009 (UTC)
Yeah.. Seem it had all gotten messed up in the overhaul before. I've changed it now so that if its checked it will keep articles in that namespace. Various other cleanups too. rev 3636 Reedy 13:01, 8 January 2009 (UTC)

Thanks. I always download from the link at the top of this page. I can't work out what to do with rev 3636. I can wait. Lightmouse (talk) 13:11, 8 January 2009 (UTC)

Thats just the SVN rev, im trying to fix the bug below, then i'll put another snapshot out. Reedy 13:27, 8 January 2009 (UTC)
Uploaded.. Reedy 14:11, 8 January 2009 (UTC)

Thank you. It have tested it and it works as expected by the titles. It will be very helpful. I have the following comments:

  • It doesn't appear to give talk pages in the results anymore
  • The 7 'Namespace' options in the database scanner are similar to 6 of the 18 'Namespaces to keep' options in the Filter dialog. My instinct would be to make the options match in both places.

Lightmouse (talk) 17:22, 8 January 2009 (UTC)

Agreed... Though, im not sure why it was changed so drastically before.. Reedy 19:12, 8 January 2009 (UTC)
Most of the way there - rev 3644, just need to sort the designer out on the DBScanner. Would a popup form work? Hmm :/ Reedy 20:39, 8 January 2009 (UTC)

You could make the database scanner bigger. Lightmouse (talk) 20:52, 8 January 2009 (UTC)

rev 3647, rev 3648 Reedy 22:26, 8 January 2009 (UTC)

Thanks. I am looking at svn3650 now. It is a great improvement, much clearer. I hope you don't mind me making some further minor suggestions. Feel free to tell me to put them outside this bug report. Here goes:

  • You have a tab called 'Title - Namespace'. I think this would be better as simply 'Namespace'. The namespace is not merely a characteristic of the title. The equivalent title in the filter is 'Namespaces to keep' and that correctly avoids mentioning the title.  Done
  • You have a tab called 'Title - Other'. That could then become simply 'Title' again.  Done
  • In the 'Revision' tab you have 'Search Date' in word case. It should be sentence case.  Done
  • In the 'Revision' tab you have the words 'Between' and 'to'. I think of the pairing as 'Between'/'and' or 'From'/'to'. I don't know which is better but I am inclined towards 'From'/'to'.  Done
  • Group boxes. The 'Dump' tab has no group box and I think that is correct because there is nothing outside the group. The next three tabs have group boxes that I think should be eliminated because there is nothing outside the group. In such circumstances, a group box consumes space, makes the interface noiser, and gives you an additional task of naming the group. I may have mentioned this before. I think the whole interface could be made a bit cleaner by eliminating many group boxes entirely, and by replacing some others by 'Separator lines' that use less space. See http://msdn.microsoft.com/en-us/library/aa511459.aspx. In the main AWB interface, the 'Make list' group box is an example that could be eliminated at no cost. To the right of that, the 'Option' tab has three vertical group boxes ('Automatic changes', 'Find and replace', 'Regex typo fixing') that could use separator lines.

Just some suggestions. Lightmouse (talk) 10:03, 9 January 2009 (UTC)

rev 3653 - Done 3/4. Made a start on the DBScanner group box removal. Reedy 11:21, 9 January 2009 (UTC)

rev 3654. We have a problem regarding the separator... Its not actually there as a .NET 2 control. Its there in 3/3.5, but thats going to mean forcing users to upgrade to the newer .NET Framework... I think at the v5 jump (which, i suspect will be AWB + API edit), would be a good time to upgrade, now is certainly not.. Might see if there is a free control to do this.. Reedy 11:41, 9 January 2009 (UTC)

OK. Thanks for what you have done already. I will think of the separator as a wishlist item and leave it with you. Lightmouse (talk) 11:47, 9 January 2009 (UTC)

Would you mind sticking it as a feature request under your name? Removed the one from the Convert tab sheet too, as it adds nothing. rev 3655 Reedy 12:22, 9 January 2009 (UTC)

I have added it as a new feature request. Thanks for spotting that extra one. Lightmouse (talk) 13:18, 9 January 2009 (UTC)

InvalidOperationException in Application.ExitInternal

Status Works for me
Description
Exception:InvalidOperationException
Message:Collection was modified; enumeration operation may not execute.
Call stack:
   at System.Collections.ArrayList.ArrayListEnumeratorSimple.MoveNext()
   at System.Windows.Forms.Application.ExitInternal()
   at System.Windows.Forms.Application.ThreadContext.OnThreadException(Exception t)
   at System.Windows.Forms.Control.WndProcException(Exception e)
   at System.Windows.Forms.Control.ControlNativeWindow.OnThreadException(Exception e)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
   at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.Run(Form mainForm)
   at AutoWikiBrowser.Program.Main(String[] args)

Pigman 05:36, 30 April 2008 (UTC) Tjarrett (talk) 14:52, 29 May 2008 (UTC) Also

   at System.Collections.ArrayList.ArrayListEnumeratorSimple.MoveNext()
   at System.Windows.Forms.Application.ExitInternal()
   at System.Windows.Forms.Application.Exit(CancelEventArgs e)
   at System.Windows.Forms.Application.Exit()
   at AutoWikiBrowser.MainForm.RunUpdater()
   at AutoWikiBrowser.MainForm.OldVersion()
   at AutoWikiBrowser.MainForm.MainForm_Load(Object sender, EventArgs e)

on XP SP1

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.1.0
Workaround None
Fixed in version Unknown


Here is the MS code that throws the exception. A question: which forms were open at the time you chose to close AWB? MaxSem(Han shot first!) 16:30, 30 April 2008 (UTC)

I have no idea. I forgot to check back here about this error and it's long gone from my memory. Unfortunately, I can't follow the code in the link you referenced above. My programming knowledge is small and ancient. "There's this newfangled technique called modular programming!" "Can I use it with COBOL?" "I think so." 'nuff said. Pigman 18:53, 29 May 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:26, 12 January 2009 (UTC)


InterwikiLocalAlpha is null

Status Bug currently being investigated/fixed
Description
Exception:Exception
Message:InterwikiLocalAlpha is null
Call stack:
   at WikiFunctions.Parse.MetaDataSorter..ctor(Parsers p)
   at WikiFunctions.Parse.Parsers.set_InterWikiOrder(InterWikiOrderEnum value)
   at AutoWikiBrowser.MainForm.SetProject(LangCodeEnum code, ProjectEnum project, String customProject)
   at AutoWikiBrowser.MainForm.LoadPrefs(UserPrefs p)
   at AutoWikiBrowser.MainForm.LoadPrefs()
   at AutoWikiBrowser.MainForm.MainForm_Load(Object sender, EventArgs e)

Katr67 (talk) 13:31, 23 May 2008 (UTC) SteveRwanda (talk) 16:21, 29 December 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.2.0 and 4.4.1.1
Workaround None
Fixed in version Unknown


Doesn't this just mean failed to connect to Wikipedia AWB page? I.e. not a bug, just need to catch this and present user with connection error message ? Rjwilmsi 22:40, 5 October 2008 (UTC)
Usually, yeah.. Would mean it hasnt loaded the IW list and then made the other arrays for the other orderings... Reedy 22:41, 5 October 2008 (UTC)

The program has encountered the following problem: InterwikiLocalAlpha is null

Remark: I started the program while disconnected from Internet. -- Magioladitis (talk) 09:00, 5 December 2008 (UTC)

That'd be why then! Needs to handle this more gracefully though! Reedy 15:52, 5 December 2008 (UTC)

Occured immediately after starting new version. neuro(talk) 00:05, 14 December 2008 (UTC)

Turns out I can't use AWB at all, as it won't load the checkpage. neuro(talk) 00:09, 14 December 2008 (UTC)
To add some more detail - iexplore works fine. neuro(talk) 00:11, 14 December 2008 (UTC)
Made a change for the next revision, so it should hopefully give us a bit of a more specific/useful error message Reedy 15:06, 4 January 2009 (UTC)

AWB encountered Win32Exception

Status Works for me
Description
Exception:Win32Exception
Message:Error creating window handle.
Call stack:
   at System.Windows.Forms.NativeWindow.CreateHandle(CreateParams cp)
   at System.Windows.Forms.Control.CreateHandle()
   at System.Windows.Forms.Control.get_Handle()
   at System.Windows.Forms.Control.CreateGraphicsInternal()
   at System.Windows.Forms.ThreadExceptionDialog..ctor(Exception t)
   at System.Windows.Forms.Application.ThreadContext.OnThreadException(Exception t)
   at System.Windows.Forms.Control.WndProcException(Exception e)
   at System.Windows.Forms.Control.ControlNativeWindow.OnThreadException(Exception e)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
   at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.Run(Form mainForm)
   at AutoWikiBrowser.Program.Main(String[] args)

TheHYPO (talk) 01:48, 5 May 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.1.0
Workaround None
Fixed in version Unknown


I'm also getting this on occasion, when I right click on the list of skipped articles in the logs tab. Rjwilmsi (talk) 22:31, 8 May 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:26, 12 January 2009 (UTC)

AWB encountered NullReferenceException in MainForm.GetDiff()

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at AutoWikiBrowser.MainForm.GetDiff()

- Jameson L. Tai talkcontribs 12:59, 8 May 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6000.0
.NET FW Version Unknown
AWB version 4.3.1.1
Workaround None
Fixed in version Unknown


Hmm... Did you just click something before AWB finished loading? MaxSem(Han shot first!) 14:42, 14 May 2008 (UTC)

Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:26, 12 January 2009 (UTC)

AWB encountered COMException in IWebBrowser2.Navigate2()

Status Works for me
Description
Exception:COMException
Message:The requested resource is in use. (Exception from HRESULT: 0x800700AA)
Call stack:
   at System.Windows.Forms.UnsafeNativeMethods.IWebBrowser2.Navigate2(Object& URL, Object& flags, Object& targetFrameName, Object& postData, Object& headers)
   at System.Windows.Forms.WebBrowser.PerformNavigate2(Object& URL, Object& flags, Object& targetFrameName, Object& postData, Object& headers)
   at System.Windows.Forms.WebBrowser.PerformNavigateHelper(String urlString, Boolean newWindow, String targetFrameName, Byte[] postData, String headers)
   at System.Windows.Forms.WebBrowser.Navigate(String urlString)
   at WikiFunctions.Browser.WebControl.LoadEditPage(String Article)

asenine say what? 19:34, 10 May 2008 (UTC) Shadoew Phoenix (talk) 01:59, 13 June 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6001 Service Pack 1
.NET FW Version Unknown
AWB version 4.3.1.0
Workaround None
Fixed in version Unknown


Bloody web control.. Moar infos, but i dont think we disable it during processing... Reedy 09:45, 13 June 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)


Cannot connect to interwiki or load typos

Status Nuvola apps important.svg New
Description When trying to load AWB for the last 2 days I have been getting several errors and I cannot use tha application. Here are the errors that I get in order of appearance.

1) The interwiki list didn't load correctly. Please check your internet connection and then restart AWB. 2) I get the REGEX attention screen 3) Load from English wikipedia?: No list of typos was found. Would you like to use the list of typos from the enlish wikipedia? Only choose yes if this is english wiki. I select Yes 4) There was a problem loading the list of typos 5) Cannot load version checkpage from wikipedia. Please verify that youve connected to the internet. Thats it and I can connect to the internet with everything else. Also, it seems to happen when its trying to load Main form:load prefs ().--Kumioko (talk) 12:57, 9 April 2008 (UTC)

To duplicate:
Operating system Windows XP
.NET FW Version Unknown
AWB version
Workaround
Fixed in version Unknown


Can you access Wikipedia from Internet Expolorer? Did something change in your network settings recently? MaxSem(Han shot first!) 09:00, 12 April 2008 (UTC)

Yes I can access IE, No nothing changed. I found a workaround and that is if I open IE and login to Wikipedia AWB will work. If I logout or close IE then it will not work. Its only with the newest version of AWB also.--Kumioko (talk) 13:55, 14 April 2008 (UTC)
Well, I spoke to soon. I was able to access it for 1 day and now I can't access it again. Is it possible someone suspended my access accidentally or something?--Kumioko (talk) 13:19, 17 April 2008 (UTC)
These error messages mean that AWB is physically unable to connect to Wikipedia servers. Even if you are removed from the list of approved users or blocked, you should be able to connect to the wiki. Since the problem disappeared for a while without any changes to AWB and then resurfaced for no obvious reason, it looks like that you're facing some kind of technical failure on your side, unrelated to AWB. MaxSem(Han shot first!) 14:51, 18 April 2008 (UTC)
Thanks, that really stinks, maybe the next version will fix it somehow. I have tried it at work and at home and neither works. Guess I was making too many edits too fast..Seems strange though that I can access the internet as long as I don't use AWB.:-)--Kumioko (talk) 19:58, 22 April 2008 (UTC)

I sent a debug version to Lvova who experiences similar problems, here's what happening:

Object: WikiFunctions.UserProperties
Time: 14:23:56
Message: Cannot find the specified file. (Exception from HRESULT: 0x80070002)

Object: WikiFunctions.UserProperties
Time: 14:23:56
Message:    at System.Windows.Forms.UnsafeNativeMethods.IPersistStreamInit.Save(IStream pstm, Boolean fClearDirty)
   at System.Windows.Forms.WebBrowser.get_DocumentStream()
   at System.Windows.Forms.WebBrowser.get_DocumentText()
   at WikiFunctions.Browser.WebControl.get_HasArticleTextBox()
   at WikiFunctions.Browser.WebControl.GetArticleText()
   at WikiFunctions.UserProperties.UpdateWikiStatus()

Which is weird. I've asked about it on a programming forum, waiting for reply. MaxSem(Han shot first!)

AWB encountered NullReferenceException in MyTrace.ValidateUploadProfile()

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at AutoWikiBrowser.Logging.MyTrace.ValidateUploadProfile()

195.128.232.70 (talk) 13:18, 18 June 2008 (UTC) --¤ The-G-Unit-฿oss ¤ 13:20, 18 July 2008 (UTC)

To duplicate: [encountered while processing page [1]]
Operating system Microsoft Windows NT 5.1.2600 Szervizcsomag 1
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

AccessViolationException

Status Works for me
Description
Exception:AccessViolationException
Message:Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Call stack:
   at System.Windows.Forms.UnsafeNativeMethods.IHTMLDocument2.Open(String mimeExtension, Object name, Object features, Object replace)
   at System.Windows.Forms.HtmlDocument.OpenNew(Boolean replaceInHistory)
   at AutoWikiBrowser.MainForm.GetDiff()

Chet B. LongTalk/ARK 07:38, 21 July 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6001 Service Pack 1
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

DivideByZeroException

Status Nuvola apps important.svg New
Description
Exception:DivideByZeroException
Message:Attempted to divide by zero.
Call stack:
   at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at System.Windows.Forms.NativeWindow.DefWndProc(Message& m)
   at System.Windows.Forms.Control.DefWndProc(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Lightmouse (talk) 14:58, 6 September 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.3.2.1, revision 3290 (2008-09-01 21:57:15)
Workaround None
Fixed in version Unknown


I am not sure when or where it occurred. Lightbot is going through 'Category:Living people' if that helps. See Lightbot contributions. Lightmouse (talk) 14:58, 6 September 2008 (UTC)

This is that flash window thing again it seems... I thought Max had suppressed this inn the svn versions> Reedy 08:13, 7 September 2008 (UTC)

OK. The AWB run appears to continue as normal. But it is an inconvenience because the dialog keeps focus I can't do anything with AWB. I have to stop the run by doing Ctrl-Alt-Del and losing some data (e.g. current list, logs). If it is really tricky to fix and only crops up as rarely as I think it does, I can live with it as a known issue. Lightmouse (talk) 10:42, 7 September 2008 (UTC)

You could just turn off window flash. The code is in a windows library, meaning we cant do much about it, the error trapping MaxSem put in seems not to have worked... Reedy 15:08, 10 September 2008 (UTC)

How do I turn off window flash? Lightmouse (talk) 18:06, 10 September 2008 (UTC)

Options, User and project preferences, editing tab. Untick flash and then save your settings. Let us know if you get it again Reedy 19:31, 10 September 2008 (UTC)

It is already unticked. I have never used the 'User and project preferences' menu item before. Lightmouse (talk) 08:53, 12 September 2008 (UTC)

And ironically, the warning has just happened again. Lightmouse (talk) 10:49, 12 September 2008 (UTC)
Hmm. That means it isnt what we thought it was before... And the stack trace doesnt give us any sort of entry point to look at... Reedy 12:07, 12 September 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

The type initializer for 'WikiFunctions.Parse.SiteMatrix' threw an exception.

Status Works for me
Description
Exception:TypeInitializationException
Message:The type initializer for 'WikiFunctions.Parse.SiteMatrix' threw an exception.
Call stack:
   at WikiFunctions.Parse.MetaDataSorter..ctor(Parsers p) in C:\Documents and Settings\RJW\Desktop\AWB\AWB\WikiFunctions\MetaDataSorter.cs:line 225
   at WikiFunctions.Parse.Parsers.set_InterWikiOrder(InterWikiOrderEnum value) in C:\Documents and Settings\RJW\Desktop\AWB\AWB\WikiFunctions\Parsers.cs:line 111
   at AutoWikiBrowser.MainForm.SetProject(LangCodeEnum code, ProjectEnum project, String customProject) in C:\Documents and Settings\RJW\Desktop\AWB\AWB\AWB\Main.cs:line 2105
   at AutoWikiBrowser.MainForm.LoadPrefs(UserPrefs p) in C:\Documents and Settings\RJW\Desktop\AWB\AWB\AWB\UserSettings.cs:line 314
   at AutoWikiBrowser.MainForm.LoadPrefs() in C:\Documents and Settings\RJW\Desktop\AWB\AWB\AWB\UserSettings.cs:line 282
   at AutoWikiBrowser.MainForm.MainForm_Load(Object sender, EventArgs e) in C:\Documents and Settings\RJW\Desktop\AWB\AWB\AWB\Main.cs:line 266
Inner exception:XmlException
Message:Data at the root level is invalid. Line 1, position 1.
Call stack:
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
   at System.Xml.XmlTextReaderImpl.ParseRootLevelWhitespace()
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlLoader.Load(XmlDocument doc, XmlReader reader, Boolean preserveWhitespace)
   at System.Xml.XmlDocument.Load(XmlReader reader)
   at System.Xml.XmlDocument.LoadXml(String xml)
   at WikiFunctions.Parse.SiteMatrix..cctor() in C:\Documents and Settings\RJW\Desktop\AWB\AWB\WikiFunctions\MetaDataSorter.cs:line 61

Rjwilmsi 07:11, 30 September 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.4.0.1, revision 3413 (2008-09-28 11:25:27)
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

FileNotFoundException

Status Works for me
Description
Exception:FileNotFoundException
Message:Unknown
Call stack:
   at System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName)
   at System.Configuration.ClientConfigPaths.SetNamesAndVersion(String applicationFilename, Assembly exeAssembly, Boolean isHttp)
   at System.Configuration.ClientConfigPaths..ctor(String exePath, Boolean includeUserConfig)
   at System.Configuration.ClientConfigPaths.GetPaths(String exePath, Boolean includeUserConfig)
   at System.Configuration.Internal.ConfigurationManagerInternal.System.Configuration.Internal.IConfigurationManagerInternal.get_ExeProductName()
   at System.Configuration.ApplicationSettingsBase.get_Initializer()
   at System.Configuration.ApplicationSettingsBase.CreateSetting(PropertyInfo propInfo)
   at System.Configuration.ApplicationSettingsBase.EnsureInitialized()
   at System.Configuration.ApplicationSettingsBase.get_Properties()
   at System.Configuration.SettingsBase.GetPropertyValueByName(String propertyName)
   at System.Configuration.SettingsBase.get_Item(String propertyName)
   at System.Configuration.ApplicationSettingsBase.GetPropertyValue(String propertyName)
   at System.Configuration.ApplicationSettingsBase.get_Item(String propertyName)
   at AutoWikiBrowser.Properties.Settings.get_WindowLocation()
   at AutoWikiBrowser.MainForm.InitializeComponent()
   at AutoWikiBrowser.MainForm..ctor()
   at AutoWikiBrowser.Program.Main(String[] args)

TwentiethApril1986 (talk) 14:42, 8 October 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

InvalidOperationException in UserPrefs.LoadPrefs

Status Works for me
Description
Exception:InvalidOperationException
Message:There is an error in XML document (0, 0).
Call stack:
   at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, XmlDeserializationEvents events)
   at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle)
   at System.Xml.Serialization.XmlSerializer.Deserialize(TextReader textReader)
   at WikiFunctions.AWBSettings.UserPrefs.LoadPrefs(String file)
   at AutoWikiBrowser.MainForm.LoadPrefs(String path)
Inner exception:XmlException
Message:Root element is missing.
Call stack:
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ThrowWithoutLineInfo(String res)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlTextReader.Read()
   at System.Xml.XmlReader.MoveToContent()
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderUserPrefs.Read26_AutoWikiBrowserPreferences()

J Milburn (talk) 17:23, 14 October 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


Can you publish the settings file you've been trying to open? MaxSem(Han shot first!) 18:07, 14 October 2008 (UTC)

How do I do that? J Milburn (talk) 18:51, 20 October 2008 (UTC)
Paste whatever settings file you are using to a wikipage =) Reedy 19:38, 20 October 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

COMException in WebControl.Login

Status Works for me
Description
Exception:COMException
Message:Error HRESULT E_FAIL has been returned from a call to a COM component.
Call stack:
   at System.Windows.Forms.UnsafeNativeMethods.IHTMLElement.SetInnerText(String p)
   at System.Windows.Forms.HtmlElement.set_InnerText(String value)
   at WikiFunctions.Browser.WebControl.Login(String username, String password)
   at WikiFunctions.Profiles.AWBProfilesForm.browserLogin(String Username, String Password)
   at WikiFunctions.Profiles.AWBProfilesForm.browserLogin(String Password)
   at WikiFunctions.Profiles.AWBProfilesForm.login()

Paxse (talk) 12:55, 15 November 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.0.2195 Service Pack 4
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


Hope that helps! Paxse (talk) 12:55, 15 November 2008 (UTC)

Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

AccessViolationException in Program.Main (pt-wiki)

Status Works for me
Description
Exception:AccessViolationException
Message:Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Call stack:
   at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
   at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.Run(Form mainForm)
   at AutoWikiBrowser.Program.Main(String[] args)

Maurício I (talk) 10:57, 18 December 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.4.2.0, revision 3552 (2008-12-13 22:16:46)
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:30, 12 January 2009 (UTC)

Inability to retrieve lists from special pages, image pages or links

Status Bug currently being investigated/fixed
Description AWB won't fetch from special pages. Reedy Boy also tested links and image pages, which also incorrectly return no results. – Mike.lifeguard | @en.wb 23:52, 18 January 2008 (UTC)
To duplicate: Attempt to create a list from any special page etc.
Operating system XP SP2
.NET FW Version Unknown
AWB version SVN 2011
Workaround manual list creation :(
Fixed in version Unknown


I think some work. Just not all/that image one... Reedy Boy 00:07, 19 January 2008 (UTC)
4.2.0.2 still has this bug. You may well be correct; I've only tried to fetch a a list from Special:Unusedimages. – Mike.lifeguard | @en.wb 19:04, 28 January 2008 (UTC)
Same issue here. Tried Allpages and Prefixindex (both of which worked before); neither return any results. --TMF Let's Go Mets - Stats 02:42, 17 February 2008 (UTC)
4.3.0.0 still has this problem.
(Ru-Wikipedia)
Unusedimages still does not work. Gives 0.
But Contributions&namespace=6&limit=50&target=Alex+Spade has start to give out something - but its results are strange - it give out 102 pages, one of them is from Участник-space (User-space), more over I didn't edit the respective page. Alex Spade (talk) 21:28, 5 March 2008 (UTC)
Special:Newpages is consistently returning around 85 pages, only 20 of which are mainspace, no matter what parameters I use. A random sampling of those pages show that none of them are new. For example, Woodland, California, a page created in 2002, is one of the mainspace pages returned just now. --Fabrictramp (talk) 22:06, 5 March 2008 (UTC)
As of version 4.3.1.0, "Make from" Special page with 'NewPages' on English Wikipedia retrieves 0 pages! --Russ (talk) 16:30, 30 April 2008 (UTC)
Version 4.3.2.0: Special:NewPages now returns a page list; however, if a series of parameters is supplied (for example, "NewPages&dir=prev&limit=50"), AWB doesn't always seem to recognize them. "NewPages&dir=prev&limit=50" returns 197 pages, but it should only return 50. Other parameters, such as "hidepatrolled=1", seem to work inconsistently or not at all. All these parameters ought to be passed unchanged into the URL. --Russ (talk) 14:22, 19 May 2008 (UTC)

Hopefully gonna get this fixed up (all of it) as part of the underway list maker overhaul. Reedy 09:22, 28 May 2008 (UTC)

Link on Page, Images on Page, Image file links all work... Special doesnt seem to as it should. Reedy 09:31, 28 May 2008 (UTC)
Special:Shortpages works fine... (And any that are similar, with just a list of links on the page) I think the special pages just need overhauling completely.. Wonder if we can find out if there is a standard "template" for them or 2. Reedy 16:44, 28 May 2008 (UTC)
You should be able to get all this from api rather than parsing the special page... – Mike.lifeguard | @en.wb 00:16, 29 May 2008 (UTC)
Didnt see this reply. How can you? Is that, "you should", but you cant? Reedy 14:18, 16 June 2008 (UTC)

[2] - MW bug opened for extra special page access Reedy 17:51, 20 July 2008 (UTC)

I'm going to close this and move to archives. I know it needs to be done, and will get on with it as and when specifics are requested, or the bug is completed Reedy 15:34, 9 January 2009 (UTC)

Edit logged as successfully saved when Foundation error page is displayed

Status Yes check.svg Fixed in the next release
Description An edit is logged as successfully saved when the multi-lingual Foundation error page is displayed and the edit is not made. mattbr 15:08, 4 May 2008 (UTC)
To duplicate:
Operating system Windows Vista
.NET FW Version Unknown
AWB version 4.3.1.0
Workaround
Fixed in version Unknown


The same problem arises when the database is 'temporarily in read only mode' and edits marked as successful have not in fact taken place. Thanks Rjwilmsi (talk) 07:38, 17 May 2008 (UTC)

If it helps, the source of the 'Foundation' error message is in SVN at [3]. mattbr 11:27, 25 May 2008 (UTC)

Yeah, that is helpful. Just need to work out what to hang onto (what would be unique to the page), or if we need to ask nicely for something like the <DIV id=spamprotected> adding to this page. Reedy 12:20, 26 May 2008 (UTC)
Devs - Added placeholders commented out for this. rev 2488. Asked in #mediawiki about a unique identifier for the WMF error page, no response as of yet. Reedy 12:38, 26 May 2008 (UTC)
Probably should ask nicely/post a bugzilla request for these.. Reedy 14:20, 16 June 2008 (UTC)

rev 2942 - That does the WMF error. Just need to sort out the MediaWiki:Readonlytext... Reedy 14:50, 16 June 2008 (UTC)

[4], rev 3304. Going to get the WMF one done properly too. Reedy 22:07, 12 September 2008 (UTC)
[5] rev 3305, rev 3306 (minor tweaks to previous) Reedy 22:17, 12 September 2008 (UTC)
Does this fix "Could not save possibly due to timeout" (I parapharse) which exhibited the same problem? Rich Farmbrough, 11:13 22 October 2008 (UTC).

Underscores again

I have create a category Category:Articles with underscores in the title, can this be used to drive the existing mechanism of not "subs"ting _ in links? Rich Farmbrough, 16:03 26 August 2008 (GMT).

Was it just done as templates before...? Reedy 18:09, 26 August 2008 (UTC)
Not sure but I think it was done by a what links here. I had the archived message up but can't find it now. Rich Farmbrough, 00:18 27 August 2008 (GMT).
Back in JUne 2007 there was this cat: Category:Wikipedia articles with a wrong title because it is capitalised and underscores are substituted for spaces. Before the days of hidden cats, so ... Rich Farmbrough, 00:36 27 August 2008 (GMT).
And even before that there was Category:Articles with an underscore in their title. Again the reasons for deleting this have gone with hidden cats and the removal of the underscore templates. Rich Farmbrough, 00:43 27 August 2008 (GMT).
Im sure it was {{underscore}} and another one (which then maybe had a category which it added). As the template changed the title name aswell on the page. Reedy 15:02, 27 August 2008 (UTC)
Yes the other one was {{Lower case and unserscore}}. Rich Farmbrough, 19:11 30 August 2008 (GMT).
[6] would be better still... Reedy 21:32, 12 September 2008 (UTC)

White space bug

Status Yes check.svg Fixed in the next release
Description AWB doesn't ignore white spaces [7]
To duplicate: Run AWB with Skip:Only white space changes
Operating system XP
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround
Fixed in version Unknown


Change in capitalisation isnt a whitespace change. The skip if only whitespace changes literally does that - If whitespace has been added/removed... Suppose, seeing as i changed the code in rev 2486, i could change
        public bool OnlyWhiteSpaceChanged
        {
            get { return (string.Compare(Regex.Replace(mOriginalArticleText, @"\s+", ""), Regex.Replace(mArticleText, @"\s+", "")) == 0); }
        }

Into

        public bool OnlyWhiteSpaceChanged
        {
            get { return (string.Compare(Regex.Replace(mOriginalArticleText, @"\s+", ""), Regex.Replace(mArticleText, @"\s+", ""), true) == 0); }
        }

So it wouldnt be case sensitive (true means it ignores case), and would pickup the above change as only whitespace changed. Suppose that could make some sense... Reedy 21:08, 28 May 2008 (UTC)

So if you make the change, surely then an edit with only the typo correction 'english' --> 'English' would be classed skippable as 'only whitespace changed', even though this would not be a whitespace change, as the result of the edit would be a visible change to the displayed article? Rjwilmsi (talk) 22:10, 28 May 2008 (UTC)
Yeah, then its not actually doing what it should be. Reedy 08:25, 29 May 2008 (UTC)
Sorry bad examples have a look at[8] [9]

[10]Gnevin (talk) 23:24, 28 May 2008 (UTC)

Thats more evident of the bug (as literally there is only whitespace changed)... Hmm Reedy 08:25, 29 May 2008 (UTC)

All of changes are only due to the linefeed, would enabling single line (?s) fix this. Also can we have an option to ignore case changing? Then we could order the dialog option as such

[ ] No changes made
    [ ] Only white space is changed
    [ ] Only casing is changed

That way we don't have Smackbot needlessly capitalizing templates. Make them suboption reduces the confusion of why you can check only white space changes while somehow ignoring that there's been no changes made. — Dispenser 23:06, 3 June 2008 (UTC)

Hmm.. Might be singleline related (sounds maybe right).. Will try tommorow (see if it fixes it). And the only casing changed is doable, as shown above, by making the comparison not case sensitive.... Sounds a good idea to me. Reedy 01:08, 4 June 2008 (UTC)

Notes for my self -

  • no change - (orig == current), already implemented
  • only whitespace (orig with whitespace removed == current with whitespace removed)
  • only casing changed (string compare of orig and current that is case-insensitive)
  • if only whitespace && only casing changed both checked (string compare of orig with whitespace removed and current with whitespace removed)

Presumably the lower 2 boxes enabled if no changes is checked? Or just visually sub-options?

Reedy 15:50, 6 June 2008 (UTC)

rev 2907 puts the properties onto into Article... Just need to know about the designer stuff and i'll get it sorted Reedy 17:19, 7 June 2008 (UTC)
rev 2912 - That adds the stuff to the designer, a savable setting, and allows for skip if only casing/whitespace changed... Now the bug just needs fixing... Reedy 17:53, 8 June 2008 (UTC)

Just tried one of the unskipped diff's above, and in the AWB sandbox it skipped fine.. (not sure how such a simple regex that matches any whitespace character, between 1 and unlimited times, can actually fail...) Reedy 18:05, 8 June 2008 (UTC)

I'm not sure how its implemented in C sharp but it seems that combining the function into on would be better (python example again):
def hasChanged(ignorecase = False, whitespace = False):
    if(whitespace):
        # python "and" == C# "&& "and ''not'' binary "AND" of VB
        return (re.sub(r"\s+", "", mOriginalArticleText, (ignorecase and re.IGNORECASE)) == re.sub(r"\s+", "", mArticleText, (ignorecase and re.IGNORECASE)))
    else:
        # Slipping into C#
        return string.Compare(Regex.Replace(mOriginalArticleText, @"\s+", ""), Regex.Replace(mArticleText, @"\s+", ""), ignorecase) == 0
Again, I do not understand exactly how your implementing it in C#. And on the question of the interface since the options to the same they should be as a sub category of the no changes button. — Dispenser 10:07, 13 June 2008 (UTC)
The booleans are done from the form, not from the article object, where the skip checks are. So this basically just does the same, and stops us having to pass the actual variables to the article to have that deal with it.. It works fine, other than the \s+ seemingly not always working and replacing whitespace, which is a bit strange. If you SVN update you can see the designer stuff... Reedy 11:41, 13 June 2008 (UTC)
So they're properties, learned something new. My complaint above is really related to the logic, if only chkSkipWhitespace is checked then it will also act as if chkSkipNoChanges is also checked. So either a matrix will need to be made or chkSkipWhitespace and chkSkipCasing need to be nested inside chkSkipNoChanges condition. — Dispenser 17:00, 13 June 2008 (UTC)
Yeah, if the first line of the block has a (), with or without parameters, thats a method. If it doesnt have the (), its a property, and this can be read and/or write. So you can effectively have 2 "methods" for the same thing, under the same name (NB, when compiled, it all goes down to very similar code anyway)
The logic is set out, that the skip if no changes takes priority (ie its checked first), then skip if whitespace, skip if casing, and if both of the latter are checked, it does a different property to do a case sensitive whitespace comparison. I cant really see a need to change it... Reedy 17:49, 13 June 2008 (UTC)

Not sure if this is still there/needs keeping open... Can you try it in an up to date svn snapshot, and see if the problem is still occuring. Reedy 20:32, 16 June 2008 (UTC)

Will try it tonight Gnevin (talk) 07:37, 13 August 2008 (UTC)

This bug seems to still be occurring, I'm doing a large run and though I've got "Only whitespace is changed," it is definitely not skipping edits where AWB is only suggesting the removal of one or more extra blank lines. I thought maybe it was my error, something else checked or unchecked improperly, but ... In any case, I thought it a weird coincidence that the option itself isn't covered in the appropriate section of the user manual, as if it was newly-added function or had been removed because of the malfunction. Is it working for anyone? — TAnthonyTalk 20:35, 13 August 2008 (UTC)

Is that on the latest SVN snapshot?? Reedy 21:29, 13 August 2008 (UTC)
Sorry, not sure what that is. — TAnthonyTalk 21:33, 13 August 2008 (UTC)
OK, found what u mean, but I'm using the latest rev, 4.3.2.0, are these "snapshots" updates to that? — TAnthonyTalk 21:36, 13 August 2008 (UTC)
Yeah. 4.3.2.0 is the latest release version. Changes to this code (and loads of other stuff) have been done in the SVN. The snapshots are a build from the SVN, so have much updated code in them. Reedy 21:40, 13 August 2008 (UTC)
Have tried the latest SVN and 4.3.2.0 but none of them are highlighting the whitespaces in these revisions , [11] [12]

[13] which is strange as the white space is their and should be removed ,also the version hasn't changed Gnevin (talk) 22:16, 13 August 2008 (UTC) SB capitalisation only: this happens so infrequently as not to be a worry to me. In something over a million edits, I've had I think three people comment. And it should become rarer as time goes by. Rich Farmbrough, 00:03 27 August 2008 (GMT).

I think this is closed (as its implemented)/wontfix (rare random bugs) then. That alright? Reedy 10:42, 3 September 2008 (UTC)
Can be closed if AWB removes the white spaces in the examples above which it doesn't appear to be doing at all now Gnevin (talk) 01:21, 12 September 2008 (UTC)
Re-adding , is the behaviour I now experience correct? Gnevin (talk) 21:49, 14 September 2008 (UTC)

Is this still problematic, or...? Reedy 15:30, 9 January 2009 (UTC)

when the database is locked AWB skips with the reason "Page is protected"

Status Yes check.svg Fixed in the next release
Description when the database is locked AWB skips with the reason "Page is protected". Previously, AWB would give the reason the "database is locked...". Rjwilmsi 18:27, 16 September 2008 (UTC)
To duplicate:
Operating system XP
.NET FW Version Unknown
AWB version SVN 3325
Workaround
Fixed in version Unknown


Have to test this myself later... Should be a simple fix Reedy 18:53, 26 December 2008 (UTC)
rev 3660 Reedy 15:14, 9 January 2009 (UTC)

HTTP/FTP format fixes applied to text within external links, rather than just the start

Status Yes check.svg Fixed in the next release
Description The HTTP/FTP format fixes within the AWB gen fixes are being applied within external links, rather than just the start. Examples of articles include List of mathematics competitions and Gaza. I reckon that HTTP/FTP fixes should only apply where the HTTP/FTP part is preceded by regex class [\s\[>=]. The following unit tests would then pass:
// string before and after
@"<ref>http//www.site.com</ref>", @"<ref>http://www.site.com</ref>"
@"at http//www.site.com", @"at http://www.site.com"
@"<ref>[http:/www.site.com a website]</ref>", @"<ref>[http://www.site.com a website]</ref>"
@"*[http//www.site.com a website]", @"*[http://www.site.com a website]"
@"|url=http//www.site.com", @"|url=http://www.site.com"
@"|url = http:/www.site.com", @"|url = http://www.site.com"

// these strings should not change
@"http://members.bib-arch.org/nph-proxy.pl/000000A/http/www.basarchive.org/bswbSearch"
@"http://sunsite.utk.edu/math_archives/.http/contests/"
@"HTTP/0.9"
@"HTTP/1.0"
@"HTTP/1.1"
@"HTTP/1.2"

Thanks Rjwilmsi 17:07, 13 October 2008 (UTC)

To duplicate:
Operating system XP
.NET FW Version Unknown
AWB version SVN
Workaround
Fixed in version Unknown


Filing a note here, as this can be subsumed. HTTP/1.1 is a standard designation of HTTP version 1.1 therefore we should probably not substitute HTTP/\d+\.{0,1}\d*([;:,\s]|\.\s) or something. Rich Farmbrough, 11:27 22 October 2008 (UTC).
Okay, I've added extra unit tests to make sure HTTP standards per HTTP/1.1#HTTP_versions won't be touched. Rjwilmsi 10:33, 26 October 2008 (UTC)
You must not use GenfixesTests when everything you need to test is located in one function/class. MaxSem(Han shot first!) 10:59, 26 October 2008 (UTC)
Okay, I've made the unit tests generic so that a developer can add them using the right test class. Rjwilmsi 12:08, 26 October 2008 (UTC)
I dont think MaxSem was specifically meaning that. We can test individual Parser/tools/whatever functions, but we can also test the general fixes as a whole, so we can pass text passages through and see what the combined affect is. I suspect, MaxSem was meaning, the tests could be put in more specific categories, where, similar methods can be used, but not exactly. Granted, its not the easiest to follow (not really Max's fault - the AWB code isnt always the simplest to work out). It is more like using Assert.AreEqual() in the right place.
Assert.AreEqual("Target Text", Parsers.ParserMethod("Input Text"));

Your wanting the output of the specified method to give the same as the first bit of text. Hope this makes some sense? Reedy 14:23, 26 October 2008 (UTC)

Rjwilmsi, wheres the regex change need making? Reedy 22:36, 27 October 2008 (UTC)
I couldn't find the relevant code! Rjwilmsi 23:01, 27 October 2008 (UTC)

[14] for reference. Reedy 22:41, 10 January 2009 (UTC)

parsers.FixSyntax() is at fault, adding tests above in rev 3673 Reedy 22:51, 10 January 2009 (UTC)
Ah, got it. The MutlipleHttpInLink regex is at fault. Replace it with the regex from
Regex.Replace(ref ArticleText, @"(?i)([\s\[>=])((?:ht|f)tp:?/+)(\2)+", "$1$2"); 
Thanks Rjwilmsi 00:08, 11 January 2009 (UTC)
Index: Parse/Parsers.cs
===================================================================
--- Parse/Parsers.cs	(revision 3672)
+++ Parse/Parsers.cs	(working copy)
@@ -491,9 +491,8 @@
         // same shit for <br>
         private static readonly Regex SyntaxRemoveBr = new Regex(@"(?<!^[!\|].*)(<br[\s/]*> *){2,}", RegexOptions.IgnoreCase | RegexOptions.Multiline | RegexOptions.Compiled);
 
-        //private static readonly Regex InOpenBrackets = new Regex(@"\[\[[^\]]{,100}", RegexOptions.RightToLeft | RegexOptions.Compiled);
+        private static readonly Regex MultipleHttpInLink = new Regex(@"([\s\[>=])((?:ht|f)tp:?/+)(\2)+", RegexOptions.IgnoreCase | RegexOptions.Compiled);
 
-        private static readonly Regex MutlipleHttpInLink = new Regex("(http:?/+)+", RegexOptions.IgnoreCase | RegexOptions.Compiled);
         private static readonly Regex PipedExternalLink = new Regex(@"(\[\w+://[^][<>\""\s]*?)\|''", RegexOptions.IgnoreCase | RegexOptions.Compiled);
 
         // Covered by: LinkTests.TestFixSyntax(), incomplete
@@ -528,7 +527,8 @@
             ArticleText = SyntaxRegex2.Replace(ArticleText, "[http://$1]");
             ArticleText = SyntaxRegex3.Replace(ArticleText, "[http://$1]");
 
-            ArticleText = MutlipleHttpInLink.Replace(ArticleText, "http://");
+            ArticleText = MultipleHttpInLink.Replace(ArticleText, "$1$2");
+
             ArticleText = PipedExternalLink.Replace(ArticleText, "$1 ''");
 
             if (!Regex.IsMatch(ArticleText, "\\[\\[[Ii]mage:[^]]*http"))
Breaks some of the other unit tests in that section... Reedy 00:23, 11 January 2009 (UTC)
With that patch it won't compile as I've misspelled MutlipleHttpInLink beginning with 'MUT...' and you've copied that. Once that's corrected it all works. Doh! Rjwilmsi 09:09, 11 January 2009 (UTC)
I corrected the spelling as it was bad, and thats how i knew the test failed... Do you really think i'd be saying the above if i couldnt compile it? ;P Reedy 12:17, 11 January 2009 (UTC)
Ah, you have to compile to run updated unit tests! Okay, the 3 failing tests due to the change above need to be enclosed with square brackets as the new regex looks for something before the http... (that's three tests). Then the new tests from above fail as you seem to have pasted the before and after in the wrong way round e.g.
Assert.AreEqual("<ref>http//www.site.com</ref>", parser.FixSyntax(@"<ref>http://www.site.com</ref>"));
where FixSyntax is being given the 'after' string. Rjwilmsi 09:16, 11 January 2009 (UTC)
Seems i have for some of them. Switched them over, and commited in rev 3674. Its still failing on line 238 (your first should change) though Reedy 12:17, 11 January 2009 (UTC)
            Assert.AreEqual("http://www.site.com", parser.FixSyntax(@"http/www.site.com"));

^ suppose we should have a test case for both... Reedy 12:52, 11 January 2009 (UTC)

Apologies, I'm not expert SVN and unit tests etc. so got myself a bit confused, wasn't accusing you of stupidity ;). I'll have a look at the remaining failing test(s) when back home this evening. Rjwilmsi 15:41, 11 January 2009 (UTC)
Okay, it was failing because there was no logic to catch the formatting errors the tests were for. This patch adds two more regexes from my custom module to cover that. Now all the TestFixSyntax tests pass. Thanks Rjwilmsi 23:46, 11 January 2009 (UTC)
Looks good to me. Thankyou! Should we cater for
            Assert.AreEqual("http://www.site.com", parser.FixSyntax(@"http/www.site.com"));
 ? I've added it in rev 3680 (with your patch above), commented out, it currently fails... I suspect to give a full covering, we should be dealing with a missing : and a single /? Considering we're catering for each seperately... Would you mind obliging? =)
Also, i think we might need to look at another way to apply your patches (as i've had to do them manually as tortoise svn doesn't like them when copied into notepad++), especially if you're going to be giving more patches... Thanks again! Reedy 23:54, 11 January 2009 (UTC)
Just add a '?' after the second '/' in MissingColonInHttpLink and update the unit test to have square brackets or start with 'url=' or have ref tags. All works for me. If patches are problematic then maybe grant me SVN commit access (my sf.net account is the same userid) and I'll promise to be careful and provide tests for any regex change ;). Rjwilmsi 08:09, 12 January 2009 (UTC)
Perfect! rev 3682 Reedy 12:54, 12 January 2009 (UTC)

NullReferenceException in UsernamePassword2.get_Password()

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at WikiFunctions.Logging.Uploader.UsernamePassword2.get_Password()
   at WikiFunctions.Logging.Uploader.UsernamePassword.get_IsSet()
   at WikiFunctions.Logging.Uploader.LogUploader.LogIn(UsernamePassword LoginDetails)
   at WikiFunctions.Logging.TraceManager.UploadHandler(TraceListenerUploadableBase Sender, String LogTitle, String LogDetails, String UploadToWithoutPageNumber, List`1 LinksToLog, Boolean OpenInBrowser, Boolean AddToWatchlist, String Username, String LogHeader, String EditSummary, String LogSummaryEditSummary, IAutoWikiBrowser AWB, UsernamePassword LoginDetails)

75.27.132.127 (talk) 01:24, 3 June 2008 (UTC)

To duplicate: [encountered while processing page [15]]
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException in WebControl.Save()

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at WikiFunctions.Browser.WebControl.Save() in C:\Documents and Settings\RJW\Desktop\AWB_SVN\AWB\WikiFunctions\WebControl.cs:line 630
   at AutoWikiBrowser.MainForm.SaveArticle() in C:\Documents and Settings\RJW\Desktop\AWB_SVN\AWB\AWB\Main.cs:line 1360

-- TinuCherian (Wanna Talk?) - 13:02, 3 June 2008 (UTC)

To duplicate: [encountered while processing page [16]]
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Line 630 of webcontrol is `Status = "Saving";`

Quite weird.. Reedy 22:55, 5 October 2008 (UTC)

Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException in MainForm.SetCheckBoxes()

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at AutoWikiBrowser.MainForm.SetCheckBoxes()
   at AutoWikiBrowser.MainForm.SaveArticle()

Samaten (talk) 14:17, 22 May 2008 (UTC) A4 (talk) 07:58, 3 June 2008 (UTC) Magioladitis (talk) 16:46, 25 November 2008 (UTC) -- Tinu Cherian - 06:11, 14 December 2008 (UTC) — KlaudiuMihăilă Message 21:06, 2 January 2009 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3 and XP SP2
.NET FW Version Unknown
AWB version 4.3.2.0 and 4.4.1.1, revision 3503 (2008-11-07 21:00:40)
Workaround None
Fixed in version Unknown


Got this myself whilst pressing stop/start... Reedy 07:23, 23 May 2008 (UTC)

My bot was working using Kingbotk plugin to add tags when I received a message for an edit conflict and that AWB will re-apply after I received the message above. I am using XP SP 2 instead of what is written above. -- Magioladitis (talk) 16:51, 25 November 2008 (UTC

Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at AutoWikiBrowser.MainForm.LoadSuccess()

Putnik (talk) 08:19, 23 August 2008 (UTC)

To duplicate: [encountered while processing page [17]]
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.3.2.0
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException in WebControl.SetArticleText

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at WikiFunctions.Browser.WebControl.SetArticleText(String ArticleText)
   at AutoWikiBrowser.MainForm.SaveArticle()

It happened as I was trying to make this edit, if that's any help. The second time I tried it worked without any problems. --Conti

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException in MainForm.SetProject

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at AutoWikiBrowser.MainForm.SetProject(LangCodeEnum code, ProjectEnum project, String customProject)
   at AutoWikiBrowser.MainForm.LoadPrefs(UserPrefs p)
   at AutoWikiBrowser.MainForm.LoadPrefs(String path)

Dillard421 (talkcontribs) 22:58, 5 November 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

NullReferenceException in WebControl.ShowPreview

Status Works for me
Description
Exception:NullReferenceException
Message:Object reference not set to an instance of an object.
Call stack:
   at WikiFunctions.Browser.WebControl.ShowPreview()
   at AutoWikiBrowser.MainForm.GetPreview()
   at AutoWikiBrowser.MainForm.btnPreview_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

TJ Spyke 04:35, 3 December 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

ArgumentOutOfRangeException in ListViewItemComparer.Compare

Status Works for me
Description
Exception:ArgumentOutOfRangeException
Message:InvalidArgument=Value of '3' is not valid for 'index'. Parameter name: index
Call stack:
   at System.Windows.Forms.ListViewItem.ListViewSubItemCollection.get_Item(Int32 index)
   at WikiFunctions.Controls.NoFlickerExtendedListView.ListViewItemComparer.Compare(Object x, Object y)
   at System.Windows.Forms.ListView.CompareFunc(IntPtr lparam1, IntPtr lparam2, IntPtr lparamSort)
   at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at System.Windows.Forms.NativeWindow.DefWndProc(Message& m)
   at System.Windows.Forms.Control.DefWndProc(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ListView.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Rockfang (talk) 17:33, 11 October 2008 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 5.1.2600 Service Pack 3
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28)
Workaround None
Fixed in version Unknown


How did you encounter this? MaxSem(Han shot first!) 18:18, 11 October 2008 (UTC)

I was doing general typo/clean up fixes from a saved text file of articles.--Rockfang (talk) 18:46, 11 October 2008 (UTC)
Archiving due to rare bug, no chance of fixing without more info. Rare and few reports. Reedy 19:37, 12 January 2009 (UTC)

AWB inexplicably blanking page

Status Works for me
Description For some reason, AWB, set up to deliver the Signpost in bot mode, blanked a user's talk page. It should have just added a new section -- instead, it made two edits -- the first blanking the page, and the second adding the new section. Ral315 (talk) 04:25, 9 May 2008 (UTC)
To duplicate: No idea
Operating system Vista
.NET FW Version Unknown
AWB version 4.3.0.2
Workaround N/A
Fixed in version Unknown


I understand this is an old version of AWB, but it's such an odd bug, it may still be in the new release. May be worth looking into, if it can be duplicated. Ral315 (talk) 04:29, 9 May 2008 (UTC)
As it stands Ral, we havent seen anything like this, so i think in this case, at least, it will still be there in the new version. As for what actually casued it... Reedy 09:16, 9 May 2008 (UTC)

I have met this bug few times too (example1, example2, example3, example4, example5). I always use the same rule to replace text, and there were some false saving between thousands good one. I used the latest Win XP and AWB (4.3.1.0). I think it happenes during loading a page before the program examine the rule on it. Samaten (talk) 20:08, 9 May 2008 (UTC)

Thanks for the comment. It would seem its definately not a random one off bug then. Reedy 20:19, 9 May 2008 (UTC)
In theory, bug could be sort of "fixed" by checking if edited page is blank just before saving it. TestPilot 14:56, 11 May 2008 (UTC)
That check is there since 1.0, I guess, so the problem must be somewhere later. MaxSem(Han shot first!) 15:12, 11 May 2008 (UTC)
Yeah.. Havent we had this before with some MW glitches and we've had blank saves? Reedy 18:13, 11 May 2008 (UTC)

This happened again: [18]. I use AWB 4.3.2.0 and XP SP3. AWB didn't wait before saving and put the article into skipped group with the skip reason "Non-existent page". Samaten (talk) 15:38, 22 May 2008 (UTC)

Archiving due to rare bug, no chance of fixing without more info. Rare and no recent reports. Reedy 19:39, 12 January 2009 (UTC)

Bug in regex to correct double bracketed external links

Status Not enough information/very rare bug
Description See this diff: AWB replaced a double bracketed external link within an image description by removing one bracket only. I've tracked the problem down to the SyntaxRegex* entries in Parsers.cs. Thanks Rjwilmsi 18:54, 7 October 2008 (UTC)
To duplicate:
Operating system XP
.NET FW Version Unknown
AWB version SVN
Workaround
Fixed in version Unknown


I've also noticed an additional limitation of the existing regexes as incorrect external links like now [[http://www.site.com a [[c]] site] was won't be fixed. I will try to come up with a better set of regexes, with unit tests. Rjwilmsi 20:18, 7 October 2008 (UTC)
Tests at bottom of User:Rjwilmsi/Test. With these four below more errors are caught than AWB and the bug I've found is avoided (I can't find any bugs). Rjwilmsi 21:37, 7 October 2008 (UTC)
     // remove extra square brackets around external links
     ArticleText = Regex.Replace(ArticleText, @"\[\[?\s*(http://[^\]\[]*?(?:[^\]\[]*?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?)*)\]\]([^\]\[])", "[$1]$2", RegexOptions.IgnoreCase);
     ArticleText = Regex.Replace(ArticleText, @"\[\[\s*(http://[^\]\[]*?(?:[^\]\[]*?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?)*)\]\]?([^\]\[])", "[$1]$2", RegexOptions.IgnoreCase);
            
     // remove extra square brackets around external links, where external link is within image description (will need to not hide images for these to work)
     ArticleText = Regex.Replace(ArticleText, @"(\[\[.*?)\[\s*(http://[^\]\[]*?(?:[^\]\[]*?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?)*)\]\]([^\]\[]*?\]\])", "$1[$2]$3", RegexOptions.IgnoreCase);
     ArticleText = Regex.Replace(ArticleText, @"(\[\[.*?)\[\[\s*(http://[^\]\[]*?(?:[^\]\[]*?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?)*)\]\]?([^\]\[]*?\]\])", "$1[$2]$3", RegexOptions.IgnoreCase);
Just made some minor tweaks, replacing the setting case insensitive to doing it as a regex option. Suspect it might be better for Max to review all these Reedy 23:11, 7 October 2008 (UTC)
Also, how are those tests formatted? As i can add them to the NUnit project for AWB to bring the tests onboard. Are there just a couple of extra ones on it? Reedy 23:19, 7 October 2008 (UTC)
Don't understand what you mean by 'just a couple of extra ones on it?' but I can format the tests for you if you can provide me an example of match and no match tests. I assume that within reason it's the more tests the merrier? Rjwilmsi 23:25, 7 October 2008 (UTC)
Oh, duh. Its "additional"... Reedy 23:29, 7 October 2008 (UTC)
In fact, if you tell me the format of the tests and where they go in the SVN I'll have a go at creating a patch for you. I was a C developer for a year so ought to be capable! Rjwilmsi 23:34, 7 October 2008 (UTC)
Cool. You can use "Nunit" to help running the tests internally. And for the thing above, i was getting confused between this and your other bug. The UnitTests project contains all the tests that have been setup, and if done in the same format, can be run easily externally by NUnit. If you look in GenfixesTests.cs, you'll see general fix tests, and the external link tests. If you run the whole project in nunit, you can see the failing tests! Reedy 23:43, 7 October 2008 (UTC)

(<--)Okay, downloaded Nunit...patch is at User:Rjwilmsi/Test2 which includes extra unit tests, amendments for ParserTest.cs (now that need to match on character not equal to square bracket at end of external link) and changes to Parsers.cs so that the relevant tests now pass. Don't know if you just wanted the extra unit tests, I guess you can just take the patch for the unit tests file if that's the case. Be gentle if I've got something wrong ;) Thanks Rjwilmsi 01:01, 8 October 2008 (UTC)

I just want to note the MediaWiki external link regex (?P<protocol>http|https|ftp|gopher)://[^\[\]<>"\s] with []<>" \n breaking the link. It more complicated with free link as trailing puncutation character are ignored and ) is ignore if the link doesn't contain (. — Dispenser 05:12, 8 October 2008 (UTC)
Yes, I believe that's what's used for hiding external links in HideText(). In this case though we need to match on more than just the link itself as we need to match on the URL and any description e.g. [http://www.site.com a cool site]. Thanks Rjwilmsi 06:42, 8 October 2008 (UTC)
Yes, but you aren't account for \n, since the regex for the title part is [^\]\n]*. — Dispenser 13:35, 8 October 2008 (UTC)
rev 3437, i have added in your extra/updated tests, they look right, so are fine to be in the SVN. Will look at reviewing the other bit soon =). Thanks! Reedy 09:51, 8 October 2008 (UTC)
rev 3492, moved test positions Reedy 22:51, 27 October 2008 (UTC)
Thanks. These improved fixes have actually highlighted another common error where an external link between ref tags has a missing square bracket (most commonly missing at the end e.g. <ref>[http://www.site.net interesting link</ref>). I'll provide a patch with unit tests for this too & a suggested fix. Rjwilmsi 12:40, 9 October 2008 (UTC)
Here goes:
// complete square brackets around external links in ref tags
ArticleText = Regex.Replace(ArticleText, @"(<ref.*?>[^\[\]<>]*?\[\s*http://[^\[\]<>]*?)(</ref>)", "$1]$2", RegexOptions.IgnoreCase);
ArticleText = Regex.Replace(ArticleText, @"(<ref.*?>)(\s*http://[^\[\]<>]*?\][^\[\]<>]*?</ref>)", "$1[$2", RegexOptions.IgnoreCase);

// remove extra square brackets around external links
ArticleText = Regex.Replace(ArticleText, @"\[\[?\s*(http://[^\]\[]{0,100}?(?:[^\]\[]{0,100}?(?:\[\[[^\]\[]{0,100}?\]\][^\]\[]{0,100}?)[^\]\[]{0,100}?){0,2})\]\]([^\]\[])", "[$1]$2", RegexOptions.IgnoreCase);
ArticleText = Regex.Replace(ArticleText, @"\[\[\s*(http://[^\]\[]{0,100}?(?:[^\]\[]{0,100}?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?){0,2})\]\]?([^\]\[])", "[$1]$2", RegexOptions.IgnoreCase);

// ... where external link is within image description (do not 'hide images' for these to work)
ArticleText = Regex.Replace(ArticleText, @"(\[\[.*?)\[\s*(http://[^\]\[]{0,100}?(?:[^\]\[]{0,100}?(?:\[\[[^\]\[]{0,100}?\]\][^\]\[]{0,100}?)[^\]\[]{0,100}?)?)\]\]([^\]\[]{0,100}?\]\])", "$1[$2]$3", RegexOptions.IgnoreCase);
ArticleText = Regex.Replace(ArticleText, @"(\[\[.*?)\[\[\s*(http://[^\]\[]{0,100}?(?:[^\]\[]{0,100}?(?:\[\[[^\]\[]*?\]\][^\]\[]*?)[^\]\[]*?){0,2})\]\]?([^\]\[]*?\]\])", "$1[$2]$3", RegexOptions.IgnoreCase);
##############################################################################################################
// rev 3437 unit tests still valid

// complete square brackets around external links in ref tags
AssertChange(@"<ref>[http://www.site.com interesting link</ref>", @"<ref>[http://www.site.com interesting link]</ref>");
AssertChange(@"<ref name=""abc""> [ http://www.site.com interesting link</ref>", @"<ref name=""abc""> [ http://www.site.com interesting link]</ref>");
AssertChange(@"<ref name=abc> [ http://www.site.com interesting link</ref>", @"<ref name=abc> [ http://www.site.com interesting link]</ref>");
AssertChange(@"<ref>http://www.site.com interesting link]</ref>", @"<ref>[http://www.site.com interesting link]</ref>");
AssertChange(@"<ref name=""abc"">http://www.site.com interesting link]</ref>", @"<ref name=""abc"">[http://www.site.com interesting link]</ref>");
AssertChange(@"<ref>The Times, [http://www.site.com interesting link</ref>", @"<ref>The Times, [http://www.site.com interesting link]</ref>");
AssertChange(@"<ref name=""abc"">http://www.site.com interesting link] ab</ref>", @"<ref name=""abc"">[http://www.site.com interesting link] ab</ref>"):

AssertNotChanged(@"<ref>http://www.site.com interesting link</ref>");
AssertNotChanged(@"<ref>[http://www.site.com interesting link]</ref>");
AssertNotChanged(@"<ref>[http://www.site.com interesting link] here</ref>");
AssertNotChanged(@"the [http://www.site.com interesting link was");
AssertNotChanged(@"the http://www.site.com interesting link] was");
AssertNotChanged(@"the http://www.site.com interesting link]</ref> was");
AssertNotChanged(@"the <ref>http://www.site.com interesting link] was");
AssertNotChanged(@"the <ref>http://www.site.com <interesting> link] was");
AssertNotChanged(@"the <ref>[http://www.site.com interesting link] retrieved 2008-10-10</ref>");
AssertNotChanged(@"the  <ref>The Times, [http://www.site.com interesting link]</ref>");
##############################################################################################################
Two new fixes are useful and the version 1 fixes needed a fix to limit execution time. I've tested it all successfully locally. The unit tests added in rev 3437 are still valid and all pass too. Rjwilmsi 23:13, 9 October 2008 (UTC)

This isn't exactly safe since MW ignores punctuation at the end of a link and does weird things with parentheses the following code indicates some of the edge cases:

# bracket <ref>http://</ref>
text = re.sub(r'(<ref[^</>]*> *)(http|https|ftp)://([^\[\]<>\'"\(\)\s]+[^\.,\\:;\?!\[\]<>"\s\(\)\'])( *</ref>)', r'\1[\2://\3]\4', text)

Dispenser 17:49, 10 October 2008 (UTC)


Due to the above, it cant be easily fixed (atm, at least), so closing the bug as wontfix, and archiving, but leaving the unit tests in AWB for it to be reviewed later Reedy 20:12, 12 January 2009 (UTC)

InvalidCastException in ListFilterForm.get_Settings

Status Yes check.svg Fixed in the next release
Description
Exception:InvalidCastException
Message:Unable to cast object of type 'WikiFunctions.Article' to type 'System.String'.
Call stack:
   at WikiFunctions.Lists.ListFilterForm.get_Settings()
   at WikiFunctions.Controls.Lists.ListMaker.get_SpecialFilterSettings()
   at AutoWikiBrowser.MainForm.MakePrefs()
   at AutoWikiBrowser.MainForm.SavePrefs(String path)

Canis Lupus 20:59, 22 November 2008 (UTC) Magog the Ogre (talk) 07:46, 3 January 2009 (UTC)

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6001 Service Pack 1 for both
.NET FW Version Unknown
AWB version 4.4.1.0, revision 3429 (2008-10-05 12:20:28) for Canis; 4.4.2.0, revision 3552 (2008-12-13 22:16:46) for Magog
Workaround None
Fixed in version Unknown


Occurs when I try to "save settings" on my system. Has occurred both times I tried to do it; I haven't tried again because I don't want the error. Magog the Ogre (talk) 07:27, 5 January 2009 (UTC)

Fixed by Max, rev 3817 Reedy 18:31, 23 January 2009 (UTC)

Bold letters

Status Yes check.svg Fixed in the next release
Description Check here. AWB was supposed to convert the first two words in brackets into bold. For some reason, it didn't work. Magioladitis 03:31, 4 November 2007 (UTC)

[19] --84.234.42.68 (talk) 11:59, 25 May 2008 (UTC)

Check [20]. After the template, there was a [[Phyllis Pearce]] in the article called Phyllis Pearce. As far as I remember this was corrected automatically to bold. Magioladitis (talk) 13:52, 26 September 2008 (UTC)

Often AWB fails to embolden the title. Rich Farmbrough, 18:04 2 October 2008 (UTC). 18:04, 2 October 2008 (UTC)

To duplicate: Example Gen fixes on Rush University College of Health Sciences
Operating system Windows XP Service pack 2
.NET FW Version Unknown
AWB version 4.1.4.0
Workaround None
Fixed in version Unknown


Presumably cause its linking back to itself.. Probably doesnt cater for these cases, and therefore didnt embolden. Reedy Boy 13:08, 4 November 2007 (UTC)
In other cases (here one but without the brackets and here one with the brackets!), I've seen AWB fixing it. It's a common mistake people to put [[]] instead of bold letters and AWB was working fine with that. -- Magioladitis 14:59, 4 November 2007 (UTC)
Hmm.. Whatever way, it needs sorting. Reedy Boy 15:03, 4 November 2007 (UTC)
It doesn't work when there is no other bolded text in the article because it's incorrectly marked as "NoChange" in BoldTitle(). I'm working on it. I wish Wikibluemoose made more comments in the source code :( Jogers (talk) 19:26, 8 November 2007 (UTC)
Just to report a normal case that didn't change to bold here. -- Magioladitis 02:34, 9 November 2007 (UTC)


            string escTitle = Regex.Escape(ArticleTitle).Replace(@"\ ", "[ _]");

            //remove self links first
            Regex tregex = new Regex("\\[\\[(" + Tools.CaseInsensitive(escTitle) + ")\\]\\]");
            if (!ArticleText.Contains("'''"))
            {
                ArticleText = tregex.Replace(ArticleText, "'''$1'''", 1);
            }
            else
            {
                ArticleText = ArticleText.Replace("[[" + ArticleTitle + "]]", ArticleTitle);
                ArticleText = ArticleText.Replace("[[" + Tools.TurnFirstToLower(ArticleTitle) + "]]", Tools.TurnFirstToLower(ArticleTitle));
            }

            if (Regex.IsMatch(ArticleText, "^(\\[\\[|\\*|:)") || Regex.IsMatch(ArticleText, "''' ?" + escTitle + " ?'''", RegexOptions.IgnoreCase))
            {
                NoChange = true;
                return ArticleText;
            }

The relevant code is above. It seems that as your article contained another item in bold, the wikilink of the title would be delinked rather than set bold. Not sure why that didn't happen for you though. Rjwilmsi 19:11, 14 October 2008 (UTC)

Well, in your example i see the word "the" in the beginning. -- Magioladitis (talk) 22:04, 2 October 2008 (UTC)

It should embolden the first occurrence , I would say unless that occurs after the first bolded text in the article. Obviously this would be after removing self-links. Rich Farmbrough, 18:21 22 October 2008 (UTC).


Think we need to create a set of Unit test cases for this, what should, shouldn't work, and look at trying to fix it. Reedy 20:24, 12 January 2009 (UTC)

rev 3740 Rewrite the BoldTitle method, logic is now as follows: if article already has the title bolded in the main body, make no changes. If title is linked but not bold, delink and make bold. As before, handle first dropping brackets from article name, then article name. As before, don't make changes on articles where name is day + date. I'll now check on all the examples given above. Rjwilmsi 23:28, 16 January 2009 (UTC)

at UnitTests.GenfixesTests.UndersoreRemovalInExternalLink() in D:\Programming\SVN\AWB\AWB\UnitTests\GenfixesTests.cs:line 67

Is a now failing unit test. FYI. Reedy 23:33, 16 January 2009 (UTC)

rev 3741 Add tests from bug reports above. Rjwilmsi 23:43, 16 January 2009 (UTC)

rev 3742 Amend UndersoreRemovalInExternalLink due to coincidental failure. Rjwilmsi 23:48, 16 January 2009 (UTC)

find & replace applied to images when ignore images set

Status Yes check.svg Fixed in the next release
Description When find & replace is used with 'Ignore links, images...' set, find & replace is still applied to the filename of an image. Thanks Rjwilmsi (talk) 21:55, 20 May 2008 (UTC)
To duplicate: Parse article Arlberg with find='sss' replace='ss' and ignore images set, an image is incorrectly renamed.
Operating system XP
.NET FW Version Unknown
AWB version SVN
Workaround
Fixed in version Unknown


  • well, I discovered the same thing but AWB just ignores everything into [[Image:...]] and can't be sure that this thing in the template is an image link, of course would be great to ignore these things too but I'm not sure if there is an easy way, for example the images in templates can be discovered by something like "= *[^\n]*\.(\.jpg|\.gif|\.png)" - or something, not tested --84.234.42.68 (talk) 11:46, 21 May 2008 (UTC)
    • Reviewing this it seems we need to allow (?si)\|\s*photo\s*=.+?(?:\||}}) as another option for masking images. Rjwilmsi 22:46, 5 October 2008 (UTC)

rev 3689 - if all went well I've fixed it. Rjwilmsi 21:33, 12 January 2009 (UTC)

Looks good to me. Reedy 22:52, 12 January 2009 (UTC)

AWB didn't fix special characters in a pipe

Check here. AWB normally checks defaultsort and pipes in categories and replaces special characters with normal. It's didn't work in this case. -- Magioladitis (talk) 14:21, 13 September 2008 (UTC)

The problem is that it doesn't remove the diacritics if it can't add DEFAULTSORT. Will think later about moving the diacritics removal to another place. MaxSem(Han shot first!) 15:16, 13 September 2008 (UTC)
Yes check.svg rev 3752 diacritics are now always removed from category sortkeys even if defaultsort isn't changed. Rjwilmsi 15:21, 17 January 2009 (UTC)


Site typo error zh_yue

Status Yes check.svg Fixed in the next release
Description From menu Options > Preferences... > Site. When Project is wikipedia, zh_yue is misspelled as zh_syueHenryLi (Talk) 11:08, 15 January 2009 (UTC)
To duplicate: always
Operating system any
.NET FW Version Unknown
AWB version 4.4.2.0
Workaround
Fixed in version Unknown


I fixed this a while ago when doing some language updates. Please use a SVN snapshot if you require this wiki Reedy 11:24, 15 January 2009 (UTC)

AWB reports: "there was a problem loading the page"

Status Yes check.svg Fixed in the next release
Description AWB reports: "there was a problem loading the page" with svn3712. That doesn't happen with svn3672. I don't know what extra information I can provide. Lightmouse (talk) 12:10, 15 January 2009 (UTC)
To duplicate:
Operating system
.NET FW Version Unknown
AWB version SVN3712
Workaround
Fixed in version Unknown


It worked for me yesterday evening. What page(s) do you get the error on, or is it all pages and what do you see in the IE window (any mediawiki error messages etc.)? Rjwilmsi 12:21, 15 January 2009 (UTC)

The error is on all pages. I get no other messages. At first I thought it was a problem with Wikipedia but that didn't fit the facts. I downgraded to svn3672 and the problem went away. The edit window looks like it has loaded the page and put it in edit mode. Lightmouse (talk) 12:28, 15 January 2009 (UTC)

I'm getting this too. I was doing a TypoScan run and I thought it just wasn't finding any typos, but when I looked at the log is said that every page had a problem loading. Oh yeah, the TypoScan stats page shows what happened: http://toolserver.org/~maxsem/typoscan/ in the "Skipped per reason" table. --Closedmouth (talk) 12:41, 15 January 2009 (UTC)

Try downgrading to svn3672 and see if that works for you, as it did for me. Lightmouse (talk) 12:39, 15 January 2009 (UTC)

Gonna try that. --Closedmouth (talk) 12:41, 15 January 2009 (UTC)

Yeah, that works. --Closedmouth (talk) 12:45, 15 January 2009 (UTC)

I had caused a minor regression with an overzealous Refactor. It had renamed text rather than just variables rev 3717. Will put another SVN snapshot up Reedy 13:13, 15 January 2009 (UTC)
Thank you Reedy :) --Closedmouth (talk) 13:19, 15 January 2009 (UTC)

Disc full

Status Yes check.svg Fixed in the next release
Description
Exception:IOException
Message:There is not enough space on the disk.
Call stack:
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.WriteCore(Byte[] buffer, Int32 offset, Int32 count)
   at System.IO.FileStream.FlushWrite(Boolean calledFromFinalizer)
   at System.IO.FileStream.Dispose(Boolean disposing)
   at System.IO.Stream.Close()
   at System.IO.StreamWriter.Dispose(Boolean disposing)
   at System.IO.TextWriter.Dispose()
   at Microsoft.CSharp.CSharpCodeGenerator.FromSourceBatch(CompilerParameters options, String[] sources)
   at Microsoft.CSharp.CSharpCodeGenerator.System.CodeDom.Compiler.ICodeCompiler.CompileAssemblyFromSourceBatch(CompilerParameters options, String[] sources)
   at System.CodeDom.Compiler.CodeDomProvider.CompileAssemblyFromSource(CompilerParameters options, String[] sources)
   at System.Xml.Serialization.Compiler.Compile(Assembly parent, String ns, CompilerParameters parameters, Evidence evidence)
   at System.Xml.Serialization.TempAssembly.GenerateAssembly(XmlMapping[] xmlMappings, Type[] types, String defaultNamespace, Evidence evidence, CompilerParameters parameters, Assembly assembly, Hashtable assemblies)
   at System.Xml.Serialization.TempAssembly..ctor(XmlMapping[] xmlMappings, Type[] types, String defaultNamespace, String location, Evidence evidence)
   at System.Xml.Serialization.XmlSerializer.GenerateTempAssembly(XmlMapping xmlMapping, Type type, String defaultNamespace, String location, Evidence evidence)
   at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, String defaultNamespace, String location, Evidence evidence)
   at System.Xml.Serialization.XmlSerializer..ctor(Type type, Type[] extraTypes)
   at WikiFunctions.AWBSettings.UserPrefs.SavePrefs(UserPrefs prefs, String file)

When saving to a "full" disc, AWB seems to mess up the existing version of its configs. Subsequently attempting to save configs to a seperate drive also fails with the above exception. Rich Farmbrough, 10:56 18 January 2009 (UTC).

To duplicate: Unknown
Operating system Microsoft Windows NT 6.0.6000.0
.NET FW Version Unknown
AWB version 4.4.2.0, revision 3552 (2008-12-13 22:16:46)
Workaround None
Fixed in version 4.5.0.0


rev 3800 Added specific message box for this particular error; make sure the attempt to restore old settings after failure to save current settings doesn't happen after this error. Rjwilmsi 08:14, 19 January 2009 (UTC)

ArgumentException in Plugin.LoadPlugins

Status Yes check.svg Fixed in the next release
Description
Exception:ArgumentException
Message:An item with the same key has already been added.
Call stack:
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at AutoWikiBrowser.Plugins.Plugin.LoadPlugins(IAutoWikiBrowser awb, String[] Plugins, Boolean afterStartup)

Magioladitis (talk) 14:19, 19 January 2009 (UTC)

To duplicate: Load a plugin and then try to load it again.
Operating system Microsoft Windows NT 5.1.2600 Service Pack 2
.NET FW Version Unknown
AWB version 4.4.2.0, revision 3552 (2008-12-13 22:16:46)
Workaround None
Fixed in version


I think a message like "This plugin is already loaded" is better than the bug box or not? -- Magioladitis (talk) 14:19, 19 January 2009 (UTC)

I'd certainly suspect so. FYI, you've got duplicate of the same plugin in your AWB dir (if you didn't know). Remove the older to fix it Reedy 14:50, 19 January 2009 (UTC)
I produced the bug myself. In fact I have only only dll in the AWB. It is loaded automatically in AWB and then I pressed Plugins->Load and I selected an already loaded plugin. This caused the bug. -- Magioladitis (talk) 14:54, 19 January 2009 (UTC)
rev 3801, thanks Reedy 14:59, 19 January 2009 (UTC)