Wikipedia talk:Tools/Navigation popups

From Wikipedia, the free encyclopedia
Jump to navigation Jump to search

This page is for discussing Navigation popups and reporting bugs you encounter with it. Please be aware that the original author of Popups (Lupin) is no longer active on Wikipedia. All issues are handled at the discretion of other experienced editors. Note that this project has an associated Phabricator project where implementation-related discussion happens.

Not sure how to explain your problem clearly? Read How to Report Bugs Effectively for some general pointers.

Some common questions are answered in the FAQ.


Conflict with syntax highlighting[edit]

Fixing redirects does not work if syntax highlight is active Button CodeMirror active.svg.--Anatoliy (Talk) 17:03, 29 June 2018 (UTC)

  • Anatoliy: what exactly does not work? It works for me. Alexei Kopylov (talk) 23:44, 29 June 2018 (UTC)
    When I try to fix redirect, it does not fix if the syntax highlight is active. If deactivate it, fixing redirect works.--Anatoliy (Talk) 08:21, 30 June 2018 (UTC)
    Navpopups uses a really outdated way to modify the text area, that is indeed not compatible with this mode. —TheDJ (talkcontribs) 14:37, 30 June 2018 (UTC)

Hidden names leaked[edit]

Hi, when scanning meta:Steward requests/Global I noticed something peculiar: a hidden user name that contained a religious slur was hidden, but the popups revealed it anyway on hover. I left a notice at meta:talk:Steward requests/Global#Name hidden? Not. Btw, I am using W10 and Firefox. I am not sure if this issue is best discussed on meta or here. You may choose one page and leave a link on the other. Regards – Bertux (talk) 19:38, 15 July 2018 (UTC)

I replied at meta. The name isn't supposed to be secret so there is no leak. PrimeHunter (talk) 20:27, 15 July 2018 (UTC)
For the record: The meta's template just makes them invisible when rendered in the template but keeps it visible when editing - it has no security function. If people need confidentiality, they are instructed to email us. — regards, Revi 16:26, 28 August 2018 (UTC)

Enable for all links EXCEPT for article links[edit]

Is it possible to enable this script for all links EXCEPT for article links? I am using the Wikipedia addon for article links, but I still want this script for all other links. I've already disabled this script in the article namespace for the view action, but there are still article links in non-article pages. Gary (talk · scripts) 14:00, 17 July 2018 (UTC)

Oddity in how italicized links are displayed[edit]

Looking at today's "In The News" which mentions article The Stone Sky, when using navigation popups to display a preview of that link I noticed something strikingly odd. The text in the article has a portion:

..., following [[The Fifth Season (novel)|''The Fifth Season'']] and ''[[The Obelisk Gate]]'', ...

which when displayed in the popup appears as

..., following <em>The Fifth Season</em> and The Obelisk Gate, ...

It seems the simple link surrounded by single quotes is correctly italicized. The link which has the single quotes embedded within the piped wikitext instead resolves the italic quotes to <em> !

I wonder how long this has been true? (I haven't tried changing the article to test this...) Shenme (talk) 03:36, 26 August 2018 (UTC)

The parser used by Popups is quite old and doesn't handle edge cases (like this one) gracefully. I've been intending to switch it to, say, use the actual page HTML, but that'll take quite a bit of work. Enterprisey (talk!) 14:19, 29 August 2018 (UTC)

API deprecation notice shown when hovering on CSS pages[edit]

I.e. User:-revi/up.css:

{"batchcomplete":true,"warnings":{"main":{"warnings":"Subscribe to the mediawiki-api-announce mailing list at for notice of API deprecations and breaking changes. Use Special:ApiFeatureUsage to see usage of deprecated features by your application."},"revisions":{"warnings":"Because \"rvslots\" was not specified, a legacy format has been used for the output.

Sorry for reporting dups if this was fixed: my global.js is fixed to the specific version of the script, for the good reason. Though, Special:Diff/841713951 and Special:Diff/825269631 (the version I'm currently using) seems to be the latest. — regards, Revi 16:29, 28 August 2018 (UTC)

This happens on massmessage-list contentmodel and on wikidata content models, so I guess API is not happy with the query we're using now. — regards, Revi 09:51, 29 August 2018 (UTC)
It appears for all content models (using upstream code as well), except for wikitext, where it’s hidden, because wikitext is processed, while other content models’ returned JSON is directly output. (The server returns the warning for wikitext too, it can be observed using the browser console.) It’s probably OK to rewrite the code to use the main slot always, I don’t think we should care about any other eventual slots (page revision parts). Folks checking the logs will be happy for sure if this gadget won’t produce warning for every preview—I’m sure there are several, maybe even hundreds or thousands of hits every second. —Tacsipacsi (talk) 19:25, 29 August 2018 (UTC)
This is still happening with latest version and has been reported at itwiki's village pump. I also agree that rvslots should probably be set to 'main', at least for the moment: better to show something from the page than an error. --Daimona Eaytoy (Talk) 14:37, 2 November 2018 (UTC)

Avoid to open a new page when Thanks link is clicked[edit]

Currently clicking on the "action > send thanks" link present in the Popup menu opens a new page where the user have to confirm. It's possible elsewhere in the legacy mediawiki interface to avoid this page loading redundancy using this api request action=thank; format=json; source=history; rev=857131462; token=xxxxx+\, is it possible to implement a confirmation in Popup when "Send thanks" is clicked, and directly send the above request without loading another page ? Thanks ! (that the good word) --Framawiki (please notify) (talk) 17:27, 30 August 2018 (UTC)


Retain overlayed popups?[edit]

The graphical metaphor of stacked popups naturally leads to the expectation that as long as one is hovering over one popup, all popups under it will remain on screen. So I was surprised to see the first popup disappear when I went down a third level. Then I realized the retention criterion was that a popup remains on screen only so long as the cursor is over it. Is it too much to hope for a configuration parameter to retain all popups overlayed directly or indirectly by the one the cursor is currently over? Jim Bowery (talk) 22:31, 3 November 2018 (UTC)

Proposed change: Shortmenus style "popups" menu-item into shorter icon[edit]

TLDR: Because it is rarely needed and gets in the way and increases the chance of linewrap, change the current text "popups" into just a star/cog (UTF or image, whatever works), in the "menus" and "shortmenus" style-configurations. See current text screenshots at /Structure_examples#Menus.

Mockup: https://imgur.com/a/pW3n2XF

Thoughts? Quiddity (talk) 08:58, 16 November 2018 (UTC)

Sounds like a good idea to me. Enterprisey (talk!) 01:03, 17 November 2018 (UTC)
Ok. I propose using either ⚙ (unicode for 'gear' since 2005), or just a plain ascii '*' if there are any concerns about the former. IIUC that string is only used in the 'menus' and 'shortmenus' structures (i've updated all the screenshots to confirm), and therefor we just need to change 'popups' to '⚙' in line 6897 of MediaWiki:Gadget-popups.js. Ping TheDJ for sanity-check and implementation. :) Quiddity (talk) 22:45, 24 November 2018 (UTC)
⚙ is nice, but looks weird being underlined. * might be better? Alternatively, you can just turn it off. ~ Amory (utc) 15:46, 15 January 2019 (UTC)
One thing we could do is put a CSS class on just that symbol to skip underlining. That wouldn't kill localization because the symbol won't get localized anyway, so we can actually remove that key ("popups") from the localization object (aka the popup strings thing, it's been a while) - or just stop using that key. Enterprisey (talk!) 06:24, 23 January 2019 (UTC)
Enterprisey, I think that's acceptable. I do worry a bit about using emoji characters for this kind of function though. It's not too long ago we had people at VP/T complaining about showing squares for people with emoji in their name, and the accessibility of it is also meh. —TheDJ (talkcontribs) 15:59, 29 January 2019 (UTC)
Yeah, I think that's a legitimate concern. I'd also be okay with using the standard "settings cog" and then putting it out of the way, like in a corner or something. Popups are currently laid out so tightly that I'm not sure if we'll be able to fit a settings cog in there, though! Enterprisey (talk!) 02:32, 30 January 2019 (UTC)
Those are valid concerns though (re: the emoji), and per Xaosflux my asterisk suggestion fails hard. Maybe "cfg" works as something shorter but still gets the message across? Certainly clearer than "popups" although there's not much in the menu anyway. ~ Amory (utc) 13:01, 30 January 2019 (UTC)

Comma[edit]

Please add a comma as thousand separator in edits number because it's much easier to read for me. Thanks. Hddty. (talk) 02:48, 19 November 2018 (UTC)

Would thin spaces also work? (More international that way.) Enterprisey (talk!) 08:18, 24 December 2018 (UTC)

Thanks[edit]

function does not seem to work. Chrome 71 / Windows 10.0.18298 . Clicking thanks through popup takes me to this link.WBGconverse 06:46, 24 December 2018 (UTC)

If I (also Chrome 71, but Win 7) select "send thanks" from the "actions" menu when hovering on the diff in my watchlist for your edit above, I get https://en.wikipedia.org/w/index.php?title=Special:Thanks/875163135 -- Michael Bednarek (talk) 07:02, 24 December 2018 (UTC)
Y'know, I suspected that some paths in the code may send you to that page, but I didn't have much of an idea about the specifics. I have access to a Windows 10 + Chrome 71 setup, and will test it out soonish. Enterprisey (talk!) 08:17, 24 December 2018 (UTC)

Hint/tooltip glitches[edit]

Good day,

The altering of the action object property in the getPrintFunction function, in these two cases (lines 5679 and 5688):

	case 'unwatch': case 'watch':
		this.print=magicWatchLink; this.action=this.id+'&autowatchlist=1&autoimpl=' + popupString('autoedit_version') + '&actoken='+autoClickToken(); break;
	case 'delete':
		this.print=wikiLink; this.action='delete';
		if (this.article.namespaceId()==pg.nsImageId) {
			var img=this.article.stripNamespace();
			this.action+='&image='+img;

and its use for retreiving the i18n tooltip in the wikiLink function (line 6174):

	var hint=popupString(l.action + 'Hint'); // revertHint etc etc etc

result in tooltips with url code between the action term and 'Hint', like: un|watch for any watch/unwatch, and delete for images (hover to see). I guess the altering of action needs to be moved to the switch statement in the wikiLink function (starting at line 6178).

Another one is email user – the i18n key 'EmailuserHint' (line 7049) needs a capital U.

With kind regards — Mar(c). 12:20, 7 January 2019 (UTC)

Previews from Index and Page namespaces[edit]

Hello!
I've just noticed this gadget and in my opinion is much better of Extension:Popups (that I've used until today). Anyway I am facing an issue concerning pages generated by Extension:ProofreadPage, since they are previewed as you can see in the images. Do you any suggestion about how to obtain better previews?

Thanks for the help,
--Loman87 (talk) 15:16, 21 January 2019 (UTC)

Loman87, it uses a content-model (not plain wiki text) that the gadget doesn't support yet. Therefore it shows the raw json results. Flow pages have the same issue. Fixing that might not be terribly hard, but someone needs to contribute the code. —TheDJ (talkcontribs) 12:37, 29 January 2019 (UTC)
Hi TheDJ and thanks for your answer. Yes, I imagined the issue was related to the content model (many extensions can't work with that). Unfortunately I am not a developer and I wouldn't be able to do such thing. Maybe I can post a pull request on the project page: is there a link? Bye! --Loman87 (talk) 11:12, 31 January 2019 (UTC)

Two desired "user" links as optional adds[edit]

It hasn't been mentioned for a long while, however, I would still love the ability to add a couple of user links

  • [[Special:/CentralAuth/{{{user_name}}}]], eg Special:CentralAuth/Billinghurst which are universal for whichever wiki one is editing
  • a link to guc through [[luxo:{{{user_name}}}]] again a static url through interwiki map (not linking, that is ugly for my account)

In both, spaces become plus symbols eg. "Johan+(WMF)", and with no other obvious conversions of characters (unicode characters display as unicode). Thanks for any consideration. — billinghurst sDrewth 04:47, 1 February 2019 (UTC)

IPv6 /64 ranges[edit]

It would be useful if links for IPv6 addresses (in contributions and watchlists), when moused over, could have an option to produce a list of contributions for the /64 range to which the address belongs instead of just the specific /128 address.[1]

One way to do this would be by splitting the link into two pieces, like this:

2A02:C7F:202:7500:14B3:9AA7:46A3:B9E0

When you mouse over the left side, you should get the contribs for the 2A02:C7F:202:7500::0/64 range (which currently doesn't work). When you mouse over the right side, you get the contribs for just the specific 2A02:C7F:202:7500:14B3:9AA7:46A3:B9E0/128 address.

References

  1. ^ As I understand it, IPv6 addresses are typically allocated in /64 blocks for each user by the provider. E.g., instead of your ISP allocating you a single IPv4 address of 189.201.223.245 (/32), and your router doing network address translation to your internal network of about 256 addresses in a block like 192.168.1.0/24 in a private use range, for IPv6 they will allocate 2A02:C7F:202:7500::0/64 to you and your internal network devices are assigned their addresses from that block (2A02:C7F:202:7500::0 through 2A02:C7F:202:7500:FFFF:FFFF:FFFF:FFFF).

Mouse-over template[edit]

In edit mode, when you select a wikilink and then mouse over it, you get a popup just like mousing over the wikilink in the rendered page. It would be nice if the same thing happened when you select a template call, e.g., {{Divbox}}. It could display the doc page as if you had moused over [[Template:Divbox/doc]] or, if that doesn't exist, the template itself as if you had moused over [[Template:Divbox]]. —[AlanM1(talk)]— 23:02, 12 February 2019 (UTC)

Popups no longer indicating that a page was added or removed from watchlist?[edit]

Starting several days ago, I noticed that when I use Popups and click on Actions/Watch or Actions/Un to add or remove a page from my watchlist without visiting it, I no longer get a pop-up window in the top right corner of my screen that says "XXX has been added to your watchlist" or "XXX has been removed from your watchlist".

To see if another script was in conflict with Popups, I deleted all the scripts on my vector.js page but that didn't make any difference. I restarted my browser in "safe mode" (i.e., with no extensions running) and that didn't make any difference either.

I use the Pale Moon browser (a Firefox fork), version 28.3.1, in Windows 7. This version of the browser was released on January 23, so that hasn't changed.

Was the Popups coding changed? If so, may I request that the notification that a page has been added or removed from an editor's watchlist be restored, at least as an option? Thank you. — Malik Shabazz Talk/Stalk 04:24, 18 February 2019 (UTC)

I used to middle-click (in FF or Chrome) the un-/watch action in popups which brought up a new tab with a confirmation dialogue. I've never seen a pop-up window like you describe. I did that middle-clicking because the behaviour of popups changed quite some time ago; actually, I think it was the un-/watch action that changed. I think the quiet un-/watch action you describe is an improvement, and I thank you for drawing my attention to it. If I want visual confirmation, I can just visit the page and un-/watch there. -- Michael Bednarek (talk) 11:09, 18 February 2019 (UTC)
Fixed; I usually avoid the popups code as too miserable to read, but this was clear. There was a change a week or two ago to how the api is loaded, this needed only a minor change. ~ Amory (utc) 12:05, 18 February 2019 (UTC)
Thank you, Amory. I'm glad it was an easy fix.
Michael Bednarek, the nice thing about the notification window is that it hovers in the corner of the screen for a few seconds and disappears on its own. It merely provides feedback that your "click" on the menu had the desired effect. — Malik Shabazz Talk/Stalk 02:09, 19 February 2019 (UTC)