Jump to content

Talk:Book embedding/GA1: Difference between revisions

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
Content deleted Content added
strikeouts, more comments
last comment
Line 14: Line 14:
* I think the ''Definitions'' section would greatly benefit from the addition of diagrams, particularly for '''book crossing number''' and '''pagewidth'''.
* I think the ''Definitions'' section would greatly benefit from the addition of diagrams, particularly for '''book crossing number''' and '''pagewidth'''.
* <s>"The two-page crossing number of the complete graph K<sub>n</sub> is" Perhaps this should start a new paragraph to avoid confusion.</s>
* <s>"The two-page crossing number of the complete graph K<sub>n</sub> is" Perhaps this should start a new paragraph to avoid confusion.</s>
* In ''Specific Graphs'', are there any results for multipartite graphs?
* <s>In ''Specific Graphs'', are there any results for multipartite graphs?</s>
* <s>"(but with only one copy of each vertex that appears more than once on the outer face)" I find this comment confusing. How could a vertex appear more than once?</s>
* <s>"(but with only one copy of each vertex that appears more than once on the outer face)" I find this comment confusing. How could a vertex appear more than once?</s>
* In the last paragraph of ''Relation to other graph invariants'', the discussion of the stack data structure makes sense to me, but I really don't understand the connection to the queue data structure. I think an additional sentence of explanation would go a long way.
* In the last paragraph of ''Relation to other graph invariants'', the discussion of the stack data structure makes sense to me, but I really don't understand the connection to the queue data structure. I think an additional sentence of explanation would go a long way.
* "However, this model does not apply to more sophisticated traffic controllers that do not operate in a fixed sequence of phases."{{cn}}
* "However, this model does not apply to more sophisticated traffic controllers that do not operate in a fixed sequence of phases."{{cn}}
I shall finish up in the next few days. --'''[[User:Cryptic C62|Cryptic C62]] · [[User talk: Cryptic C62|Talk]]''' 15:50, 4 April 2016 (UTC)
Done! --'''[[User:Cryptic C62|Cryptic C62]] · [[User talk: Cryptic C62|Talk]]''' 15:51, 13 April 2016 (UTC)
:Thanks, and please let me know when you finish. I'm still completing revisions to the other GA nom for [[linear probing]], and then traveling next week, but should have time to work on this after that. —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 06:08, 6 April 2016 (UTC)
:Thanks, and please let me know when you finish. I'm still completing revisions to the other GA nom for [[linear probing]], and then traveling next week, but should have time to work on this after that. —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 06:08, 6 April 2016 (UTC)
:In the meantime I think I've handled all of these comments except for the request for diagrams and the request for additional results about multipartite graphs. (It's not that I don't want to do those, too, only that they're not done yet.) —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 23:31, 8 April 2016 (UTC)
:In the meantime I think I've handled all of these comments except for the request for diagrams and the request for additional results about multipartite graphs. (It's not that I don't want to do those, too, only that they're not done yet.) —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 23:31, 8 April 2016 (UTC)
:Multipartite graphs added. —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 18:56, 10 April 2016 (UTC)
:Multipartite graphs added. —[[User:David Eppstein|David Eppstein]] ([[User talk:David Eppstein|talk]]) 18:56, 10 April 2016 (UTC)
::I have now commented on the entire article. I also made [https://en.wikipedia.org/w/index.php?title=Book_embedding&type=revision&diff=715078624&oldid=714359252 a few tweaks] myself, which you are welcome to review. --'''[[User:Cryptic C62|Cryptic C62]] · [[User talk: Cryptic C62|Talk]]''' 15:51, 13 April 2016 (UTC)

Revision as of 15:52, 13 April 2016

GA Review

GA toolbox
Reviewing

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: Cryptic C62 (talk · contribs) 15:50, 4 April 2016 (UTC)[reply]


Again, this article is off to an excellent start. I am particularly impressed with the efforts to summarize esoteric concepts in layman's terms, something deemed largely impossible by the mathematicians I have met. Comments through Behavior under subdivisions:

  • "with or without knowing a fixed vertex ordering along the spine of the book." The term spine has not yet been defined, which should probably happen in the first paragraph.
  • "It is unknown whether the book thickness of arbitrary graphs can be bounded by a function of the book thickness of their subdivisions." I think this would be slightly clearer in the singular rather than the plural: "It is unknown whether the book thickness of an arbitrary graph can be bounded by a function of the book thickness of its subdivision." This avoids any ambiguity about whether a single graph can have multiple subdivisions.
  • The History section ends with a one-sentence paragraph, causing sadness. Happiness could result from expanding the paragraph or merging it.
  • "it is the maximum size of a subset of edges within a single spine such that the intervals defined on the spine by pairs of endpoints of the edges all intersect each other." Perhaps I have misunderstood this concept, but I believe the highlighted word spine should be replaced with page, correct?
  • I think the Definitions section would greatly benefit from the addition of diagrams, particularly for book crossing number and pagewidth.
  • "The two-page crossing number of the complete graph Kn is" Perhaps this should start a new paragraph to avoid confusion.
  • In Specific Graphs, are there any results for multipartite graphs?
  • "(but with only one copy of each vertex that appears more than once on the outer face)" I find this comment confusing. How could a vertex appear more than once?
  • In the last paragraph of Relation to other graph invariants, the discussion of the stack data structure makes sense to me, but I really don't understand the connection to the queue data structure. I think an additional sentence of explanation would go a long way.
  • "However, this model does not apply to more sophisticated traffic controllers that do not operate in a fixed sequence of phases."[citation needed]

Done! --Cryptic C62 · Talk 15:51, 13 April 2016 (UTC)[reply]

Thanks, and please let me know when you finish. I'm still completing revisions to the other GA nom for linear probing, and then traveling next week, but should have time to work on this after that. —David Eppstein (talk) 06:08, 6 April 2016 (UTC)[reply]
In the meantime I think I've handled all of these comments except for the request for diagrams and the request for additional results about multipartite graphs. (It's not that I don't want to do those, too, only that they're not done yet.) —David Eppstein (talk) 23:31, 8 April 2016 (UTC)[reply]
Multipartite graphs added. —David Eppstein (talk) 18:56, 10 April 2016 (UTC)[reply]
I have now commented on the entire article. I also made a few tweaks myself, which you are welcome to review. --Cryptic C62 · Talk 15:51, 13 April 2016 (UTC)[reply]