User talk:TheTVExpert/rmCloser

Edit summary bug

Hey TheTVExpert, thanks for building this script! FYI, it seems to be doing something weird with the automated edit summary when you also have the copy-section-link script active. See here for an example. Thanks, --Jack Frost (talk) 08:46, 14 February 2021 (UTC)

@Jack Frost: Thanks for using the script. I see what is causing the issue and I should have it fixed tomorrow. TheTVExpert (talk) 14:25, 14 February 2021 (UTC)

@Jack Frost: It should now be fixed. Let me know if you find any other issues or if there is a feature you would like added. Thanks. TheTVExpert (talk) 20:13, 16 February 2021 (UTC)

TheTVExpert, Thankyou very much! Looking forward to the next update for the script. Cheers, Jack Frost (talk) 02:16, 19 February 2021 (UTC)

old move template

HiTheTVExpert, there is a strange text when the script insert an old move template (see [1]). Is this expected? Vpab15 (talk) 21:53, 2 March 2021 (UTC)

@Vpab15: Thanks for using the script. This should be a simple fix, which I will try to have done by tomorrow. TheTVExpert (talk) 22:22, 2 March 2021 (UTC)

Thanks for the quick reply. When I closed that RM which had two moves, I selected to request a technical move request. The first request was done fine ([2]) but it seems the second request overwrote the first one ([3]). Apart from that it is a very useful script, thanks for developing and maintaining it. Vpab15 (talk) 22:29, 2 March 2021 (UTC)

@Vpab15: The old move template should now be fixed. As for the technical requests, I will see about getting to that in the next version of the script. For now, waiting a few seconds between technical requests should work as a temporary fix. Let me know if you find any other issues or if there is a feature you would like added. Thanks. TheTVExpert (talk) 22:08, 3 March 2021 (UTC)

Add a notification inline about wikiproject ad?

Hey TheTVExpert, thank you so much for building this script, I find it insanely helpful! There is one thing I keep doing manually, though, that you may be able to really easily integrate in here. Whenever I use your script to advertise a discussion at a wikiproject, I also add this line to the discussion after the latest comment, like a delsort:

— Advertised at WikiProject Medicine. 02:40, 17 August 2021 (UTC)

like this:

:<small>— Advertised at [[Wikipedia_talk:WikiProject Medicine|WikiProject Medicine]]. ~~~~~</small>

Is that something you think others might find helpful as an option/addition? I know it would save me a lot of time! Thanks again, Shibbolethink ^{(♔ ♕)} 02:41, 17 August 2021 (UTC)

@Shibbolethink: Thank you for using the script. I have added this in for you. Let me know if you find any issues or if there is another feature you would like added. Thanks. TheTVExpert (talk) 21:44, 17 August 2021 (UTC)

Works like a charm! Thank you — Shibbolethink ^{(♔ ♕)} 22:43, 17 August 2021 (UTC)

Script removes part of RM

Hi TheTVExpert, I found some strange behaviour in it sometimes, I think it could be due to using <small> markup in the RM. See [4]. The script removes old name and the target name from the request. Is that something you could check please? Other than that, it is a great script, thanks a lot for building it. Vpab15 (talk) 12:25, 8 October 2021 (UTC)

A couple more examples: [5] [6]. Vpab15 (talk) 13:22, 8 October 2021 (UTC)

@Vpab15: It should now be fixed. Thanks. TheTVExpert (talk) 18:43, 8 October 2021 (UTC)

Issues

I've been having issues with the tool. But maybe I'm not using it correctly? It removed almost all of my long close summary[7].VR _talk 13:25, 22 October 2021 (UTC)

@Vice regent: This should now be fixed. Thanks. TheTVExpert (talk) 20:01, 22 October 2021 (UTC)

Buttons appear in wrong RM

When I go to Talk:HoYeon Jung the buttons for RM closing ("Close", "Relist" etc) appear in an already closed RM ("Requested move 7 October 2021") but not the current one ("Requested move 14 November 2021"). Please fix, thanks VR _talk 21:40, 20 November 2021 (UTC)

Can confirm with other pages. 🐶 EpicPupper ^{(he/him | talk)} 17:31, 15 March 2022 (UTC)

JQuery warning when loading certain pages (main page, watchlist, etc.)

Not a big deal, but is cluttering up my JavaScript console a bit. Figured I'd report. The fix is probably to check and make sure the in between element exists before trying to call it. Screenshots. –Novem Linguae (talk) 11:07, 27 November 2021 (UTC)

@Novem Linguae: This should now be fixed. Thanks. TheTVExpert (talk) 16:54, 25 February 2022 (UTC)

Issues with multi-move request

Please note the page history of Talk:Barabanki, TheBirdsShedTears moved the pages & closed the RM appropriately, but in the very next edit the closure note is removed. And old moves template, that should've appeared in the other page involved, is applied here automatically. Thus, the old move template did not appear in Talk:Barabanki (disambiguation) at all. I tried closure using the script too, same issues. ---CX Zoom(^he/_him) (^{let's talk}|_contribs) 15:07, 3 March 2022 (UTC)

@TheTVExpert: pinging for notification. ---CX Zoom(^he/_him) (^{let's talk}|_contribs) 15:08, 3 March 2022 (UTC)

@CX Zoom: My guess is that this was caused by the pages being moved prior to using the script to close the discussion. I assume the script tried to add the old move template to the Talk:Barabanki now at Talk:Barabanki (disambiguation) and since the pages were already moved, it added it instead to the Talk:Barabanki that was formerly at Talk:Barabanki, Uttar Pradesh and so the template ended up on the wrong page. As for why the closing text was removed, this is likely because when preparing to add the old move template to the Talk:Barabanki now at Talk:Barabanki (disambiguation) it fetched the content of Talk:Barabanki before the closing text was added and so when it saved the changes the closing text got removed. The easiest solution would be to use the script to close the discussion and then move the pages, though I will see if I can add something to the script to prevent this from happening just in case. TheTVExpert (talk) 16:35, 3 March 2022 (UTC)

Old Move template merger

I would like to remind you of efforts to replace {{Old move}} with {{Old moves}}; the merger is years old, so I presume you know about it already. — Ceso femmuin mbolgaig mbung, mellohi! (投稿) 20:17, 20 June 2022 (UTC)

Relisting with comment

Hi @TheTVExpert. Per WT:Requested moves#Multiple relists & WT:Requested moves/Archive 34#Size of RM backlog over time, there is a consensus that relisting without comment is generally very unhelpful and adding a relister's note should be encouraged. Since your tool is the most frequently used tool for RM close/relists now, I think, a "Relister's note" text box when "Relist" button is clicked will be helpful to encourage this. Basically the relisting template will work as usual, but a new line at the end of discussion will read something like this: : <small>'''Relister's note''': Comment goes here... ~~~~</small>. When the text box appears, a "Relist without leaving note" button will allow relisters to relist the RM like they do currently, if they deem it okay. Thanks! —CX Zoom[he/him] ^{(let's talk • {C•X})} 19:42, 25 September 2022 (UTC)

@CX Zoom: Thank you for using the script. I have added this in for you. Let me know if you find any issues or if there is another feature you would like to see added. Thanks. TheTVExpert (talk) 20:23, 29 September 2022 (UTC)

Thank you very much! I tested this at WT:Sandbox and it worked just I had hoped it to. —CX Zoom[he/him] ^{(let's talk • {C•X})} 21:02, 29 September 2022 (UTC)

Preview

Can we get a "preview" button on this tool? Would be helpful to see what we're about to do... - UtherSRG (talk) 15:53, 2 October 2022 (UTC)

Please add an option to watch the page after the discussion has been closed via the tool. - UtherSRG (talk) 16:28, 2 October 2022 (UTC)

Would probably be good, too, if the default setting for this is in the user's common.js . - UtherSRG (talk) 16:30, 2 October 2022 (UTC)

@UtherSRG: I will see about adding this in a future update to the script. Thanks. TheTVExpert (talk) 14:32, 7 December 2023 (UTC)

Using permalinks instead of talk page link in edit/move summaries

Hi again @TheTVExpert: Today, I completed a double-swap requested at RMTR due to the closure of a RM, with the help of this tool. Move was like this: A → B, B → C. Original RM was at Talk:B and the RMTR also mentioned it, but when we do double-swap, it will get moved to Talk:C, and the new Talk:B page will not contain the RM. Even in normal cases, RMs may get archived, so you click the link in move summary, go to the talk page, do not find it there and have to start searching in the archives. It would be great if, instead of Talk page link, the permalink after closure is supplied to the move summary, and RMTR requests, so that it is easily navigable. Thanks! —CX Zoom[he/him] ^{(let's talk • {C•X})} 19:50, 10 October 2022 (UTC)

RMCloser incompatible with misnamed RM sections

@TheTVExpert: RMCloser cannot close requested moves whose header is not in the format "Requested move [DATE]", like here. Is this fixable? — Ceso femmuin mbolgaig mbung, mellohi! (投稿) 15:29, 14 October 2022 (UTC)

Why not just update the section header to the standard format manually, then use RMcloser to do the close? - UtherSRG (talk) 22:39, 14 October 2022 (UTC)

RMCloser doesn't recognize subprojects

See for instance Talk:Dendrolagus_notatus#Requested_move_6_October_2022. This article is in a project that has a subproject, but the tool only picks out the main project. I manually notified the subproject. - UtherSRG (talk) 19:54, 16 October 2022 (UTC)

Agree I've had this problem as well, and have resorted to manual notifications. Would be great if this could be fixed!!! — Shibbolethink ^{(♔ ♕)} 23:54, 16 October 2022 (UTC)

Doesn't remove RM banner on article

Hi @TheTVExpert. For some reason the banner on the articlespace wasn't removed [8]. I don't remember if this is an intended functionality so that the RM bot would take care of that or a bug — DaxServer (t · m · c) 18:24, 4 February 2023 (UTC)

The RM bot takes care of that indeed, it is not a bug. Vpab15 (talk) 19:03, 4 February 2023 (UTC)

Ahh I see, thanks for the reply! — DaxServer (t · m · c) 19:29, 4 February 2023 (UTC)

Feature request: check for move protection before non-admin close

@TheTVExpert: Hi, I wonder if it would be possible to have rmCloser check whether the article is move-protected before closing a discussion, so that I could know in advance to either leave the RM to an admin or to use the WP:RM/TR button. ■ ∃ Madeline ⇔ ∃ Part of me ; 20:21, 8 March 2023 (UTC)

Buttons showing under the wrong move request

Hey, on Talk:2022 Peruvian political crisis, the buttons to close/relist/notify wikiprojects are showing under the first RM, which was closed, as opposed to the currently-open second RM. I'm guessing it's because of the alternate template used for closing the first discussion. Skarmory (talk • contribs) 05:21, 15 May 2023 (UTC)

Odd closure

Can you take a look at this diff and see if there's a tool issue that needs fixing? Thanks! - UtherSRG (talk) 11:42, 23 May 2023 (UTC)

Interface-protected edit request on 7 June 2023

Can you please change the code {{subst:relisting}} to {{subst:RM relist}} to reflect the new title? Interstellarity (talk) 21:27, 7 June 2023 (UTC)

 Done Izno (talk) 21:58, 7 June 2023 (UTC)

Change of edit summary in history after move

Can you modify the tool to instead of adding a link to the pertinent discussion, based on which a move was agreed upon, it adds a piped permalink to the discussion because after archiving the link will be broken? Qwerty284651 (talk) 02:04, 26 June 2023 (UTC)

Example from Talk:List of Grand Slam and related tennis records --> Special:Permalink/1161945502#Talk:List of Grand Slam and related tennis records#Requested move 11 June 2023.

Error with multi-page RM moves

Hi. After closing Talk:List of High Commissioners and Ambassadors of Australia#Requested move 7 August 2023, an error stopped the script from working, here is the full error:

load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core%7Cjquery.ui&skin=vector&version=vygu3:357 jQuery.Deferred exception: Cannot read properties of null (reading 'getTalkPage') TypeError: Cannot read properties of null (reading 'getTalkPage')
   at Object.onLoadSuccess (https://en.wikipedia.org/w/index.php?title=User:TheTVExpert/rmCloser.js&action=raw&ctype=text/javascript:271:46)
   at Morebits.wiki.page.fnLoadSuccess (<anonymous>:511:759)
   at Morebits.wiki.api.onAPIsuccess (<anonymous>:489:885)
   at mightThrow (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core%7Cjquery.ui&skin=vector&version=vygu3:354:881)
   at process (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core%7Cjquery.ui&skin=vector&version=vygu3:355:544) undefined

Thanks for looking into it — DaxServer (t · m · e · c) 09:34, 14 August 2023 (UTC)

The Notify WikiProjects button isn't working for me

@TheTVExpert, just letting you know, the Notify WikiProjects button isn't working for me on my iPad. I checked it on my requested move at Talk:Aspire TV. Yours sincerely, TechGeek105 (his talk page) 08:03, 28 August 2023 (UTC)

Interface-protected edit request on 8 September 2023

var textToFind = /---- and enter on a new line.* -->/;

var textToFind = /and enter on a new line.* -->/;

Please remove ---- from this line so that it can find the current text of WP:RM/TR, which no longer has these hyphens. Tested on test.wiki. SilverLocust 💬 18:33, 8 September 2023 (UTC)

(The hyphens haven't been at WP:RM/TR since February, so the submitRMTR part of the script has not been working since February. And, of course, this would still work if the hyphens are later restored at WP:RM/TR.) SilverLocust 💬 21:08, 8 September 2023 (UTC)

 Done Izno (talk) 21:25, 8 September 2023 (UTC)

Feature request

Please change the radio buttons for notifying WikiProjects to checkboxes to allow multiple projects to be notified at once. Please also then update the format of how the notice is placed in the move discussion so that it is only one line for the notice. - UtherSRG (talk) 12:27, 7 December 2023 (UTC)

@UtherSRG: I will see about adding this in a future update to the script. Thanks. TheTVExpert (talk) 14:32, 7 December 2023 (UTC)

@TheTVExpert Just for the record, I actually came here to request what UtherSRG requested above. Just didn't want to duplicate. Vanderwaalforces (talk) 12:09, 4 January 2024 (UTC)

Make it easier to find topic via edit message

I created a PR here https://github.com/TheTVExpert/rmCloser/pull/17 ~ 🦝 Shushugah (he/him • talk) 17:33, 9 January 2024 (UTC)

Bug?

I have noticed today that I was not able to make bulk moves with the script, is this known? For example Talk:Equestrian at the Summer Olympics, after closing a RM with the "moved" rationale, there's supposed to be an option to move those pages. That didn't show up at all. Vanderwaalforces (talk) 11:36, 17 January 2024 (UTC)

Edit to some regex

−

destination = template.match(/\|(.*)}}/);

+

destination = template.match(/\|(.*?)(?:\|.*)?}}/);

Please make the above change so that the script works as normal when there are single-move RMs that have additional parameters other than just the new title. The current version works fine with

{{requested move/dated|NewTitle}}

but not with

{{requested move/dated|NewTitle|_}}

where it treats NewTitle|_ as being the new title instead of just NewTitle.

The current version means that the script is unable to move the page to the new title, since a title with | is not a valid title (or the intended one). I have tested this on testwiki:Talk:rmCloser.

regex key
\| — the character | . — any character _* — as many of _ as possible _*? — as few of _ as necessary (lazy) (_) — capture group (outputted as a string) (?:_) — non-capture group (not separately outputted) _? — 0 or 1 instances of _

SilverLocust 💬 23:36, 4 February 2024 (UTC) (changed to an edit request on 20:28, 8 February 2024 (UTC))