Wikipedia:Bots/Requests for approval/DatBot 9

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

DatBot 9

Operator: DatGuy (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 16:18, Friday, June 15, 2018 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): Python

Source code available: https://pastebin.com/H9zhpb2u

Function overview: Add matching WikiProject banners to files which are transcluded on pages that have matching Infoboxes (if that makes sense)

Links to relevant discussions (where appropriate): Wikipedia:Bot_requests#Tag_covers_of_academic_journals_and_magazines_with_Template:WikiProject_Academic_Journals_/_Template:WikiProject_Magazines

Edit period(s): Daily

Estimated number of pages affected: Currently, maximum 23000 but probably less

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: *In {{infobox journal}}, look for |image= or |cover=. If it's not empty, go to the associated file, and tag it with {{WikiProject Academic Journals}}

In {{infobox magazine}}, look for |image_file= or |logo=. If it's not empty, go to the associated file(s), and tag it with {{WikiProject Magazines}}

Discussion

Just an FYI, you missed a few redirects to Template:WikiProject Banner Shell , and also to the Journals and Magazines project templates. Not sure why we need so many redirects to WProj templates, but hey ho. On a minor code review note, I'm not sure why you're raise'ing an IndexError if the templates are found rather than just using continue directly. That has no bearing on the operation of the task however, so feel free to tell me to mind my own. ƒirefly ( t · c · who? ) 22:09, 16 June 2018 (UTC)[reply]

@Firefly: Done, updated code. Dat Guy^Talk_Contribs 18:53, 19 June 2018 (UTC)[reply]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. 25 for magazines, 25 for journals. Headbomb {t · c · p · b} 20:26, 18 June 2018 (UTC)[reply]

Trial complete. contribs seemed to work as expected. Dat Guy^Talk_Contribs 18:53, 19 June 2018 (UTC)[reply]

Note: also added User:DatBot/run/task9. Dat Guy^Talk_Contribs 18:57, 19 June 2018 (UTC)[reply]

Approved., I'm adding this much later for clarity, since I forgot to do it at the original time of closure. Headbomb {t · c · p · b} 11:49, 18 August 2018 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.