Wikipedia:Bots/Requests for approval/John Bot II 3

The following discussion is an archived debate. Please do not modify it. Subsequent comments should be made in a new section. The result of the discussion was

Approved.

John Bot II (request 3)[edit]

Operator: CWii_{(Talk|Contribs)}

Automatic or Manually Assisted: Automatic but images will be approved by trusted humans

Programming Language(s): Python

Function Summary: Moves images that have been approved by trusted humans to the commons.

Edit period(s) (e.g. Continuous, daily, one time run): Daily

Already has a bot flag (Y/N): Y (Me thinks)

Function Details: The images will be first approved by humans using my script. Then they will be moved over to the commons and marked for CSD:I8 here.

The bot will also do tasks such as removing move to commons templates from images that users have tagged, and marking Images that were already moved.

The code will be posted after some finishing touches.

Discussion[edit]

Have you posted a bot request on Commons yet? Mr.Z-man 03:45, 11 October 2008 (UTC)[reply]

The commons bot was already approved months ago. I checked with a commons crat and they said that I could start this task again without any further requests. CWii_{(Talk|Contribs)} 14:03, 11 October 2008 (UTC)[reply]

The code. ~~User:John Bot II/Source~~ CWii_{(Talk|Contribs)} 01:33, 12 October 2008 (UTC)[reply]

What I specifically said was that if the Commons aspect of the bot hasn't changed (at all) then it doesn't need to re-request Commons approval. Note the "at all". Giggy (talk) 01:55, 12 October 2008 (UTC)[reply]

After talking to Giggy the bot will need to be re approved at commons. I was trying to avoid this :/ CWii_{(Talk|Contribs)} 02:02, 12 October 2008 (UTC)[reply]

Just a few comments:

Might want to move some of the re.compile()s outside the for loop, so it doesn't compile the regex on each iteration, which kind of defeats the purpose.
What's the point of the canMove parameter to the template? Why would someone tag it, but not allow it to be moved?
It should get the username from the page history, not the template. Otherwise anyone can just forge the username. Additionally, will the checkpage be protected?
Might want to check that the commons categories actually exist before adding them.
It seems to import a bunch of modules that it doesn't use (doesn't really affect anything)

Other than that, it looks okay. Mr.Z-man 02:05, 12 October 2008 (UTC)[reply]

Commons request commons:Commons:Bots/Requests for flags/John Bot II 2 CWii_{(Talk|Contribs)} 02:08, 12 October 2008 (UTC)[reply]

Will it copy the discussion pages of the images as well? That was not implemented yet in Betacommondbot when he did that task. It often is helpful when there is a copyright explanation/discussion on the talk page. Garion96 (talk) 22:27, 12 October 2008 (UTC)[reply]

It doesn't. Anything useful should be on the image page anyway, and moving the talk page would require fixing links so that they still work. CWii_{(Talk|Contribs)} 22:31, 12 October 2008 (UTC)[reply]

I think there should be an option for that. See for instance File talk:JustinGuarini concert screencap3.jpg and the discussion here. Garion96 (talk) 22:40, 12 October 2008 (UTC)[reply]

A picture with that much of a licensing mess shouldn't be moved to the commons, let alone by a bot. CWii_{(Talk|Contribs)} 17:23, 13 October 2008 (UTC)[reply]

This is an extreme example, there are other examples where moving the talk page would be helpful. A commons bureaucrat agreed on that btw on the discussion I linked above. Garion96 (talk) 18:28, 13 October 2008 (UTC)[reply]

Some other issues, for pageTextPost, it should use time.sleep() if it gets an error, so you aren't just pounding the server with requests if it fails. You might want to increase the sleep time each error, and if it reaches a certain threshold, 60 seconds of sleep time for example, it just assumes the server is completely down. It might also want to check the HTTP status code. Switchboard errors for example will return some content on a GET request (not sure what it will do on POST), but nothing that you would want, but it will also set a HTTP 500 error.

Note that if you do decide to move the talk page, it would also have to get the page history information, though I agree moving the talk page in most cases would probably be unnecessary, if they have content, they are usually just WikiProject tags, which would break on commons or garbage. Mr.Z-man 18:09, 14 October 2008 (UTC)[reply]

Agree for most images it is pointless. But an option which could be turned on by request would be nice. Just adding a +talk to the template or something like that. Garion96 (talk) 19:09, 14 October 2008 (UTC)[reply]

Code is now kept on my svn repos: [1] CWii_{(Talk|Contribs)} 00:15, 15 October 2008 (UTC)[reply]

{{BAGAssistanceNeeded}} The bot and the commons are ready for a trial. CWii_{(Talk|Contribs)} 21:27, 15 October 2008 (UTC)[reply]

It uses template {{Jb2move}}, but that isn't listed in the list of templates to remove after moving to commons... Mr.Z-man 22:04, 15 October 2008 (UTC)[reply]

It will be removed by CommonsHelper, but I'll add it to the list. CWii_{(Talk|Contribs)} 22:14, 15 October 2008 (UTC)[reply]

Done CWii_{(Talk|Contribs)} 01:55, 16 October 2008 (UTC)[reply]

Approved for trial. Please provide a link to the relevant contributions and/or diffs when the trial is complete. 5 images should be good. An option to move the talk page might be nice, but I don't think its a critical feature. Mr.Z-man 02:11, 20 October 2008 (UTC)[reply]

Roger that! Will begin when I get home today. CWii_{(Talk|Contribs)} 16:05, 20 October 2008 (UTC)[reply]

Trial complete. 6 images were moved on accident, sorry CWii_{(Talk|Contribs)} 01:17, 22 October 2008 (UTC)[reply]

Approved. Mr.Z-man 17:26, 25 October 2008 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. Subsequent comments should be made in a new section.