- Comments from KV5
- "The first recorded baseball event in Australia occurred in Melbourne, Victoria in 1857, though accounts vary as to the details, including whether it was a single game or a series of three games, between teams from Collingwood and Richmond." - this seems a bit like a run-on to me; a change in punctuation or wording might help it. ex: The first recorded baseball event in Australia occurred in Melbourne, Victoria in 1857—though accounts vary as to the details, including whether it was a single game or a series of three games—between teams from Collingwood and Richmond. or The first recorded baseball event in Australia occurred in Melbourne, Victoria in 1857 between teams from Collingwood and Richmond, though accounts vary as to the details, including whether it was a single game or a series of three games.
 Done You might want to re-check it. I split it into separate sentences, but does seem better now.
- Milwaukee Brewers linked in lead at second occurrence, not first; Yankees not linked at all.
- Done
- "League Champions" - un-capitalize
- Done
- "the Major Leagues" - likewise; "Major League Baseball" is a proper not but "the major leagues" is not.
- Done
- "in an MLB game," no comma necessary
- Done
- Tables need to be adjusted to meet WP:ACCESS requirements; see MOS:DTT for instructions. Scopes, row/col headers, captions needed.
- When you have multiple positions, a non-breaking space is needed before each slash, so "2B / 3B" instead of "2B / 3B"
- Done
- "Denotes played in the 2011 season." - remove full stop/period
- Done
- "Quinn acted as player/manager" - player-manager should be linked, and is usually written with a hyphen
- Done
- Remove full stop/period from Graeme Lloyd's caption, as it's not a complete sentence
- Done
- The sandwiching of a table between images distresses me. Perhaps one or two images could be moved alongside the main table.
- Done
- Done
- Bold in the table violates MOS:BOLD, and no indication is given anywhere as to what it means (I know it's championships but uninitiated readers won't).
- Done
- In reference section, use semi-colon headers to separate groups of references rather than plain text.
- Done
- Done
- I think I've covered everything you've brought up. (It is getting late here so I may have missed something or messed something else up.) If there is anything else, let me know and I'll do what I can. Also, thanks for taking the time to do the review. Afaber012 (talk) 13:07, 23 August 2011 (UTC)[reply]
- @KV5 - shouldn't the first column of the tables have a different color background, as with the top row per WP:ACCESS? PumpkinSky talk 00:19, 23 August 2011 (UTC)[reply]
- See above: "Tables need to be adjusted to meet WP:ACCESS requirements; see MOS:DTT for instructions. Scopes, row/col headers, captions needed." — KV5 • Talk • 11:17, 23 August 2011 (UTC)[reply]
- FRom what I understand, it's still not there, the left column is the same background as the others. See FL List of stutterers to see what I mean.PumpkinSky talk 20:52, 23 August 2011 (UTC)[reply]
- No, I know it's not there right now, but I did address it as needing to be corrected. I know what you are trying to say. — KV5 • Talk • 22:15, 23 August 2011 (UTC)[reply]
- If what you're both saying is "the names of the players in both of the tables should actually be row headers rather than normal cells", I'm not sure I agree. At the end of the day, If it's what's needed to get the list over the line, then fair enough, but I have reasons for thinking it should stay as is. Firstly, I would tend to use that sort of format in circumstances where the table could be turned into a graph of some sort covering all information presented. That's not really the case here. Put it another way: if there was an extra column at the beginning of the table along the lines of "Order of appearance" and then listed "1st", "2nd", "3rd", etc, I doubt that would be an appropriate header, though it would be a reasonable piece of information to have in the table. Secondly, there are examples on the MOS:DTT page that do not have row headers, as there are examples on the W3C site the same way.
- Now I've come across something that might bridge the gap that would seem to cover the accessibility issue without changing the appearance. The "
scope" attribute can be applied to a table cell as well as to a header. If I put that in to the tables, would you guys be happy with that? Afaber012 (talk) 09:39, 24 August 2011 (UTC)[reply]
- The data table tutorial might not show an example list with all the names as row headers, but it does say that they are required: WP:ACCESS#Data tables notes the three required elements as captions, row and column headers, and scope of headers. The DTT is not an all-inclusive list of what can be created, as you obviously are aware; it is a guide to how the ACCESS guidelines can be implemented. So, in short, yes, I do think that it needs to be put in. — KV5 • Talk • 11:00, 24 August 2011 (UTC)[reply]
- It's now done. I was flipping back and forth after I posted before about whether or not they should be headers, and after sleeping on it I agree. I still think the points I raised above are valid, and that simply turning the first column of cells into headers should not be done. Sometimes it will work, sometimes the table will need re-working, but other times - as shown in the "Good example of headers structure" in MOS:DTT it's not necessary. Afaber012 (talk) 01:30, 25 August 2011 (UTC)[reply]
|
