User talk:Cacycle/wikEdDiff

Screenshot?

A screenshot of the tool in action would be useful. Λυδαcιτγ 03:41, 17 April 2007 (UTC)

I second to this suggestion. OhanaUnited 22:29, 17 April 2007 (UTC)

Thanks, User:Mahanga. Λυδαcιτγ 17:35, 18 April 2007 (UTC)

Supported browsers

Support on Safari would be nice to know about, as well as Firefox. -- Yellowdesk 15:25, 19 April 2007 (UTC)

Test it and update the list. Cacycle 16:26, 19 April 2007 (UTC)

Color legend and symbol map

In a large diff I just checked I see sections highlighted in red, green, light green, yellow, grey, pink, purple and blue, and the occasional purple and grey buttons with arrows inside. It's not self-explanatory. I think a summary section of what this all means would go a long way.--Fuhghettaboutit 12:17, 20 April 2007 (UTC)

OK. The colors are indicating moved blocks (due to a bug the block color coding ends with the 'normal' change indicators, not with the real block end. I will try to fix that soon). Cacycle 12:51, 20 April 2007 (UTC)

Safari 3

The script does function on Safari 3, but the CSS is not loaded. This problem is a bug in Safari, and a similar problem was also present in Twinkle. Safari does not register empy <style> elements if they are appended. See this diff for an easy fix to that problem. --TheDJ (talk • contribs) 20:49, 12 July 2007 (UTC)

Unfortunately I have no access to Safari. Please could you point me to the code that you suspect. On a (very) quick inspection I did not find the addition of empty stylesheets to the document. Thanks, Cacycle 02:02, 13 July 2007 (UTC)

In function WikEdDiffStyleSheet(documentObject), where it says "this.styleElement = documentObject.createElement('style');" before "insert.appendChild(this.styleElement);" add "this.styleElement.appendChild(document.createTextNode());" --TheDJ (talk • contribs) 02:28, 13 July 2007 (UTC)

I have added that change, please could you check if it works now. Thanks, Cacycle 20:40, 14 July 2007 (UTC)

Works like a dream !! Thanks. --TheDJ (talk • contribs) 23:55, 14 July 2007 (UTC)

Thanks, Well Done!

I've been looking for something like this for a long time -- see my comments going back a year and a half on Bugzilla Bug 5072. I just stumbled across WikEdDiff and it looks like you've solved my problem. Thanks very much for a valuable editing tool. --SteveMcCluskey (talk) 02:06, 30 March 2008 (UTC)

About the crash.

There are crashlogs of Safari here: https://bugs.webkit.org/show_bug.cgi?id=18392 It seems to have something to do with how a node element is being treated. So I think there is an error in the way HTML nodes are "walked". probably need to verify the type that you want to use in ann iteration or something like that. --TheDJ (talk • contribs) 00:32, 13 April 2008 (UTC)

I took a quick look: probably caused by this:

var tdArray = document.getElementsByTagName('TD');
	var tdOld;
	var tdNew;
	for (var i = 0; i < tdArray.length; i ++) {

getElementsByTagName returns a NodeList, not an array. --TheDJ (talk • contribs) 00:36, 13 April 2008 (UTC)

Unfortunately, I do not have Safari and cannot debug this myself. If somebody can figure this out I would be happy to fix the code. Thanks, Cacycle (talk) 02:25, 13 July 2008 (UTC)

Tracking authorship

Hi, I just came across your work on wikEdDiff. I have some suggestions on how to improve wikipedia, following up on an old feature request thread at bugzilla. I'd be interested in your comments on this issue. --Jt68 (talk) 16:33, 13 July 2008 (UTC)

Bugs

Hi!
I don't know, where is the best place to report bugs. I hope someone will read it here.
Take for example this diff: [1]. Using WikEdDiff the string "Kompositionen" seems to be deleted at top and put to bottom. But that is not true. Perhaps the mapping of the two strings "Original" is somehow wrong. -- Lustiger seth (talk) 16:23, 20 November 2008 (UTC)

another example for probably the same bug: [2] (3->3000). -- seth (talk) 00:49, 28 March 2009 (UTC)

Thanks for reporting this. I will have a look at it, but it may take a while as I am really busy in real life. Cacycle (talk) 16:42, 28 March 2009 (UTC)

External link bug

I love how I can click on wikilinks in the diff to take me to the article, and notice that this app provides clickable links for ELs too, but the EL links are always broken. The link is always truncated. Can you fix this, because I would like to be able to use that feature. Thanks! Wizard191 (talk) 21:03, 24 May 2009 (UTC)

Hi, that's because of that rubbish behavior of js to match "i" by /[\u0130]/i, see [3]

I recommend changing of

html = html.replace(/((https?|ftp):(\/\/[^\u0000-\u0020\!\"\$\'\(\)\*\,\<\>\[\\\]\^\`\{-\|\}\u007f-\uffff]*|<[^>]*>)+)/gi

by

html = html.replace(/((?:https?|ftp):(?:\/\/[^\u0000-\u0020!"\$'()*,<>[\\\]^`{|}\u007f-\uffff]*|<[^>]*>)+)/g

-- seth (talk) 19:15, 26 July 2009 (UTC)