Module talk:RoundN

Check request

• @Mr Stradivarius and Jackmcbarn: - Would you guys please take a look at this? As this is my third module, the module could probably benefit from your experienced eyes to spot potential bugs and ideas for improving the new features. The rendering of {{Round16}} and {{Round8}} are nearly identical, I think; I have not attempted to emulate the spacing of {{Round2}} and {{Round4}} but I don't see a good reason to display them exactly as long as the information conveyed is the same... perhaps those templates would benefit from standardization/a more compact form? What do you think? —CodeHydro 02:26, 2 January 2015 (UTC)

Byes

Two byes to a match leave a black line to the next round, see

	Quarter-finals				Semi-finals				Final
					Day 2
					C
					D
									tdb
									A
	tdb
	A
					tdb
					A
	Day 1
	A	7
	B	5

-Koppapa (talk) 11:25, 6 January 2015 (UTC)

 Done @Koppapa: Ha, I had actual set up my code to detect when both matches are skipped so I could remove the line. Silly me forgot to implement it! Good catch! Anyhow, while I was at it, I came up with a neat shorthand for skipmatch and also extended it beyond the first round. See Module talk:RoundN/testcases/3. Thanks again! —CodeHydro 03:44, 8 January 2015 (UTC)

Comments

@Codehydro: It looks quite good to me. I haven't seen, that somebody would use colors, but ok - as a feature it is ok. You could get some input from WT:FOOTIE, as those templates are usually used by them. --Edgars2007 (talk/contribs) 09:15, 3 January 2015 (UTC)

Please read before asking for seeds

RoundN is intended to replace templates like Template:Round16 which never used seeds. For seeds, use Module:TeamBracket. While it's hardly a challenge to add them, my thinking is that adding a check for seeds is more of a performance drag than helpful since there is already a module that supports them. As much as I want to make accommodate every possible need, the fact is too many features will slow down the module. Slow module = more servers resources used = more ad campaigns for donations = less pleasant wiki and slower page loads. Yes, this module does fancy things that Team bracket currently can't, like auto-bolding and score-summing, but these features save server resources because the mediawiki engine no longer has to parse wikibold markup in each parameter and Lua is more efficient at string processing. (If you want these features with seeds, let TeamBracket's programmers know that they may use RoundN's score cleaning/processing functions by adding require('Module:RoundN').scoreWasher to their code.) —CodeHydro 17:08, 27 January 2015 (UTC)

More compact

Could it be possible to reduce a line the distance between the title of the rounds and the first match box? There is too much space between both. Asturkian (talk) 08:00, 29 January 2015 (UTC)

BTW, you should add in the documentation, the information about |score-boxes= and the possibility of 2+sum. Asturkian (talk) 09:09, 29 January 2015 (UTC)

@Asturkian: Sorry for the delayed respond. I didn't see the question until just now. I'm assuming you've left the date/place box blank, which would make it appear as though there were a big gap between the title and the first match. A simple work around could be to put an empty span tag <span /> as the first date parameter, which would minimize the size of the first date row. As for documenting the +sum switch, that is a beta feature which is not officially released. The documentation will be updated when Beta goes live. —CodeHydro 12:49, 24 March 2015 (UTC)

@Codehydro: How does the score-boxes parameter work? QED237 (talk) 16:20, 23 March 2015 (UTC)

@Qed237: Though I hate to do this, I must hold off on explaining it until the official release of Beta. Been working on a higher priority project so I haven't even touched RoundN since January (RoundN is expected to be used on a few thousand pages at most; the higher priority module is used on 2 million pages). Sorry, but, for now, you'll have to make do by studying Module talk:RoundN/testcases/4, Module talk:RoundN/testcases/5, and Module talk:RoundN/testcases/6 on your own. Very overwhelmed with work lately... and though I'm pretty fast at writing code, I'm awful slow when it comes to explaining it. (In fact, Beta has been 95% ready, but just updating the doc page would probably take me a couple of weeks... and it's probably going to be a while before I even get back to RoundN). —CodeHydro 12:49, 24 March 2015 (UTC)

@Codehydro: Okay, no problem. I just wanted to check it had not been forgotten. Take your time. QED237 (talk) 14:38, 24 March 2015 (UTC)

Chess

Used it here. It bolds ½ over 1½. Is there a way to change that automatically? Or is manually bolding the way to go? If non-numbers are removes, shouldn't be 1 be bold over nothing? -Koppapa (talk) 17:07, 17 March 2015 (UTC)

@Koppapa: I see you came up with a workaround on your own. I may have suggested something like {{sort}}, but your way seems to work just fine. The release of beta will have way to customize how scores are "cleaned" but alas Module:RoundN has been on hold because I have other priorities right now —CodeHydro 13:32, 24 March 2015 (UTC)

Error with third place

Hello again. I was trying to export this module to the 2014–15 LKL season article (for making a 5-5-7 playoffs) and I found the third place series are not well displayed. Is there any way to fix it? Asturkian (talk) 21:17, 19 April 2015 (UTC)

Display one team in node

@Codehydro: Hi, I know you are probably busy but is there a way to display only one team in a node at the same time you have scoreboxes? It does not seem to work when testing in User:Qed237/sandbox5. On WT:FOOTY It was requested a bracket that involves teams that can play after being eliminated. Qed237 (talk) 13:53, 6 July 2015 (UTC)

• Hmm, well there is a way.. .but why would you need score boxes for team by itself? Why not use something like Module_talk:RoundN/testcases/6--i.e., the losing teams are in a separate branch? I don't see a situation how a team by itself with no other team can score anything. —CodeHydro 01:43, 10 July 2015 (UTC)

@Codehydro: Just look at my sandbox and you see the reason, the best ranked eliminated team immediately joins the other teams (and no separate branch). Qed237 (talk) 23:38, 17 July 2015 (UTC)

@Qed237:I edited your sandbox... something like that? not the prettiest solution, but doesn't require changing Module:RoundN. You may be able to get a better result with node_function{canvas} instead of {line}, but it would require some good HTML/CSS hacking to make it look good. —CodeHydro 03:13, 18 July 2015 (UTC)

@Codehydro: Looks fine, but I need the extra scorebox as the third round is played with two matches. Qed237 (talk) 11:45, 18 July 2015 (UTC)

Two-legged matches

Are there any plans to add support for two-legged knock out rounds? TheBigJagielka (talk) 12:49, 30 October 2015 (UTC)

I think that already exists. TheBigJagielka are you thinking about something like

	Quarter-finals						Semi-finals						Final
	Day 1
	Team A	7	2	9
							Day 5
	Team B	5	3	8
							Team A	3	2	5
	Day 2
							Team C	0	2	2
	Team C	4	1	5
													Day 7
	Team D	0	0	0
													Team A			2
	Day 3
													Team G			5
	Team E	0	2	2
							Day 6
	Team F	5	3	8
							Team F	1	1	2
	Day 4
							Team G	2	1	3
	Team G	2	1	3
	Team H	1	1	2

Just use |score-boxes=2+sum. Was that what you had in mind? Qed237 (talk) 13:29, 30 October 2015 (UTC)

It is. Thanks, I didn't know that that feature existed. TheBigJagielka (talk) 13:33, 30 October 2015 (UTC)

Not easy to know as it has not been included in documentation for some reason. I just noticed it somehow I while back. Qed237 (talk) 13:50, 30 October 2015 (UTC)

See now it has been mentioned on this talkpage before. 13:50, 30 October 2015 (UTC)Qed237 (talk)

I was looking to update the bracket on the 2015 Canadian Championship, merging two templates into one.

From this:

	Semifinals							Final
	1	Vancouver Whitecaps FC	1	2	3
	4	FC Edmonton	1	1	2
								1	Vancouver Whitecaps FC	2	2	4
								3	Montreal Impact	2	0	2
	2	Toronto FC	0	3	3
	3	Montreal Impact	1	2	3

To this:

	Preliminary Round						Semifinals						Final
							1 Vancouver Whitecaps FC	1	2	3
							4 FC Edmonton	1	1	2
	FC Edmonton	3	3	6
	Ottawa Fury FC	1	1	2
													1 Vancouver Whitecaps FC	2	2	4
													3 Montreal Impact	2	0	2
							2 Toronto FC	0	3	3
							3 Montreal Impact (a)	1	2	3

There are two issues; I don't know how to make the league position (the left hand box) appear or know how to embolden the 'sum' for the semi-final winner on away goals. TheBigJagielka (talk) 14:05, 30 October 2015 (UTC)

@Codehydro: Do you know why the RDseed in first semifinal match (Vancouver v Edmonton) is not "perfect" (a thicker bolded line). Qed237 (talk) 15:05, 4 May 2016 (UTC)

@Qed237: It's an interaction with the skipmatch parameter. Basically the skipmatch attempts preserve shape of the table with invisible non-breaking space characters by default, but when nodes are skipped unevenly, the skipped characters cause the rows to become uneven in height. RDSeed is a CSS hack that depends on even row heights. I fixed it using the flex_tree parameter. The branch lines between matches won't be perfectly symmetrical, but the nature of the HTML forces one to choose between even looking seeds or even looking branches--i.e. the row height needed to make one thing look even will make the other to look uneven... —CodeHydro

PS: This interaction between skipmatch and seeds was forced upon me the need to maintain backwards compatibility with the HTML of the old pre-module template. Just making a note here to remind myself and to let future programmers know not to fix this interaction. One of these days I will actually write the documentation for the flex_tree parameter along with all the other undocumented features... (PPS: for every feature you see in the current documentation, there are at least twice as many undocumented... :\ ) —CodeHydro 15:21, 8 May 2016 (UTC)

Third place match alignment issue with two-legged matches

@Codehydro: Hello, as I was converting the tournament bracket of UEFA Euro 1968 to use this module, I noticed that the third place match box seems to be shifted to the left of where is usually is located, after I had added "score-boxes" to display the final replay score. Am I doing something incorrectly, or is there an issue with the module? The problem seems to get worse with tournaments of more than four teams (see below). S.A. Julio (talk) 22:34, 19 February 2017 (UTC)

Euro 1968 example

	Semi-finals					Final
	5 June – Naples
	Italy (coin toss)		0
						8 and 10 June – Rome
	Soviet Union		0
						Italy	1	2
	5 June – Florence
						Yugoslavia	1	0
	Yugoslavia		1
	England		0
						Third place play-off
						8 June – Rome
						England		2
						Soviet Union		0

Eight team example

Quarter-finals

Semi-finals

Final

5 June – Naples

Italy

1

5 June – Naples

Zimbabwe

0

Italy (coin toss)

0

5 June – Naples

Soviet Union

0

Mexico

0

8 and 10 June – Rome

Soviet Union

2

Italy

1

2

5 June – Florence

Yugoslavia

1

0

Yugoslavia

3

5 June – Florence

Australia

0

Yugoslavia

1

5 June – Florence

England

0

Third place play-off

Argentina

0

8 June – Rome

England

1

England

2

Soviet Union

0

• @S.A. Julio: The score-boxes parameter was not designed to be used for rematches. Instead put the rematch score in parenthesis in the same score box, like so:

	Semi-finals				Final
	5 June – Naples
	Italy (coin toss)	0
					8 and 10 June – Rome
	Soviet Union	0
					Italy	1 (2)
	5 June – Florence
					Yugoslavia	1 (0)
	Yugoslavia	1
	England	0
					Third place play-off
					8 June – Rome
					England	2
					Soviet Union	0

Does this work for you? —CodeHydro 20:12, 21 February 2017 (UTC)

@Codehydro: Hmm, the only issue as that numbers in parentheses usually refer to penalty shoot-out scores. Also, the problem applies to normal tournaments over two legs that have a third place match (see below). S.A. Julio (talk) 20:32, 21 February 2017 (UTC)

	Semi-finals						Final
	5 June – Naples
	Canada	2	2	4
							8 and 10 June – Rome
	Angola	0	1	1
							Canada	1	2	3
	5 June – Florence
							Argentina	1	0	1
	Argentina	1	4	5
	Australia	0	2	2
							Third place play-off
							8 June – Rome
							Angola	2	2	4
							Australia	0	2	2

• @S.A. Julio: I hadn't encountered a real-life multi-leg tournament with a third place match during the development of RoundN. Is your above example based on an actual tournament or is it purely theoretical? Granted I should have probably programmed the third place spot to tolerate multiple legs (and it wouldn't be difficult), but the score-boxes param still wasn't meant to be used in the way you wanted since the tournament was not actually multi-legged. If you don't like parenthesis, RoundN's score processing can tolerate most other characters of your choosing:

	Semi-finals				Final
	5 June – Naples
	Italy (coin toss)	0
					8 June / 10 June – Rome
	Soviet Union	0
					Italy	1 / 2
	5 June – Florence
					Yugoslavia	1 / 0
	Yugoslavia	1
	England	0
					Third place play-off
					8 June – Rome
					England	2
					Soviet Union	0

I will have to find the time to update RoundN's documentation since the score-boxes parameter isn't "officially" available yet. —CodeHydro 14:03, 22 February 2017 (UTC)

@Codehydro: All right thanks, I adjusted the article with the slash. But while maybe this situation is rare, I think it would be a good idea anyways to fix the issue with the third place match when the bracket has multiple legs. Also, why is the score-box parameter not yet "official" yet? S.A. Julio (talk) 00:01, 23 February 2017 (UTC)

• @S.A. Julio: - Sorry it took a year, but I finally got around to fixing this bug. —CodeHydro 17:35, 4 September 2018 (UTC)

Alternate name for Final

@Codehydro Can you add an option to add an alternate name for the Final, similar to |Consol= ? I'd like to change the name of the Final to 'Gold Medal Match' but I can't see a way to do this. 09:04, 21 May 2018 (UTC)

Nevermind, I figured it out. TheBigJagielka (talk) 09:08, 21 May 2018 (UTC)

Code to insert bold tags

I edited Module:RoundN twice. The first was to clean whitespace and remove some of the globals which I assume were unintended. The second was to fix a problem in several articles which were showing Lua error in Module:RoundN at line 282: bad argument #2 to 'format' (no value). The articles follow. These had problems because they have (I think) broken wikitext, namely an odd number of occurrences of ''' (triple apostrophe). Someone familiar with the topic might like to fix them.

• 2015–16 Magyar Kupa (men's handball)
• 2016–17 Magyar Kupa (women's handball)
• 2017–18 Magyar Kupa (women's handball)
• Archery at the 2010 Commonwealth Games – Men's recurve individual
• Fencing at the 1996 Summer Olympics – Men's épée
• Fencing at the 1996 Summer Olympics – Men's foil
• Fencing at the 1996 Summer Olympics – Men's sabre
• Fencing at the 1996 Summer Olympics – Women's épée
• Fencing at the 2008 Summer Olympics – Women's sabre
• Fencing at the 2016 Summer Olympics – Men's sabre
• Fencing at the 2016 Summer Olympics – Women's foil

Re the first edit: I did not fix the following because I couldn't quickly work out what was wanted. They should be investigated. The remaining globals are: fontSize + nonFunc + text (at rowspan = m.r + 9 - rows - (text and 0 or 2),).

Re the second edit: The original had some problems which meant that replacing '''example''' with <b>example</b> was not occurring. When it was attempted (due to broken wikitext in the above articles), the runtime error occurred. The code is quite complex—please check what I did! Johnuniq (talk) 09:13, 14 August 2018 (UTC)

@Johnuniq: Thanks for working on RoundN! I think this was my 3rd Lua module and I am pretty sure I didn't even know that making function local was a thing at the time (FYI, I hadn't even heard of Lua just 6 weeks prior to when I stopped working on RoundN in Jan 2015). I agree that making those functions local sounds like a good idea. As for your changes around the line local hasBold, b = ..., the changes miss the purpose of original, which was to bold text when users enter something like '''text (as opposed to properly closing it with '''text'''). Unclosed bold is works fine in MediaWiki-based templates but doesn't work in Lua-based templates, so those lines were an attempt maintain backwards compatibility. Your edit only affected paired/closed wiki-bold mark-up, which left, for example, left all of the score numbers (33, 40, etc.) unbolded in 2015–16 Magyar Kupa (men's handball)#Final four. That said, non-working bolding is better than the error that was there before, so good job restoring partial functionality while I was MIA :) It's fixed now. —CodeHydro 23:32, 8 September 2018 (UTC)

@Codehydro: It's good code! I monitor script errors and my edits here were, I'm afraid, merely intended to remove those errors. I know nothing about this topic or exactly what the module is supposed to do so I was working in the dark. If you want to support a single occurrence of ''' as valid bolding I suppose that is ok, but my humble opinion is that it would be better to throw an error or put the article in a hidden category so the broken wikitext can be fixed. The purpose of my edit was to remove a problem, but while doing that I chose to only replace ''' if there were exactly two occurrences as a quick workaround. Anyway, that's up to you.

You may not be aware that the global variables I mentioned are almost certainly bugs that need to be fixed. I can explain more if you like, but searching for each will show places where they would give nil as an uninitialized global. I could take a stab at fixing a couple of them but it would take longer than I have to work out the underlying intention regarding what should happen. Johnuniq (talk) 01:30, 9 September 2018 (UTC)

"previewnumbers" do not work

"previewnumbers" do not work, the template claims that match 1 is match 2, match 2 is match 3 and then it continues. Instead, the number 1 ("match 1") is next to the headings. DenSportgladeSkåningen (talk) 18:23, 17 August 2018 (UTC)

• @DenSportgladeSkåningen: fixed —CodeHydro 21:01, 8 September 2018 (UTC)

score-boxes=0 and 3rdplace=yes does not display correctly

The following code combinations do not display correctly:

{{#invoke:RoundN|N8|score-boxes=0|3rdplace=yes}}
{{#invoke:RoundN|N4|score-boxes=0|3rdplace=yes}}

I'm not yet skilled enough with Lua to make the correction myself. Can somebody help? $\color {blue}\chi$_chi (talk) 15:40, 23 August 2018 (UTC)

Pinging @Codehydro and Johnuniq:. $\color {blue}\chi$_chi (talk) 17:12, 25 August 2018 (UTC)

I know nothing about this module and only dropped in to fix an error as mentioned two sections up. I might get time to look but I definitely do not want to spend time working out what the problem is and what is wanted. I would need a very clear explanation of what happens now and what should happen. Also, I'd like to see an example of a working template with results close to what is wanted. I removed the formatting from the section header because it breaks anchors. Johnuniq (talk) 23:38, 25 August 2018 (UTC)

Sorry for the vagueness. Here is my understanding of the problem. score-boxes is used to determine how many cells are needed for the score. For early Olympic wrestling, and perhaps other sports, there was no score at all so I've used score-boxes=0. This works fine except for the 3rd place match of 4- or 8-teams competitions:

	Semi-finals			Final
				Third place

I'm assuming the module is expecting a score for the 3rd place match, so it actually puts the two 3rd-place adversaries side-by-side instead of one over the other. I noticed that this is a problem for Firefox, but not for Edge, which puzzles me even more. $\color {blue}\chi$_chi (talk) 11:07, 27 August 2018 (UTC)

I put an example from above in my sandbox (permalink) showing what HTML is produced by the module. One problem has been identified, namely that different browsers show the results differently. Is there any other problem with the above? I ask because it is not clear to me why empty boxes should be displayed. Are you saying that what Edge shows in my sandbox is what is wanted? Is there an article showing empty boxes? If the only problem is the browser difference, the next step would be to ask at WP:VPT where HTML experts live. Someone would need to say what HTML output should occur before edits to the module can be contemplated. Johnuniq (talk) 00:42, 28 August 2018 (UTC)

• @Johnuniq and Χ: This bug has now been patched. —CodeHydro 17:32, 4 September 2018 (UTC)

• @Codehydro: Thanks. Please also see my earlier post above with "remaining globals". The variables are almost certainly bugs that should be fixed. Johnuniq (talk) 23:11, 4 September 2018 (UTC)

Lines between matches not in line with centre of box

Hi - It appears that the bold lines connecting any two matches starts from either slightly above or below the middle of the box, and then enters slightly above or below the middle of the box it's connecting to. How easy is this to fix? M00036 (talk) 14:40, 7 January 2019 (UTC)

Right to Left Wikis

Hi, everyone. How can I use this module in the right to left WIKIs such as azb.wikipedia.org? I have created a copy of this module in azb but I have a small problem with this module in our wiki and It is the float of the Brackets' connector lines. All the vertical lines have stood on the right side of connectors, and I could not move these lines to the left side of connectors. For example please check here to understand clearly my issue. I am thankful for your guidance: Ziraksima (talk) 11:24, 17 January 2019 (UTC)

I suggest you make a far simpler example in a sandbox with the minimum required to demonstrate the problem. Put the same wikitext (perhaps in English) in a sandbox here, then spell out what the problem is (what text is wrong and what should it be). Once that is available, you might consider asking at WP:VPT because ultimately the question regards the html output by the module. Fixing the module would be easy if it were known what html was required. Johnuniq (talk) 22:35, 17 January 2019 (UTC)

|score-boxes=2+sum don't allow penalties

If you use |score-boxes=2+sum, you don't have the option to add penalties result to the sum box. Alternatively, you can display penalties' result between parenthesis on the second leg box but the sum won't work (e.g. |1 |1 (4) would display 15 on the sum box because 1+14=15).A.Caseiro (talk) 19:43, 23 February 2019 (UTC)

• @A.Caseiro: Automatic sum is meant for simple numbers. Just use score-boxes=3 and do the math manually, e.g. |1 |1 (4)|6. If you want a different width sum box then use something like score-width=30;30;50 —CodeHydro 03:38, 14 May 2019 (UTC)

Issue with first match byes

If the top match in the first round is a bye, there is a larger than normal spacing between the top of the knock-out bracket and the round descriptors...M00036 (talk) 14:48, 11 March 2019 (UTC)

• @M00036: Example? —CodeHydro 03:27, 14 May 2019 (UTC)

• @Codehydro:

Cambs. & Hunts. County Knockout

Round 1 Round 2 Semi-Finals Final                             Lloyd Team 39 Joy Team 95   Joy Team 54   Liebeschuetz Team 47 Jackson Team 24   Anderson Team 44 Anderson Team 17   Liebeschuetz Team 94 Tarlow Team 39   Liebeschuetz Team 40 Joy Team Negreanu Team w/o   Heames Team 68   Courtney Team 58 Jacobsberg Team 25   Courtney Team 89 Heames Team 39   Negreanu Team 61 Negreanu Team 61   Galpin Team 50 Negreanu Team 59 May Team 23

M00036 (talk) 07:16, 15 May 2019 (UTC)

@M00036: I edited the above to use flex_tree=yes and added   to all but top one. I also added bold_winner=high because... why do it manually? See edit history —CodeHydro 21:54, 16 May 2019 (UTC)

Bronze match and no final, title "bronze match" is not in place

I created a compilation in Swedish wikipedia about the qualification for the 2017 World Beach Football Championship. But I chose to remove the final, as both finalists are qualified for the World Championship. This means that the title "bronze match" is not in place, see examples here (on svwp). It is the same in English wikipedia, as you can see in my sandbox. DenSportgladeSkåningen (talk) 12:37, 16 April 2019 (UTC)

Is that related to this module? I can see Module:RoundN is used in your sandbox but what makes you think this module is a problem? Johnuniq (talk) 03:38, 17 April 2019 (UTC)

It is exactly the same module. But since you are rude, just forget it. I create a custom template for this purpose in Swedish wikipedia instead. DenSportgladeSkåningen (talk) 11:08, 17 April 2019 (UTC)

Sorry, I was only trying to be helpful. However, my comment was mistaken because I forgot what this page is about (I'm watching it after fixing a couple of errors in August 2018). There is a recent proposal to merge certain modules that I am interested in, modules which round numbers to a specified number of decimal places. I'm afraid I thought I was commenting regarding one of those. Total confusion. Johnuniq (talk) 11:27, 17 April 2019 (UTC)

* @DenSportgladeSkåningen: You can use Module:RoundN's undocumented node_function feature: Semifinaler Bronsmatch             B1 Brazil 7 A2 Argentina 1 A2 Argentina 4 (0)   B2 Ecuador (p) 4 (1) A1 Paraguay (a.e.t.) 5 B2 Ecuador 3 —CodeHydro 03:20, 14 May 2019 (UTC)