Template talk:Wikidata revenue

Expression error[edit]

@Underlying lk and Thayts: GM-AvtoVAZ is currently showing several "Expression error: Unexpected < operator" in the infobox due to unexplained removal of data from Lada Zapad Tolyatti (Q1346). Is there a good way of handling this? Is it reasonably achievable for the template to at least show the real reason, namely that Wikidata is fubared again. Should it and can it show nothing if the Wikidata item is empty/nonexistent? To see the problem, edit the article and replace all the content with {{wikidata revenue|revenue|USD}} but do not save. Previewing shows the error. Johnuniq (talk) 03:50, 14 May 2020 (UTC)[reply]

@Johnuniq: I've applied a quick fix to suppress the errors. The logic of this template in general does not seem to be correct and I'm not sure if it gives any good result anywhere (e.g. if you try your example at Boeing then you don't get the desired result). For example, this piece of code does not make sense:

{{wd|property|eid={{wd|property|unit|raw|{{#switch: {{{1|}}}
   | revenue = P2139
   | operating_income = P3362
   | net_income = P2295
   | assets = P2403
   | equity = P2137
   | aum = P4103
   }} |P558}}|P17}}

Thayts ••• 18:35, 14 May 2020 (UTC)[reply]

Thanks. I haven't got the energy to examine the issue any more at the moment. Johnuniq (talk) 23:18, 14 May 2020 (UTC)[reply]

The bottom line here is that this template does not work gracefully when there is no Wikidata to be retrieved. It should return nothing (null) so that the infobox displays nothing, as if no value for the parameter was specified. This is complicated to do in a template, because of the assumptions that numbers are returned, and the need to handle negative numbers differently, so this is probably something that would best be converted to a Lua module. In lieu of suppressing errors, I'm just going to remove the attempts to get Wikidata that isn't there.

The burden should be on Wikidata promoters to make this work; they shouldn't be forcing WIkipedia editors to work for them by pushing half-implemented solutions on us. – wbm1058 (talk) 22:12, 11 January 2021 (UTC)[reply]

I totally agree and I have written several times that Wikidata is a write-only database: it's great for people to store factoids but it's useless for people who want to conveniently and reliably retrieve useful information. Johnuniq (talk) 04:01, 15 June 2021 (UTC)[reply]

USD converting failed[edit]

Hi, dear creators of that great template. Thank you for your contribution.

I've found, that converting to USD doesn't work for now.

For example, in {{{Tatneft}}} page {wikidata revenue|revenue|USD} returns NaN, but it correctly works in case of native currency. {wikidata revenue|revenue|num} returns 932 billion.

Is it possible to fix this issue?

Great thanks in advance! MiklMS (talk) 11:37, 2 July 2020 (UTC)[reply]

Anyone feel like a quick fix?[edit]

There is another Wikidata snafu at Renault Russia due to unexplained changes at Renault Russia (Q768353). I'm hoping someone will make a quick fix, either to revert at Wikidata or remove the broken wikitext in the article. Johnuniq (talk) 04:02, 15 June 2021 (UTC)[reply]