Wikipedia:Bots/Requests for approval/MalnadachBot

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard. The result of the discussion was

Approved.

MalnadachBot[edit]

Operator: ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 08:40, Monday, May 17, 2021 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): AutoWikiBrowser

Source code available: AWB, replacement strings are posted in User:MalnadachBot/Task 1

Function overview: Fixes high priority Lint error, Old behaviour of link-wrapping font tags caused due to specific user signatures in discussion pages because of change from HTML Tidy to RemexHTML. Also fix signature of Cyberbot II which interferes with syntax highlighting.

Links to relevant discussions (where appropriate): Wikipedia:Bots/Requests for approval/Ahechtbot, Wikipedia:Bots/Requests for approval/Galobot, Wikipedia:Bots/Requests for approval/NihlusBOT 2. These are similar bot approvals for fixing high priority Lint errors.

Edit period(s): One time run

Estimated number of pages affected: approximately ~~22,500~~ 106,000

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): No

Function details: Find and replace specific strings of text that are causing Old behaviour of link-wrapping font tags Lint error, which is a high priority Lint error. At the same time, convert ... tags in the signature to ... with CSS, since font tag is obsolete now. This also fixes obsolete html tag Lint error, a low priority Lint error. So replacing one signature will eliminate two types of Lint errors at the same time.

The signature strings that will be replaced are listed at User:MalnadachBot/Task 1. All of the users have either changed their signature or are no longer active on Wikipedia, so a one time run is sufficient. All edits will be marked as "minor".

AWB permission is requested for User:MalnadachBot, as well as the Bot flag to avoid triggering notifications when editing user talk pages. I have been replacing signatures in Template and File namespace using a script. I am requesting this bot approval so that I can cleanup High priority Lint errors quicker and in a larger scale across namespaces. Additional task requests will be created if new replacement strings are to be added.

Updated to note that I have included the signature of Cyberbot II per discussion below. This signature gives two missing end Lint errors and interferes with page syntax highlighting. 83,500 pages have this signature and needs to be fixed.

Discussion[edit]

I recommend fixing other easy-to-fix obsolete font tags while the bot is visiting the page, using a general-purpose set of regexes that replace font tags with appropriate span tags. – Jonesey95 (talk) 15:07, 17 May 2021 (UTC)[reply]

I would love to do that if anyone can give me good, safe general purpose regexes to replace font tags. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 15:27, 17 May 2021 (UTC)[reply]

Try these. It's only doing those with just the color param. More needs if face param included. Have a test and see if they do what you need. I've only listed ones for the "Misnested tag with different rendering in HTML5 and HTML4" lint error. -- WOSlinker (talk) 21:01, 17 May 2021 (UTC)[reply]

 *\[\[([^\|^\]]*)\|([^\|^\]]*)\]\] *\<\/font\> with [[$2|$3]]
 *\[\[([^\|^\]]*)\|([^\|^\]]*)\]\] *\<\/font\> with [[$2|$3]]
 *\[\[([^\|^\]]*)\|([^\|^\]]*)\]\] *\<\/font\> with [[$2|$3]]
 *\[\[([^\|^\]]*)\|([^\|^\]]*)\]\] *\<\/font\> with [[$2|$3]]
 *\[\[([^\|^\]]*)\|([^\|^\]]*)\]\] *\<\/font\> with [[$2|$3]]
 *\[\[([^\|^\]]*)\]\] *\<\/font\> with [[$2|$2]]
 *\[\[([^\|^\]]*)\]\] *\<\/font\> with [[$2|$2]]
 *\[\[([^\|^\]]*)\]\] *\<\/font\> with [[$2|$2]]
 *\[\[([^\|^\]]*)\]\] *\<\/font\> with [[$2|$2]]
 *\[\[([^\|^\]]*)\]\] *\<\/font\> with [[$2|$2]]

WOSlinker, these do not seem to catch html 4/5 misnesting error. I have built some signatures in User:ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ/sandbox (permalink) to match the regexes. They are showing "Old behaviour of link-wrapping font tags" and "Obsolete html tags" errors.

The regexes did work correctly for ones I put in straightforward cases section. However some users have wrong signatures, like that of User:Skomorokh which I am going to fix with this task. [[User talk:Skomorokh|скоморохъ]] was wrongly replaced as [[User talk:Skomorokh|скоморохъ]]. Besides font face and size params, ~~it also didn't work for color params without double quotes and those with extra white spaces~~. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 06:27, 19 May 2021 (UTC)[reply]

I've updated them to handle added spaces and cases where there are quotes and without quotes. Additional ones would be needed to handle tags with face and size params. -- WOSlinker (talk) 08:15, 19 May 2021 (UTC)[reply]

ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ, I've added support for face params now and all the regexes are in User:WOSlinker/fontlinks.js -- WOSlinker (talk) 11:01, 19 May 2021 (UTC)[reply]

I tested this script. It does work for color and face params. The issue with another font tag inside the link like User:Skomorokh's signature still remains. Already the script has 30 regexes. If we try to include regexes for size param combinations, it goes to over 100. That still leaves font inside lint and other unforeseen circumstances. I don't know what is the maximum number of regexes that can be used at a time in AWB, but this is complicated for me. I feel these general regexes work great for supervised runs but not for fully automatic. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 13:32, 19 May 2021 (UTC)[reply]

Comment: an insource search tells me that there are 140,000 of these Cyberbot sigs across all namespaces. There are two Linter errors in each erroneous signature. Jonesey95 (talk) 05:36, 19 May 2021 (UTC)[reply]

I can do this in second task. Considering the large number of pages with Cyberbot signs, BAG may hesitate to approve now since this is my first BRFA. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 06:37, 19 May 2021 (UTC)[reply]

I don't see why adding in extra parameters, while the current task is under discussion, is not allowed. If you can add in another fix to this run, feel free to include/add it. Primefac (talk) 17:30, 19 May 2021 (UTC)[reply]

Thank you. I have added the signature of Cyberbot II. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 06:22, 20 May 2021 (UTC)[reply]

Approved for trial (80 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Please do 10 of each signature. Whether or not you include general font error fixes is up to you, though if you do so please be sure to include that disclaimer in the edit summary. Primefac (talk) 12:42, 25 May 2021 (UTC)[reply]

@Primefac: MalnadachBot does not have AWB enabled, can you please enable it and assign (temporary) bot flag? ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 05:45, 26 May 2021 (UTC)[reply]

Added to AWB, will add the bot flag if the task is approved. Primefac (talk) 10:36, 26 May 2021 (UTC)[reply]

Trial complete. 10 for each signature. Result diffs -

I have decided to not include general font fixes for this task since the error rate is high for fully automated runs. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 07:42, 27 May 2021 (UTC)[reply]

Approved. Primefac (talk) 11:33, 31 May 2021 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard.