Template talk:Jockey colours header

Template:Jockey colours header is permanently protected from editing because it is a heavily used or highly visible template. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit. Any contributor may edit the template's sandbox. Functionality of the template can be checked using test cases.

Template-protected edit request on 6 June 2022

This edit request to Template:Jockey colours header, Template:Jockey colours collapsible header and Template:Jockey colours named collapsible header has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

I would like to replace the content of this template with the content of a new template: Jockey_colours_mobile_header The effect of this change is to remove the Jockey Silks images from the mobile display, as the collapse feature that is used on the standard page is deactivated on mobile pages and the fully expanded content takes up too much room on a small screen. Similar replacements are required for: Jockey_colours_collapsible_header -> Jockey_colours_mobile_collapsible_header Jockey_colours_named_collapsible_header -> Jockey_colours_mobile_named_collapsible_header JockeyColours (talk) 19:24, 6 June 2022 (UTC)[reply]

Note: {{Jockey colours collapsible header}} and {{Jockey colours named collapsible header}} are not template-protected, they are semi-protected. The mobile templates are unprotected. P.I. Ellsworth , ed. ^put'r there 08:34, 9 June 2022 (UTC)[reply]

Not done: it's not clear what changes you want to be made. Please mention the specific changes in a "change X to Y" format and provide a reliable source if appropriate. There is no reason to create a new template if we can just edit this one to make it better. Please put your new code in this template's sandbox, and demonstrate the difference on the testcases page or on your user sandbox. – Jonesey95 (talk) 00:45, 7 June 2022 (UTC)[reply]

It is also unclear why there are so many variants of this template when the differences between them are so small. It seems that they could be merged pretty easily. – Jonesey95 (talk) 00:51, 7 June 2022 (UTC)[reply]

Thanks for your reply. Hopefully the instructions below will clarify:

Changes to this template are as follows:

add include for Jockey colours mobile/styles.css stylesheet via templatestyles call:
add class="JockeyColours" to the row definition

For the other header templates only the JockeyColours class needs to be added, as the stylesheet will always be included on the page via the standard header template.

The three header templates are as follows:

Jockey_colours_header: overall header - not collapsible
Jockey_colours_collapsible_header: collapsible header with text "Previous years"
Jockey_colours_named_collapsible_header: collapsible header with text passed (usually a range of years e.g. 2020–2011)

The second and third could certainly be combined, but it would be a little more difficult to use, and a lot of pages would need editing as a result, so perhaps best left as it is? JockeyColours (talk)

I have created {{Jockey colours header/sandbox}} and {{Jockey colours header/testcases}} for you. Please use them, as requested above. – Jonesey95 (talk) 13:25, 7 June 2022 (UTC)[reply]

Thanks. I have updated sandboxes for the three templates and referenced all of them from the testcases for this template. The testcases page displays as desired with images from the sandbox templates no longer visible when accessed using a mobile phone.JockeyColours (talk)

Hello everyone. What needs to be done to move forward on this? JockeyColours (talk)

Well, it would help if you would include a timestamp with your signature by using four tildes (~~~~) instead of just three tildes. Other than that, your sandboxed edits have been completed. P.I. Ellsworth , ed. ^put'r there 14:37, 25 June 2022 (UTC)[reply]