Template talk:Football squad player: Difference between revisions
→The header: new section |
→Right, we've cracked it: done |
||
Line 84: | Line 84: | ||
===Right, we've cracked it=== |
===Right, we've cracked it=== |
||
{{editprotected}} |
{{tlx|editprotected}} |
||
I'm filing this request on one page for the conveniece of the admin, but for procedural reasons will place {{tl|editprotected}} on the other pages. I recommend making the edits in the order I have specified. In particular, it is vital that {{tl|Football squad player}} is edited '''last'''. |
I'm filing this request on one page for the conveniece of the admin, but for procedural reasons will place {{tl|editprotected}} on the other pages. I recommend making the edits in the order I have specified. In particular, it is vital that {{tl|Football squad player}} is edited '''last'''. |
||
Line 108: | Line 108: | ||
I hope you don't mind. I've moved the sandboxes and testcases to their proper places. I've also made a couple of other tweaks as well. Can you check if all is in order and I will make the changes. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:47, 22 July 2010 (UTC) |
I hope you don't mind. I've moved the sandboxes and testcases to their proper places. I've also made a couple of other tweaks as well. Can you check if all is in order and I will make the changes. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:47, 22 July 2010 (UTC) |
||
:For the life of me I can't figure out what the extra <nowiki>|}</nowiki> you removed was for, but I've tested at length and everything seems fine. We look good to go. --[[User:WFCforLife|W]][[User talk:WFCforLife|F]][[Special:Contributions/WFCforLife|C]]-- 20:52, 22 July 2010 (UTC) |
:For the life of me I can't figure out what the extra <nowiki>|}</nowiki> you removed was for, but I've tested at length and everything seems fine. We look good to go. --[[User:WFCforLife|W]][[User talk:WFCforLife|F]][[Special:Contributions/WFCforLife|C]]-- 20:52, 22 July 2010 (UTC) |
||
::{{done|all done}}. Let me know if they are any problems. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:38, 22 July 2010 (UTC) |
|||
== Use in basketball team articles == |
== Use in basketball team articles == |
Revision as of 22:38, 22 July 2010
Template:Football squad player is permanently protected from editing because it is a heavily used or highly visible template. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit. Usually, any contributor may edit the template's documentation to add usage notes or categories.
Any contributor may edit the template's sandbox. Functionality of the template can be checked using test cases. |
|
||
New template: {{cc3}}
I guess this can be used here. –Howard the Duck 05:46, 4 June 2009 (UTC)
- Sincerely, seeing a South African footballer being listed as "(RSA) Player Name" seems quite pointless to me, average readers hardly know RSA actually means South Africa, flags are definitely more recognizable in that case. --Angelo (talk) 07:13, 4 June 2009 (UTC)
Date of birth column
Can somebody add a date of birth column? — Preceding unsigned comment added by TheBigJagielka (talk • contribs)
Change as per Wikipedia_talk:WikiProject_Football#Just_to_be_clear
{{editprotect}}
Copy code from User:Gnevin/sandbox5 Gnevin (talk) 17:28, 15 January 2010 (UTC)
- (I'm not an admin). To be clear, what does the code in that sandbox do? It's difficult to tell. WFCforLife (talk) 17:33, 15 January 2010 (UTC)
- Yes, please could you clarify, thanks. — Martin (MSGJ · talk) 18:01, 15 January 2010 (UTC)
- It add a field called ref beside the flag as per the discussion, this change needs to be carried out at the same time as the change to Template:Football squad start which add a note about the flag field and makes some spacing changes Gnevin (talk) 21:44, 15 January 2010 (UTC)
- Sorry, have wrong code in the sandbox. That was a rejected idea to hide the flag when ref wasn't there. I've fixed this now to just add a ref tag beside the flag Gnevin (talk) 21:52, 15 January 2010 (UTC)
- It add a field called ref beside the flag as per the discussion, this change needs to be carried out at the same time as the change to Template:Football squad start which add a note about the flag field and makes some spacing changes Gnevin (talk) 21:44, 15 January 2010 (UTC)
- Yes, please could you clarify, thanks. — Martin (MSGJ · talk) 18:01, 15 January 2010 (UTC)
- Done Ronhjones (Talk) 22:24, 15 January 2010 (UTC)
{{editprotect}}
Change to Template:Football squad player/sandbox to fix issue caused by changed fs start Gnevin (talk) 01:48, 16 January 2010 (UTC)
- Never mind pointless user can just add a ref Gnevin (talk) 01:57, 16 January 2010 (UTC)
{{editprotect}}
Please revert this change as it relied on a change to fs start which has been removed Gnevin (talk) 02:04, 16 January 2010 (UTC)
Done changed to same as Template:Football squad player/sandbox Ronhjones (Talk) 14:12, 16 January 2010 (UTC)
Country names
I think that the name of the country need to be placed next to the flag of the players' nationalities, i.e. use the {{flag}} template instead of {{flagicon}}. Using just the flag without the name of the country assumes the reader has the knowledge and the ability to recognise the flag, which may not necessarily be the case, and even if a reader does know their flags they can be difficult to distinguish at the size they are displayed here. The various blue ensigns in use around the world can cause particular difficulty, not to mention pairs of countries like Indonesia/Monaco which have identical flags, or the various combinations of the pan-african colours.
There needs to be some sort of clever wizardry to make sure that the output is Central African Republic, rather than CAF, when the three-letter ISO code has been used with the 'nat=' parameter instead of the full country name. — Gasheadsteve Talk to me 13:27, 25 March 2010 (UTC)
- That would indeed adress an abuse of WP:FLAG perpetuated in this template, but there are many other issues about the inclusion of flags that are not well resolved at present, like why are they considered relevant at all, especially for the vast majority of players who are nowhere near consideration for a national team; the false impression given about players who have played under what is not much more than a flag of convenience; presentation of incomplete information about players of multiple nationality or otherwise eligible for more than one team; and lack of verification. I would suggest holding fire until some or all of those have been resolved. Kevin McE (talk) 16:05, 30 March 2010 (UTC)
- @Gasheadsteve: No clever wizardry required; use
{{flagcountry|CAF}}
to get Central African Republic. — Andrwsc (talk · contribs) 20:28, 30 March 2010 (UTC)
Per above and Wikipedia:Manual of Style (icons)#Accompany flags with country names,
{{editprotect}}
For {{fs player}}
, change
| style="text-align: right;" |{{flagicon|{{{nat}}}|variant={{{natvar|}}}}}
to
| style="text-align: left;" |{{#if: {{{icononly|}}} | {{#ifeq: {{{icononly|}}} | yes | {{flagicon|{{{nat}}}|variant={{{natvar|}}}}} | {{flagcountry|{{{nat}}}|variant={{{natvar|}}}}} }} | {{flagcountry|{{{nat}}}|variant={{{natvar|}}}}} }}
(Per discussion below) also change for {{fs start}}
!width=1%|No.
!width=1%|
!width=1%|Position
to
!width=1%|No.
!width=22%|Nationality
!width=1%|Position
This incoporates a new parameter—"icononly". If "icononly" is empty (default) or not "yes", the country name will be shown. To show only the flag icon, simply add the parameter "icononly=yes". The default case complies with Wikipedia:Manual of Style (icons)#Accompany flags with country names, and having lists with names besides all the flags is still compliant with the guidelines. Any other sort of scheme as default goes against MOSFLAG. Jappalang (talk) 22:05, 19 July 2010 (UTC)
:I request that this is declined until discussion has taken place at WT:FOOTY. Regards, --WFC (talk) 22:10, 19 July 2010 (UTC)
- Sorry, I think I may have misunderstood what is being requested. Could you expand on what this would do? --WFC (talk) 22:12, 19 July 2010 (UTC)
- MOS is clear on one thing; when you first use a flag, put the name next to it.
- This change will make it such that the use of
{{fs player}}
will have the country name displayed next to the flag on default. - To disable the name (for subsequent repetition of the flag), just use "icononly=yes".
- The change will make display of a country name next to the flag a default. A new parameter is added to allow users to turn off the display of a country name next to the flag. The flags are always there in either case. Jappalang (talk) 22:48, 19 July 2010 (UTC)
- I'm not against following MOS:ICON in this regard. It's long overdue. But I think mandating a key would be a better solution. Otherwise all we are doing is taking an aspect of football squad lists that has consensus but is controversial (a player's nationality), and emphasising it further. By mandating a key (perhaps even encoding one into {{Fs start}} or {{Fs end}}) we could communicate the information without it dominating the table itself. Regards--WFC (talk) 23:04, 19 July 2010 (UTC)
- I am not certain putting the name is further emphasis when the graphic draws attention to itself like a candle in the dark (somewhat like "Ooo, a pretty flag... not sure which country it is? There is no name... do I click it to find out? Here goes.") A key (legend) is indeed an alternative, but it does not need to be implemented in the templates (it can be implemented as a separate table before the other lists and such). No article, however, has taken the initiative to (or perhaps is prohibited from) do so. Jappalang (talk) 23:20, 19 July 2010 (UTC)
- With regards to removing flags altogether, it's been tried, failed, and I doubt the outcome of any future attempt would be any different. is against the MoS, I accept that. But England is more prominent. Similarly, the large spaces left by only expanding a country on first use would also be more prominent than a uniform width.
- I am not certain putting the name is further emphasis when the graphic draws attention to itself like a candle in the dark (somewhat like "Ooo, a pretty flag... not sure which country it is? There is no name... do I click it to find out? Here goes.") A key (legend) is indeed an alternative, but it does not need to be implemented in the templates (it can be implemented as a separate table before the other lists and such). No article, however, has taken the initiative to (or perhaps is prohibited from) do so. Jappalang (talk) 23:20, 19 July 2010 (UTC)
- I'm not against following MOS:ICON in this regard. It's long overdue. But I think mandating a key would be a better solution. Otherwise all we are doing is taking an aspect of football squad lists that has consensus but is controversial (a player's nationality), and emphasising it further. By mandating a key (perhaps even encoding one into {{Fs start}} or {{Fs end}}) we could communicate the information without it dominating the table itself. Regards--WFC (talk) 23:04, 19 July 2010 (UTC)
- In my defence, I did try to take the initiative with Watford (and another article, can't remember where but it will be in my contribution history). Neither stood the test of time. --WFC (talk) 23:34, 19 July 2010 (UTC)
- How about keeping a format very similar to the current style; having columns "Number", "Nationality", "Position", "Player", "Notes". Instead of a flag for nationality, have a flag and the full country name. And to amend for the obvious extended width this would create, have the list run in just one column, rather than the two it currently uses. 91.106.96.171 (talk) 23:49, 19 July 2010 (UTC)
- I agree that a column is needed. Beyond a slight preference for a key on whitespace grounds (USA vs Democratic Republic of Congo) I'd be happy with either solution. If the second method were used, a bot would need to remove {{Football squad mid}} from every article before the change were implemented. --WFC (talk) 00:02, 20 July 2010 (UTC)
- How about keeping a format very similar to the current style; having columns "Number", "Nationality", "Position", "Player", "Notes". Instead of a flag for nationality, have a flag and the full country name. And to amend for the obvious extended width this would create, have the list run in just one column, rather than the two it currently uses. 91.106.96.171 (talk) 23:49, 19 July 2010 (UTC)
- I hear ye, WFCforLife; my point is what you experienced: you were "prohibited from" doing so. You had implemented your key on 21 December 2009, but was later undone a month later by a User:JoeA2580, who removed the key without even an edit summary.[1] There is a faction that insists on having "pretty" layouts without care for others with visual disabilities (colour-blindness or such) or unfamiliarity with flags. Regardless, to make it clear, this proposal has naught to do with removal of flags.
- User:91.106.96.171, this proposal does what you ask, it will place a country name next to the flag (by default). So can I take it that you and WFCforLife are agreeable to my suggested change to this template? Jappalang (talk) 05:11, 20 July 2010 (UTC)
- If accompanied by an edit to {{Football squad start}} to add a nationality column, I'm happy with that. We can always consider the possibility of changing to a key later, if desired. Thanks for your patience. --WFC-- 05:20, 20 July 2010 (UTC)
- No problems. The Nationality column has always been there; it just does not have a column title. If this change goes through, I will proceed to
{{fs start}}
to ask for the title to be implemented and the column's width extended from 1% to at least 22%. Jappalang (talk) 05:32, 20 July 2010 (UTC)- Thats cool. Might be worth asking the admin to do them simultaneously though. A width of 1% might render strangely combined with expanded country names. --WFC-- 05:53, 20 July 2010 (UTC)
- Okay, I put up the suggestion above. I also changed the suggested "icon" parameter to "icononly" to make it less confusing to users. Let us see if an admin is willing to do this. Jappalang (talk) 20:20, 20 July 2010 (UTC)
- Looks good. Nice work! --WFC-- 20:42, 20 July 2010 (UTC)
- This looks hideously complicated, but that's just me. Has this been tested to ensure that it works? If so, could you copy the code to the template's sandbox so I can just copy and paste it, then stick the template back up. Thanks, HJ Mitchell | Penny for your thoughts? 01:54, 21 July 2010 (UTC)
- Looks good. Nice work! --WFC-- 20:42, 20 July 2010 (UTC)
- Okay, I put up the suggestion above. I also changed the suggested "icon" parameter to "icononly" to make it less confusing to users. Let us see if an admin is willing to do this. Jappalang (talk) 20:20, 20 July 2010 (UTC)
- Thats cool. Might be worth asking the admin to do them simultaneously though. A width of 1% might render strangely combined with expanded country names. --WFC-- 05:53, 20 July 2010 (UTC)
- No problems. The Nationality column has always been there; it just does not have a column title. If this change goes through, I will proceed to
- If accompanied by an edit to {{Football squad start}} to add a nationality column, I'm happy with that. We can always consider the possibility of changing to a key later, if desired. Thanks for your patience. --WFC-- 05:20, 20 July 2010 (UTC)
- User:91.106.96.171, this proposal does what you ask, it will place a country name next to the flag (by default). So can I take it that you and WFCforLife are agreeable to my suggested change to this template? Jappalang (talk) 05:11, 20 July 2010 (UTC)
This will get even more complicated, as an edit will also need to be made to {{fs mid}}, unless a bot is going to mass-remove it. I've done some work, and the current state of play can be seen here. The player name field might prove to be a bit narrow (particularly for Eastern Europe), and we need to figure out a way to get Northern Ireland to render properly without compromising any further on player names. Once that conundrum is sorted I'll let you know. --WFC-- 02:33, 21 July 2010 (UTC)
Right, we've cracked it
{{editprotected}}
I'm filing this request on one page for the conveniece of the admin, but for procedural reasons will place {{editprotected}} on the other pages. I recommend making the edits in the order I have specified. In particular, it is vital that {{Football squad player}} is edited last.
These changes achieve two major things:
- 1. Ensuring that the template can comply with MOS:FLAG, by displaying the country name alongside the flag by default.
- 2. If country names have been spelt out in a previous table or a key, it is possible for the user to display flag icons only by using the new |icononly parameter.
Please:
- Replace the code in {{Football squad start}} with the code from {{Football squad start/sandbox}}
- Replace the code from {{Football squad mid}} with the code from {{Football squad mid/sandbox}}
- Replace the code from {{Football squad player}} with the code from {{Football squad player/sandbox}}
The combined effect of these changes can be seen at Template:Football squad player/testcases
Please credit User:Jappalang in the edit summary, as he has done much of the work. He indicated his approval for me to proceed with this request here. I now consider myself to have a very good understanding of the source code, so feel free to contact me with any queries. I also have this page watchlisted if you'd prefer to keep the discussion in one place. Regards, --WFC-- 01:10, 22 July 2010 (UTC)
- Wish I had been aware that this conversation was going on, but I guess that's my fault for having not put it on my watchlist after I had contributed in the early discussion.
- I'd support it, but I would suspect mass revolt when it is rolled out: large amounts of white space won't go down well. Many team articles still list players on loan as an "other" section in fs mid: what would happen to such notes, and will it make very wide columns even more common?
- My other reservation is that it might be seen to confirm the current header. FIFA eligibility rules do not allocate one nationality to every player in the workd, they simply indicate what will, and therefore what will not, be permitted if a national association wishes to name a player to its team. If Brazil were to decide that their World Cup campiagn would have gone better had they had a short-sighted overweight 47 year old with experience of playing at right back in the heights of inter-seminary football tournaments among their squad, FIFA would have told Dunga that I was not available to them, but FIFA has no opinion as to whether I am English, Irish or Northern Irish, nor does it have eligibiilty rules that would create any default position or order of preference between my potential eligibilities. The current header is factually wrong in that regard. Kevin McE (talk) 08:13, 22 July 2010 (UTC)
- I haven't changed the header. I request that you move that comment to another section so as not to complicate the matter. --WFC-- 09:02, 22 July 2010 (UTC)
I hope you don't mind. I've moved the sandboxes and testcases to their proper places. I've also made a couple of other tweaks as well. Can you check if all is in order and I will make the changes. — Martin (MSGJ · talk) 12:47, 22 July 2010 (UTC)
- For the life of me I can't figure out what the extra |} you removed was for, but I've tested at length and everything seems fine. We look good to go. --WFC-- 20:52, 22 July 2010 (UTC)
- all done. Let me know if they are any problems. — Martin (MSGJ · talk) 22:38, 22 July 2010 (UTC)
Use in basketball team articles
I noticed something while looking at the article for Olympiacos B.C. I've noticed it in some other articles, but this one made me decide to post.
The "Football squad" template is being used to list players transferring in and out of a team. Only one problem with its use in basketball articles: the "Football squad start" specifically references FIFA. For basketball, the correct governing body is FIBA. For basketball, the text should read (I'm correcting the text for clarity):
- Note: Flags indicate national team as has been defined under [[International Basketball Federation|FIBA]] eligibility rules. Players may hold one or more more non-FIBA nationalities.
Think someone can fix this issue? Simplest way I see is to create a basketball version, though it might be a good idea to run it by WikiProject Basketball first. — Dale Arnett (talk) 05:54, 8 May 2010 (UTC)
- Seeing as this template was made for football squads (hence the name), I suggest making a basketball version, or not using it at all for that purpose. Digirami (talk) 21:22, 20 July 2010 (UTC)
- ...or, instead of criticising people for wanting to adapt a good thing, we could do this. --WFC-- 21:32, 20 July 2010 (UTC)
Multiple Positions
What if a player is frequently played in more then one position e.g. Defender and Midfielder, and a primary position cannot be distinguished? Is it possible to input two positions successfully? Half Price (talk) 14:49, 25 May 2010 (UTC)
- No, in that case just refer to the one position listed in the team website or, alternatively, to the one he is mostly used to. --Angelo (talk) 14:59, 25 May 2010 (UTC)
- Thanks. Much appreciated. --Half Price (talk) 16:27, 25 May 2010 (UTC)
The header
My other reservation is that it might be seen to confirm the current header. FIFA eligibility rules do not allocate one nationality to every player in the workd, they simply indicate what will, and therefore what will not, be permitted if a national association wishes to name a player to its team. If Brazil were to decide that their World Cup campiagn would have gone better had they had a short-sighted overweight 47 year old with experience of playing at right back in the heights of inter-seminary football tournaments among their squad, FIFA would have told Dunga that I was not available to them, but FIFA has no opinion as to whether I am English, Irish or Northern Irish, nor does it have eligibiilty rules that would create any default position or order of preference between my potential eligibilities. The current header is factually wrong in that regard. Kevin McE (talk) 9:13 am, Today (UTC+1)
I'd just like to reassure editors that I am in no way endorsing the wording of the current header; I'm not happy with it either. The simple fact of the matter is that I did not want the changes I was introducing to be undermined by another discussion on a matter that has previously not achieved consensus. If there is any possibility of changing it I will be absolutely delighted, but the header does not affect the changes I have proposed, or vice-versa. Regards, --WFC-- 20:59, 22 July 2010 (UTC)