Template talk:Did you know review

Why isn't "Good to go." appearing automatically when I substitute this?--Launchballer 23:36, 26 July 2016 (UTC)

Are you sure you didn't fix the issue, whatever it was, yourself? If the problem persists, please be a little more explicit; putting {{subst:Did you know review}} on my sandbox gave exactly the result I expected in the preview, including "Good to go." (Didn't bother to actually save it.) Huon (talk) 00:42, 27 July 2016 (UTC)

Sorry, that wasn't clear but I just placed {{subst:Did you know review|14=1|10=u}} on Template:Did you know nominations/Marriage of Billie Ert and Antonio Molina and it didn't include that phrase.--Launchballer 00:46, 27 July 2016 (UTC)

I'd advise some work on making the template more easily readable, for example by adding line breaks. Also, moving the documentation to its own sub-page may help. The issue was caused by this code:

{{<includeonly>subst:</includeonly>#ifeq:{{{10|}}}|u|{{{12|}}}|{{{12|}}} {{<includeonly>subst:</includeonly>#if:{{{16|}}}|{{{16}}}|{{<includeonly>subst:</includeonly>#if:{{{16|}}}|{{{16}}}|

If parameter 10 is "u", as in your example, that will produce {{{12|}}} and nothing else; only if 10 isn't "u" will you reach the part of the #ifeq where parameter 16, and the possible ending "Good to go", are evaluated. That code should have an "n" instead of "u", so that you don't reach "Good to go." when the image isn't properly licensed. Fixed. Huon (talk) 02:46, 27 July 2016 (UTC)

I always wondered what the point of those was considering that I genuinely find my code easier to read than that of templates that do use line breaks because it's nice and condensed, rather than taking up hundreds of lines (although that's probably due to the way I was taught coding). I'll have it in its subpage immediately.--Launchballer 12:11, 27 July 2016 (UTC)