Wikipedia:Bots/Requests for approval/CitationCleanerBot 3

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

CitationCleanerBot 3

Operator: Headbomb (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 15:38, Wednesday, July 18, 2018 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): WP:AWB

Source code available: In {{cite xxx}}, find \|(\s*)(asin)(\s*)=(\s*)([^\|\}]*) replace with nothing when the citation contains \|(\s*)(isbn)(\s*)=(\s*)([^\s\|\}]+)

Function overview: remove ASIN values when ISBN identifiers are present (per Help:Citation Style 1#Identifiers), plus WP:GENFIXES. E.g. [1].

Links to relevant discussions (where appropriate): Help talk:Citation Style 1#Clearing out ASIN when ISBN is present by bot

Edit period(s): One big run to start, plus occasional runs as amazon links/asins creep up again.

Estimated number of pages affected: ~2000

Namespace(s): Mainspace, Draft, occasionally Wikipedia (manually)

Exclusion compliant (Yes/No): Yes

Function details: remove ASIN values when ISBN identifiers are present. E.g. [2].

Discussion

This looks like a straightforward task to me. It wwill be helpful if the edit summary points to this BRFA. Will the search be case-insensitive so that it correctly catches both |ASIN= and |asin= (and the same for ISBN)? – Jonesey95 (talk) 04:08, 19 July 2018 (UTC)[reply]

It's case insensitive, yes. Headbomb {t · c · p · b} 04:40, 19 July 2018 (UTC)[reply]

Approved for trial (40 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Please report back here with diff range when trial has run. — xaosflux ^Talk 01:55, 21 July 2018 (UTC)[reply]

Trial complete. @Xaosflux: done. See 40 most recent edits. No error to report, although I was operating semi-automatically with slightly more aggressive rules than I'd operate automatically (e.g. it looked inside {{reflist}} / {{quote box}}, etc. when it wouldn't do that during an automated run. This is currently unsafe because of T159958.) However I didn't have to modify anything the bot would not have touched during an automated run. Headbomb {t · c · p · b} 02:40, 21 July 2018 (UTC)[reply]

This one is technically cosmetic, but unavoidable due to the way AWB is coded. Headbomb {t · c · p · b} 02:48, 21 July 2018 (UTC)[reply]

Approved. — xaosflux ^Talk 13:38, 24 July 2018 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.