Wikipedia:Templates for discussion/Log/2024 May 22: Difference between revisions
SilverLocust (talk | contribs) →Template:Edit semi-protected: edit slightly more |
→Template:Edit semi-protected: Update my !vote to explicitly oppose |
||
Line 47: | Line 47: | ||
*::Because I don't think it's possible to merge these without breaking current functionality (as I explain [[#c-SilverLocust-20240601202100-Nickps-20240601162800|below]]), I am changing my comment to an "oppose". (I don't oppose creating a sixth template with no default level that instead would say when the protection level could not be detected, but I oppose redirecting or deleting the five templates proposed for merging.) [[User:SilverLocust|SilverLocust]] [[User talk:SilverLocust|💬]] 20:56, 1 June 2024 (UTC) |
*::Because I don't think it's possible to merge these without breaking current functionality (as I explain [[#c-SilverLocust-20240601202100-Nickps-20240601162800|below]]), I am changing my comment to an "oppose". (I don't oppose creating a sixth template with no default level that instead would say when the protection level could not be detected, but I oppose redirecting or deleting the five templates proposed for merging.) [[User:SilverLocust|SilverLocust]] [[User talk:SilverLocust|💬]] 20:56, 1 June 2024 (UTC) |
||
*'''Comment''' this template set is missing a template for requesting edits that are editfiltered, so autodetection doesn't help, when you need extra rights due to an edit filter instead of page protection. If these are merged, will a switch be available to select a rights level for that situation? -- [[Special:Contributions/65.92.244.237|65.92.244.237]] ([[User talk:65.92.244.237|talk]]) 02:33, 23 May 2024 (UTC) |
*'''Comment''' this template set is missing a template for requesting edits that are editfiltered, so autodetection doesn't help, when you need extra rights due to an edit filter instead of page protection. If these are merged, will a switch be available to select a rights level for that situation? -- [[Special:Contributions/65.92.244.237|65.92.244.237]] ([[User talk:65.92.244.237|talk]]) 02:33, 23 May 2024 (UTC) |
||
* ''' |
* '''Oppose''' Except the last, they're all wrappers for [[Module:Protected edit request]] with slightly different arguments, so in that sense they're already merged. But we should probably keep the slightly different behavior in that {{tl|Edit fully-protected}} should default to fully-protected if the auto-detection fails, {{tl|Edit semi-protected}} to semi-protected, and so on rather than turning them all into redirects to a single wrapper. {{tl|Request edit}} should probably have no default, if that's reasonable. [[User:Anomie|Anomie]][[User talk:Anomie|⚔]] 12:01, 23 May 2024 (UTC) |
||
*'''Weak merge''', now that the last has been struck, keep different behavior defaults if feasible per Anomie. I also agree that with everything already under one-module it really doesn't make that much of a difference. [[Special:Contributions/2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5|2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5]] ([[User talk:2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5|talk]]) 20:30, 24 May 2024 (UTC) |
*'''Weak merge''', now that the last has been struck, keep different behavior defaults if feasible per Anomie. I also agree that with everything already under one-module it really doesn't make that much of a difference. [[Special:Contributions/2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5|2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5]] ([[User talk:2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5|talk]]) 20:30, 24 May 2024 (UTC) |
||
*'''Support merge''' - I do like Anomie's point about the default action Happy Editing--'''[[User:IAmChaos|<span style="color:#000000">IAm</span>]][[User talk:IAmChaos|<span style="color:#0645AD">Chaos</span>]]''' 01:39, 25 May 2024 (UTC) |
*'''Support merge''' - I do like Anomie's point about the default action Happy Editing--'''[[User:IAmChaos|<span style="color:#000000">IAm</span>]][[User talk:IAmChaos|<span style="color:#0645AD">Chaos</span>]]''' 01:39, 25 May 2024 (UTC) |
Revision as of 13:05, 2 June 2024
- The following is an archived discussion concerning one or more templates or modules. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template's talk page or in a deletion review).
The result of the discussion was relisted on 2024 May 29. ✗plicit 23:33, 29 May 2024 (UTC)
- The above is preserved as an archive of the discussion. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template or module's talk page or in a deletion review). No further edits should be made to this section.
- Template:Edit semi-protected (talk · history · transclusions · logs · subpages)
- Template:Edit extended-protected (talk · history · transclusions · logs · subpages)
- Template:Edit template-protected (talk · history · transclusions · logs · subpages)
- Template:Edit fully-protected (talk · history · transclusions · logs · subpages)
- Template:Edit interface-protected (talk · history · transclusions · logs · subpages)
Template:Request edit (talk · history · transclusions · logs · subpages)
Propose merging Template:Edit semi-protected with Template:Request edit.
As I have (surprisingly) recently discovered, this entire family of templates auto-detects the protection level of the template for which the edit request is being made. This means that an {{FPER}} placed on a template-protected template will result in exactly the same thing as a {{TPER}}. Because of this, it seems to me that there is little reason to keep these all as separate templates, instead using the more obvious and reasonably-named {{request edit}} as the base template for this family (instead of the latter template being used as a dab for all five). Primefac (talk) 15:53, 22 May 2024 (UTC)
I have struck {{request edit}} since most of the participants feel it's not well-suited for the final target. Primefac (talk) 13:00, 23 May 2024 (UTC)
- Merge the first five together but keep {{request edit}} as is since COI edit requests are, and need to be, a separate process (a page someone has a COI with can also be protected). * Pppery * it has begun... 16:02, 22 May 2024 (UTC)
- Perhaps a parameter such as
COI=yes
ortype=COI
could be used to flag the type of edit request that is being made, which would allow all six templates to be merged into Template:Request edit. That would still keep them a separate process. Adam Black t • c 16:50, 22 May 2024 (UTC)- Is there any reason to do that, though? It seems to just make things more complicated for everyone. * Pppery * it has begun... 18:30, 22 May 2024 (UTC)
- I don't see how it complicates things, it streamlines the process of requesting an edit. Btw, {{request edit}} has been deprecated, so you're already meant to use a different template - {{edit COI}}. Adam Black t • c 22:27, 23 May 2024 (UTC)
- Is there any reason to do that, though? It seems to just make things more complicated for everyone. * Pppery * it has begun... 18:30, 22 May 2024 (UTC)
- Perhaps a parameter such as
- (edit conflict)Request edit used to be for COI, and it's a generic name that could refer to it or edit partially-blocked as well. Snowmanonahoe (talk · contribs · typos) 16:03, 22 May 2024 (UTC)
- Support Merge (Non-Admin vote) Babysharkboss2 was here!! Dr. Wu is NOT a Doctor! 16:44, 22 May 2024 (UTC)
- Being an admin doesn't mean very much here--there's no need to point out you aren't one. Snowmanonahoe (talk · contribs · typos) 17:00, 22 May 2024 (UTC)
- Merge the first five and keep {{Request edit}} as a disambiguation per Pppery. I was also rather surprised and amused to find out that the edit request templates automatically emulate each other based on the page's protection level. —TechnoSquirrel69 (sigh) 18:37, 22 May 2024 (UTC)
- As no one has suggested a title for the proposed merged template, perhaps {{Edit protected}}? —TechnoSquirrel69 (sigh) 18:48, 22 May 2024 (UTC)
- Should probably have "request" in its name. Gonnym (talk) 19:29, 22 May 2024 (UTC)
- Then maybe {{Protected edit request}} to match the Module it invokes, though I should note that the possibly enticing shortcut {{PER}} is already a template for the Peruvian flag. —TechnoSquirrel69 (sigh) 20:10, 22 May 2024 (UTC)
- Should probably have "request" in its name. Gonnym (talk) 19:29, 22 May 2024 (UTC)
- As no one has suggested a title for the proposed merged template, perhaps {{Edit protected}}? —TechnoSquirrel69 (sigh) 18:48, 22 May 2024 (UTC)
- Merge first five unless there is some yet-to-be-discovered reason to have them separate. Gonnym (talk) 19:30, 22 May 2024 (UTC)
- {{request edit}} needs a new name, since that's not what it does. Other than that, I see no issue with merging the others. Izno (talk) 21:31, 22 May 2024 (UTC)
Comment[Edit: Oppose]: These do not behave identically when the edit request is to an unprotected page. For example, you could use {{Edit extended-protected}} for an article that is within an WP:ARBECR topic area but which has not presently been protected. (If the page is protected, you have to use|force=
to forcea different protection levelthe default protection level specified by the wrapper.) SilverLocust 💬 23:38, 22 May 2024 (UTC)- Need to make sure the force stuff isn't broken, it is needed sometimes. — xaosflux Talk 15:51, 23 May 2024 (UTC)
- Because I don't think it's possible to merge these without breaking current functionality (as I explain below), I am changing my comment to an "oppose". (I don't oppose creating a sixth template with no default level that instead would say when the protection level could not be detected, but I oppose redirecting or deleting the five templates proposed for merging.) SilverLocust 💬 20:56, 1 June 2024 (UTC)
- Need to make sure the force stuff isn't broken, it is needed sometimes. — xaosflux Talk 15:51, 23 May 2024 (UTC)
- Comment this template set is missing a template for requesting edits that are editfiltered, so autodetection doesn't help, when you need extra rights due to an edit filter instead of page protection. If these are merged, will a switch be available to select a rights level for that situation? -- 65.92.244.237 (talk) 02:33, 23 May 2024 (UTC)
- Oppose Except the last, they're all wrappers for Module:Protected edit request with slightly different arguments, so in that sense they're already merged. But we should probably keep the slightly different behavior in that {{Edit fully-protected}} should default to fully-protected if the auto-detection fails, {{Edit semi-protected}} to semi-protected, and so on rather than turning them all into redirects to a single wrapper. {{Request edit}} should probably have no default, if that's reasonable. Anomie⚔ 12:01, 23 May 2024 (UTC)
- Weak merge, now that the last has been struck, keep different behavior defaults if feasible per Anomie. I also agree that with everything already under one-module it really doesn't make that much of a difference. 2601:5CC:8300:A7F0:4CF1:7456:BBC:F8B5 (talk) 20:30, 24 May 2024 (UTC)
- Support merge - I do like Anomie's point about the default action Happy Editing--IAmChaos 01:39, 25 May 2024 (UTC)
- Conditional oppose merge per Anomie. These separate 'templates' are just wrappers for that edit request module really, so not any duplicated template code to worry about. Let's not possibly cause unintended behaviour for a template that's used at least hundreds of times everyday, especially with the auto-detect failover. There are other potential complications like what 65.92.244.237 has written above. Though, consider this vote invalidated if it's possible to merge all of these templates together without changing the behaviour and functionality of these templates. — AP 499D25 (talk) 05:56, 25 May 2024 (UTC)
- Conditional support creating a template with auto-detection, as long as the existing templates are kept per SilverLocust and Anomie. Rusty4321 talk contribs 14:21, 27 May 2024 (UTC)
- Support, but the target should maybe be {{Protected edit request}}. {{Request edit}} may be the destination or redirect to a different merge target, since hatnotes can direct users to more appropriate templates. SWinxy (talk) 23:30, 27 May 2024 (UTC)
- Support the currently-proposed merge of the first five. Agree the final template name should be something like {{Protected edit request}}. Elli (talk | contribs) 13:18, 31 May 2024 (UTC)
- Oppose. WP:ECR doesn't always get applied using WP:ECP. Therefore, using {{Edit extended-protected}} on a page that is not extended confirmed protected makes sense. The autodetection will not be able to handle that case. Add that to the other edge cases described above by other editors and it's clear that this merge will create more problems than in will solve. Nickps (talk) 16:08, 1 June 2024 (UTC)
- Obviously I don't oppose a merge if the current default behavior is retained. Nickps (talk) 16:11, 1 June 2024 (UTC)
- Unless I am mistaken {{EPER}} doesn't currently recognize non-ECP pages that also happen to be under ARBECR. If I am mistaken, then yes, the post-merge template will be able to handle it because no functionality is being lost (just renamed). Primefac (talk) 16:17, 1 June 2024 (UTC)
- Well, I'm going by what Anomie said. If the auto-detection fails, {{EPER}} defaults to ECP. So, while it doesn't recognise that the page is under ARBECR, it still handles the situation correctly. I also just noticed that SilverLocust has already raised this issue. Nickps (talk) 16:28, 1 June 2024 (UTC)
- There would be a loss in current functionality, Primefac. For example,
{{Edit extended-protected|force=yes}}
would no longer work. - Each of the five wrapper templates proposed for merging has a default level. E.g., {{Edit extended-protected}} is
{{#invoke:protected edit request|extended}}
(where the default there isextended
). If the page to be edited is unprotected or if|force=yes
is used, then that default level is used. If these were all redirected to one template, then there would be a loss of functionality unless someone knows how to tell a module not merely which wrapper is invoking a module (since there would only be one merged wrapper), but rather which redirect is being used to transclude the wrapper that invokes the module (and I don't think that is possible). If no default is provided when invoking the module, then it presently breaks with the error message Lua error in Module:Protected_edit_request/active at line 299: attempt to concatenate local 'boxProtectionLevel' (a nil value). when the page is unprotected or|force=yes
is used. SilverLocust 💬 20:21, 1 June 2024 (UTC)
- There would be a loss in current functionality, Primefac. For example,
- Well, I'm going by what Anomie said. If the auto-detection fails, {{EPER}} defaults to ECP. So, while it doesn't recognise that the page is under ARBECR, it still handles the situation correctly. I also just noticed that SilverLocust has already raised this issue. Nickps (talk) 16:28, 1 June 2024 (UTC)
- Unless I am mistaken {{EPER}} doesn't currently recognize non-ECP pages that also happen to be under ARBECR. If I am mistaken, then yes, the post-merge template will be able to handle it because no functionality is being lost (just renamed). Primefac (talk) 16:17, 1 June 2024 (UTC)
- Obviously I don't oppose a merge if the current default behavior is retained. Nickps (talk) 16:11, 1 June 2024 (UTC)
- The following is an archived discussion concerning one or more templates or modules. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template's talk page or in a deletion review).
The result of the discussion was delete. ✗plicit 23:33, 29 May 2024 (UTC)
- Template:Varies/doc (talk · history · transclusions · logs · subpages)
Unused as the template uses Template:Table cell templates/doc. Gonnym (talk) 14:58, 22 May 2024 (UTC)
- Delete per nomination. --WikiCleanerMan (talk) 00:39, 26 May 2024 (UTC)
- The above is preserved as an archive of the discussion. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template or module's talk page or in a deletion review). No further edits should be made to this section.
- The following is an archived discussion concerning one or more templates or modules. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template's talk page or in a deletion review).
The result of the discussion was merge to Template:Infobox mapframe/doc. ✗plicit 23:32, 29 May 2024 (UTC)
- Template:Infobox mapframe/doc/templatedata (talk · history · transclusions · logs · subpages)
- Template:Infobox mapframe/doc (talk · history · transclusions · logs · subpages)
Propose merging Template:Infobox mapframe/doc/templatedata with Template:Infobox mapframe/doc.
Merge the TemplateData to the main /doc template (Template:Infobox mapframe/doc#TemplateData). Since it was created in 2020 and hasn't been updated once since, the parameters need to be checked to see if they are still up to date. Gonnym (talk) 14:54, 22 May 2024 (UTC)
- Merge per nom. * Pppery * it has begun... 16:03, 22 May 2024 (UTC)
- The above is preserved as an archive of the discussion. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template or module's talk page or in a deletion review). No further edits should be made to this section.
- The following is an archived discussion concerning one or more templates or modules. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template's talk page or in a deletion review).
The result of the discussion was delete. ✗plicit 23:32, 29 May 2024 (UTC)
Unclear sidebar subpage. Unused and not a doc page. Gonnym (talk) 14:49, 22 May 2024 (UTC)
- Delete per nomination. --WikiCleanerMan (talk) 00:38, 26 May 2024 (UTC)
- The above is preserved as an archive of the discussion. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template or module's talk page or in a deletion review). No further edits should be made to this section.
- The following is an archived discussion concerning one or more templates or modules. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template's talk page or in a deletion review).
The result of the discussion was delete. ✗plicit 03:56, 29 May 2024 (UTC)
- Template:PDreview (talk · history · transclusions · logs · subpages)
Looks like a template that never really took off in usage when it was made in 2010. At this point, such reviews are handled by WP:FFD, and the {{Oldffdfull}} template points readers in the direction of relevant discussions for files. (Also, if this template is deleted, Category:PD reviewed files should probably be deleted per {{Db-g8}} as dependent on the nominated template.) Steel1943 (talk) 22:20, 14 May 2024 (UTC)
- Comment NFCC/NFUR and PD discussions were merged into FFD, so this should be a remainder of a defunct process -- 65.92.244.237 (talk) 03:49, 18 May 2024 (UTC)
- It wasn't used for either process though. It was a template that was created then never utilized. Steel1943 (talk) 21:53, 19 May 2024 (UTC)
Relisted to generate a more thorough discussion and clearer consensus.
Please add new comments below this notice. Thanks, Primefac (talk) 09:39, 22 May 2024 (UTC)
- Delete as unused. If it was in use, there would be an argument for keeping it for historical purposes. However, it is not. HouseBlaster (talk · he/him) 03:55, 25 May 2024 (UTC)
- The above is preserved as an archive of the discussion. Please do not modify it. Subsequent comments should be made on the appropriate discussion page (such as the template or module's talk page or in a deletion review). No further edits should be made to this section.