Jump to content

Wikipedia talk:Twinkle: Difference between revisions

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
Content deleted Content added
m Archiving 2 discussion(s) to Wikipedia talk:Twinkle/Archive 45) (bot
Line 130: Line 130:
::::If the template has had previous Tfds...}}
::::If the template has had previous Tfds...}}
::{{Ping|Novem Linguae}} Since the change in Twinkle goes against the long-standing instructions at TFD, this change in Twinkle needs to be reverted unless there ''is consensus for the change at TFD as a whole''. In other words, I find the change in Twinkle controversial (I suppose I'm the "backlash") and am requesting it be reverted; I saw the [[WP:SILENCE]] claim in the discussion chain, but I didn't edit in all of 2021, so I would not have had a chance to dispute it. <small>(Also, pinging [[User:Primefac|Primefac]] as the initiator of the discussion that was linked.)</small> [[User:Steel1943|<span style="color: #3F00FF;">'''''Steel1943'''''</span>]] ([[User talk:Steel1943|talk]]) 03:50, 5 February 2022 (UTC)
::{{Ping|Novem Linguae}} Since the change in Twinkle goes against the long-standing instructions at TFD, this change in Twinkle needs to be reverted unless there ''is consensus for the change at TFD as a whole''. In other words, I find the change in Twinkle controversial (I suppose I'm the "backlash") and am requesting it be reverted; I saw the [[WP:SILENCE]] claim in the discussion chain, but I didn't edit in all of 2021, so I would not have had a chance to dispute it. <small>(Also, pinging [[User:Primefac|Primefac]] as the initiator of the discussion that was linked.)</small> [[User:Steel1943|<span style="color: #3F00FF;">'''''Steel1943'''''</span>]] ([[User talk:Steel1943|talk]]) 03:50, 5 February 2022 (UTC)
::For the record, the discussion I found regarding this can be found [[Wikipedia talk:Templates for discussion/Archive 27#Why are new postings placed at the top?|here]]. (The discussion has since been archived.) And I'll be fair on this; I cannot support this change unless [[User:Anomie|Anomie]]'s bot starts transcluding the daily subpages in ''ascending'' order instead of ''descending'' order. [[User:Steel1943|<span style="color: #3F00FF;">'''''Steel1943'''''</span>]] ([[User talk:Steel1943|talk]]) 03:55, 5 February 2022 (UTC)

Revision as of 03:55, 5 February 2022

Release soon?

Hey @SD0001. Happy holidays. The Twinkle gadget is 24 commits behind master. Any interest in doing a release soon? How's that work, do we just need to ping MusikAnimal to run the release script? –Novem Linguae (talk) 14:59, 22 December 2021 (UTC)[reply]

@Novem Linguae Yes, let's get 1460 merged first, then you can ping MusikAnimal for running the deploy script after running some sanity tests of the modules or code paths that have been changed, ideally in a different browser than the one you normally use. Almost all changes have been tested by at least two people so hopefully there won't be any bugs. Testing with IE 11 may also be a good idea, not because I think people still use IE, but because if it works in IE it will pretty well work in all other browsers. Happy holidays! – SD0001 (talk) 18:41, 22 December 2021 (UTC)[reply]
That does not appear to be moving.... should everything else continue to be held up for this? KylieTastic (talk) 12:17, 12 January 2022 (UTC)[reply]
I'm having a bit of trouble motivating myself to install IE11, test a bunch of stuff I already tested, and finish the mentioned patch. Rather than waiting for my time and motivation to increase, might be better to just release what we have, and deal with any bugs as they're reported. I defer to SD0001 though. –Novem Linguae (talk) 03:11, 27 January 2022 (UTC)[reply]
@SD0001 @Novem Linguae I see there are a lot of unsynced changes. Preferably nothing should be merged in the repo unless it's safe to be deployed, I think... but anyway I'm glad I ran the script with the --dry flag first and noticed this discussion. I'm going to manually sync the more urgent changes for #Dropdown menu broken? now. Just ping me when you feel everything is safe to deploy. Best, MusikAnimal talk 04:50, 4 February 2022 (UTC)[reply]
@MusikAnimal Everything is safe to deploy. We haven't had the time to do sanity testing, but I merged all of Novem's changes after testing, and they've tested it as well. So I don't think there's a chance anything significant is broken. Minor bugs if any can be taken up as and when reported. – SD0001 (talk) 05:43, 4 February 2022 (UTC)[reply]
Okay, with your word,  Done! MusikAnimal talk 06:01, 4 February 2022 (UTC)[reply]

Feature request

Hi, is it possible to introduce the Advanced Reporting & Vetting (ARV) options to the "compare revisions" page, when we are comparing a certain user's edits to those made before them? This will help auto-detect page oldids and make reporting easier. Thanks! ---CX Zoom(he/him) (let's talk|contribs) 13:18, 13 January 2022 (UTC)[reply]

Rollback IPv6 edits only compares part of address to determine they are consecutive

I was trying to roll back a single change using the AGF option: the diff is here (subsequent edits have been made, which changes the repro but not significantly). It was made by 2600:1700:4200:2B40:10D:75C6:25CD:86BE. But Twinkle thought there had been two changes in a row, as the previous one was by 2600:1700:4200:2B40:909B:D433:7089:DEE1. I don't know how v6 addresses are constructed; is it really possible to suggest they were the same user? David Brooks (talk) 03:40, 15 January 2022 (UTC)[reply]

And I just realized I goofed: the top 4 edits also worked as a repro (the 3 most recent IPs the same and the 4th different) until I went and made my own edit on top. But I'm sure you get the point. David Brooks (talk) 03:54, 15 January 2022 (UTC)[reply]
This is intentional; see User:TonyBallioni/Just_block_the_/64 for context. Writ Keeper  04:20, 15 January 2022 (UTC)[reply]
Understood, thanks. Since in the example the two edits were fundamentally different and 4 months apart, I guess I'll be alert to this fortunately rare case, and revert the old-fashioned way. Asking Twinkle to set a maximum timestamp gap would presumably cause difficulties in how to define the maximum. David Brooks (talk) 15:56, 15 January 2022 (UTC)[reply]
Actually, now I've slept on it, consider this a feature request: if an edit from the same IP is more than delta-T before its successor, stop looking for "same user" edits. Either it's probably a different individual, or the previous edit may well be benign and unlikely to have been spotted by now anyway. After all, the usual revertible behaviors are usually batched within a few minute. I'm open to the setting of delta-T (a week should be plenty?) and I realize it may be difficult to find a live repro. David Brooks (talk) 16:32, 16 January 2022 (UTC)[reply]

Twinkle on Igbo Wikipedia

Hi! I had wanted to activate twinkle on Igbo Wikipedia but found out it was not listed. What do I do? Olugold (talk) 21:49, 18 January 2022 (UTC)[reply]

Saw this talk page post, figured I should bring the suggestion here. Signed, IAmChaos 01:33, 19 January 2022 (UTC)[reply]

This one was harder than expected becuase we'd probably also want to add code that makes the "linked page" field required for only this template. I opened a ticket. –Novem Linguae (talk) 15:25, 20 January 2022 (UTC)[reply]
Thanks! Signed, IAmChaos

Problem with unlinking backlinks

Hello, Twinkle folks,

I use Twinkle to do most page deletions and I've found problems recently when I try to remove backlinks. For example, I just deleted a PROD, Cyber Seduction: His Secret Life, and after deleting the page I tried to remove the backlinks and just got big, red error messages and "Unlinking backlinks: Done (0/31 actions completed successfully)". And when I checked, "What links here", I found over 30 pages that still had links to the deleted page that were not removed.

I mainly use the Unlink feature with PRODs because the majority of my page deletions are draft pages and they usually have no backlinks. This problem happened to me a few days ago so I handled it manually and I thought it was just a fluke so to run into it again right now makes me wonder if there is some sort of bug. I deleted some PRODs earlier today and had no problem so it's a sporadic problem. Thanks. Liz Read! Talk! 01:41, 25 January 2022 (UTC)[reply]

Howdy @Liz. After some testing, I was able to replicate this on test wiki, and I've determined this is because there is a colon in the name of the page. It thinks that "Cyber Seduction:" is the namespace, so it is trying to delete links to "His Secret Life". It's not a super easy fix, I'll have to give this some thought, so I created a bug report. Thanks for reporting. –Novem Linguae (talk) 03:27, 25 January 2022 (UTC)[reply]
Alright, I thought of a way to fix this. Patch submitted for approval. –Novem Linguae (talk) 04:24, 25 January 2022 (UTC)[reply]
A belated thank you for figuring this out, Novem Linguae. Such a simple explanation but one that would never have occurred to me. I guess that is why the problem only happened occasionally. Thanks for submitting the patch. Liz Read! Talk! 00:47, 5 February 2022 (UTC)[reply]

U3

The speedy deletion criterion U3 was repealed back in July 2021, but you can still nominate pages for deletion with this criterion using Twinkle. See this for what happens when you do this. —GMX(on the go!) 19:37, 27 January 2022 (UTC)[reply]

@PorkchopGMX: This is set to be removed in the next release of Twinkle. TheTVExpert (talk) 19:49, 27 January 2022 (UTC)[reply]

Minor punctuation issue with {{Welcome-retro}}

Twinkle's version of {{welcome-retro}} is missing a period at the end of "Thank you for your contributions" unless the optional "linked article" parameter is specified. —GMX(on the go!) 17:36, 3 February 2022 (UTC)[reply]

Dropdown menu broken?

When I logged on to Wikipedia today, I noticed that the dropdown menu for Twinkle seems to be broken, and all the list's items are splayed out in their own section (see screenshot). Anyway to fix this? —Tenryuu 🐲 ( 💬 • 📝 ) 21:41, 3 February 2022 (UTC)[reply]

Came here to report the same, on Edge and Chrome. David Brooks (talk) 23:32, 3 February 2022 (UTC)[reply]
An interface admin edited the code today without going through code review. Perhaps it's related. Diff.Novem Linguae (talk) 23:46, 3 February 2022 (UTC)[reply]
@Novem Linguae: This seems to be it. See here. @Tenryuu and DavidBrooks: are you using vector–2022? TheTVExpert (talk) 00:08, 4 February 2022 (UTC)[reply]
@TheTVExpert: I am. David Brooks (talk) 00:21, 4 February 2022 (UTC)[reply]
@TheTVExpert: Yeah, I'm using the new Vector skin. If it's an accidental code mishap I'm sure it'll be fixed soon. —Tenryuu 🐲 ( 💬 • 📝 ) 00:38, 4 February 2022 (UTC)[reply]
It still works for me on Vector legacy Firefox 96.0.2. The interface change looks harmless. Perhaps Edge and Chrome (which share a codebase) have changed. Certes (talk) 00:24, 4 February 2022 (UTC)[reply]
I've reverted Special:Diff/1069711330 for now as Twinkle apparently does not (yet) support the Vector 2022. I wasn't even aware until today that we're now treating the new Vector as a different skin. This will surely break many scripts and gadgets. MusikAnimal talk 01:04, 4 February 2022 (UTC)[reply]
Confirmed the "More" dropdown is working again for me. David Brooks (talk) 01:27, 4 February 2022 (UTC)[reply]
The "More" dropdown menu is fixed. Thanks! —Tenryuu 🐲 ( 💬 • 📝 ) 01:45, 4 February 2022 (UTC)[reply]

Hi User:MusikAnimal. Sorry about that... was trying to avoid this breakage :)

The new Vector skin has a different key but apart from that it should work identical, so I think my change had the right idea but failed to update all the references to vector so they also check vector-2022.

I don't know much about Twinkle though so would be great if someone else who is more knowledgeable could make the next attempt:) Jdlrobson (talk) 02:14, 4 February 2022 (UTC)[reply]

Note Twinkle was working earlier today but got broken while I fixed https://phabricator.wikimedia.org/T300814

Previously we were hacking Vector 2022 so that mw.config.get('skin') returned 'vector' to avoid this. Jdlrobson (talk) 02:16, 4 February 2022 (UTC)[reply]

User:MusikAnimal I've managed to get Twinkle loading in a dropdown menu on Farsi Wikipedia for both Vector's with several edits. It also needed a change to MediaWiki:Gadgets-definition (https://fa.wikipedia.org/w/index.php?title=%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C%3AGadgets-definition&type=revision&diff=34059182&oldid=33972671)
I'd rather an admin here made the appropriate changes to English Wikipedia next time round as I've not had the most luck this week :)
Sorry again for the disruption. No harm intended. Jdlrobson (talk) 02:40, 4 February 2022 (UTC)[reply]
@Jdlrobson Had this been announced in meta:Tech/News we would have fixed it already (speaking for Twinkle and MoreMenu specifically, since there are close eyes on those gadgets). The code also needs to be updated in the respective remote repositories, which again we would have done in preparation had we known this change was coming. But no worries, we of course know you mean no harm! :) I'll get to work on updating Twinkle on GitHub now and deploy the changes in shortly thereafter. Thanks, MusikAnimal talk 02:51, 4 February 2022 (UTC)[reply]
This week didn't go to plan. :( My original hope was that we could avoid the hassle of gadget developers having to edit their gadgets by hacking the skin to pretend it was normal vector but as T300814#7674241 points out that wasn't my best idea and was a little ill thought so I had to scramble to find some kind of solution to fix live edit preview which was apparently breaking a lot of editors workflows.
Thanks for working on the fixes with such short notice. It's appreciated. Jdlrobson (talk) 03:08, 4 February 2022 (UTC)[reply]
No problem, and sorry if I was at all harsh in my wording. I understand now that this wasn't a planned change so you wouldn't have known to warn us via Tech News. Everything should be working now in Vector 2022. Best, MusikAnimal talk 04:55, 4 February 2022 (UTC)[reply]

Welcome-menu template missing from the latest iteration of the drop-down welcome menu

{{Welcome-menu}} is missing from yesterday's change in the drop-down welcome menu. Can we please add it back in? The welcome menus are one of the major things that I use Twinkle for, & I almost exclusively use the Welcome-menu option for newly registered editors. It is painful having to drop in {{subst:WelcomeMenu}} manually! Peaceray (talk) 20:01, 4 February 2022 (UTC)[reply]

@Peaceray: It was removed per this discussion. You can add it back in your Twinkle preferences. TheTVExpert (talk) 20:20, 4 February 2022 (UTC)[reply]
I was wondering why the welcome messages I use every day were missing. Liz Read! Talk! 00:44, 5 February 2022 (UTC)[reply]
I'm happy to add it back in if people use it. Any others to add back besides welcome-menu? –Novem Linguae (talk) 00:51, 5 February 2022 (UTC)[reply]
I use the welcome variants when it seems appropriate, usually when I can AGF. Happy to use Preferences though. David Brooks (talk) 00:57, 5 February 2022 (UTC)[reply]
(ec)That would be awesome if you could add back a few. All I know about the one I use is that it states it has 20 links to policy pages. It looked like it was going to kind of be a pain in the ass to go through all of the templates to locate and manually add back the templates I frequently use.
I have also wanted to add to the Twinkle drop down warning messages the one about Wikipedia not being a social media site...I see editors posting that one on the talk pages of a lot of young, new editors. I run into a lot of new editors creating "profile pages" so it really fits their situation. But I guess my request doesn't help much if I don't give you a link to the template I'm referring to. I'll tray to track that down. There are a helluva lot of templates though! Liz Read! Talk! 00:59, 5 February 2022 (UTC)[reply]
I see the one I always use is called {{Welcome-graphical}} but some other editors didn't like it at all which I guess is why it was removed. I found it useful as it provided a balance of policy pages and "How to get started" links. Liz Read! Talk! 01:03, 5 February 2022 (UTC)[reply]
Alright, welcome-menu and welcome-graphical. Works for me. Any others? Should we revert all the ones that were removed, or just focus on welcome-menu and welcome-graphical? –Novem Linguae (talk) 01:36, 5 February 2022 (UTC)[reply]

Twinkle placing new WP:TFD nominations at wrong location on daily page

See here. Twinkle is placing new nominations for WP:TFD at the bottom of the daily page instead of at the top of the page. I've noticed that WikiCleanerMan has been doing their due diligence to fix the nominations' locations on the page(s) (but I'd imagine they'd rather have this issue fixed so they don't have to fix the nominations' locations anymore.) Steel1943 (talk) 01:55, 5 February 2022 (UTC)[reply]

@Steel1943. Hey there. It's intentional, please see Wikipedia talk:Twinkle/Archive 45#Changing TFD behaviour. I'd recommend letting it do its thing, and if there's a big backlash we can revert it after trying it out for a bit. –Novem Linguae (talk) 02:59, 5 February 2022 (UTC)[reply]
Thanks for the link to that discussion. However, the change goes against the instructions at WP:TFDHOWTO, specifically the part listed at "II: List the template at Tfd.:
Add this text at the top, just below the -->:
  • For deletion: {{subst:Tfd2|template name|text=Why you think the template should be deleted. ~~~~}}
  • For merging: {{subst:Tfm2|template name|other template's name|text=Why you think the templates should be merged. ~~~~}}
If the template has had previous Tfds...
@Novem Linguae: Since the change in Twinkle goes against the long-standing instructions at TFD, this change in Twinkle needs to be reverted unless there is consensus for the change at TFD as a whole. In other words, I find the change in Twinkle controversial (I suppose I'm the "backlash") and am requesting it be reverted; I saw the WP:SILENCE claim in the discussion chain, but I didn't edit in all of 2021, so I would not have had a chance to dispute it. (Also, pinging Primefac as the initiator of the discussion that was linked.) Steel1943 (talk) 03:50, 5 February 2022 (UTC)[reply]
For the record, the discussion I found regarding this can be found here. (The discussion has since been archived.) And I'll be fair on this; I cannot support this change unless Anomie's bot starts transcluding the daily subpages in ascending order instead of descending order. Steel1943 (talk) 03:55, 5 February 2022 (UTC)[reply]