User talk:JJMC89

This user has opted out of talkbacks

Code for #6

Hi! Is there any chance, that I could see C# module for task 6 of your bot? I don't care, how much pretty or understandable it is for people other than you. You can send me it as plain text via e-mail option, if you're willing to do that. And don't worry - won't publish partially or fully without your permission. If you're not willing to do that, simply say so, so that I don't wait for positive response :) --Edgars2007 (talk/contribs) 11:08, 22 September 2016 (UTC)

@Edgars2007: I've started to rewrite part of that module because I originally just hacked together to make it work, requiring updates to the module when the templates have extra parameters or different parameter names. Is there a certain part of the code you are interested in? Depending on what you are looking for, it may be better to send the code after I revise it (hopefully this weekend) or point you to where I borrowed some of the code from. If you are looking for something to compare values to Wikidata, the module does not do that. I add {{WikidataCheck}} to the templates and create lists based on the tracking categories. — JJMC89 17:24, 22 September 2016 (UTC)

Thanks for reply. One of many reasons is learning, so from this POV it would be cool to see current version and revised one; some links to code snippets you used would also be a good bonus. I'm interested in code generally. And no, Wikidata comparing part is out of my interest. --Edgars2007 (talk/contribs) 17:45, 22 September 2016 (UTC)

@Edgars2007: I can post links after work. I think I'll create a GitHub repository to post my AWB modules. I will email you the current code, which I won't post there. — JJMC89 18:47, 22 September 2016 (UTC)

@Edgars2007: The module for task 6 is largely based on Pathoschild's AWB plugin TemplateEditor.cs. I took DelimitTemplates, slightly modified UndelimitTemplates, and butchered GetParameters. — JJMC89 04:50, 23 September 2016 (UTC)

@Edgars2007: I just emailed you the old code. See el-template-param-remover.cs on GitHub for the revised version. — JJMC89 06:41, 26 September 2016 (UTC)

Looks really great. Thanks and happy value remove job! --Edgars2007 (talk/contribs) 09:29, 26 September 2016 (UTC)

Template count

From what I see in code, you remove all matching templates from EL section. It may cause some problems, if there are more than one template in ELs. I would say - skip if there is more than one. --Edgars2007 (talk/contribs) 05:02, 30 September 2016 (UTC)

@Edgars2007: It processes the section, removing for all instances; however, it does skip if there is more than one. targetTemplateCalls counts the number of matches in the EL section, and if it is not one, then it skips (see line 194). — JJMC89 05:30, 30 September 2016 (UTC)

Hah. I saw comment on line 193 and didn't read the whole line 194 :) Then we're good here, thanks. --Edgars2007 (talk/contribs) 06:15, 30 September 2016 (UTC)

Yea, I moved the check for that and forgot to update the comment. — JJMC89 16:02, 30 September 2016 (UTC)

And while I'm here... on line 128 what are those 4 symbols around \d{1,4} for? Don't believe those are these (by meaning) ... --Edgars2007 (talk/contribs) 06:21, 30 September 2016 (UTC)

@Edgars2007: I don't know what they are for. That regex is based on WikiRegexes.Headings, which matches any section heading. Maybe Magioladitis knows. — JJMC89 16:02, 30 September 2016 (UTC)

Assessment comments

Hi, I'm ready for your bot to take one final run on Category:Assessment comments to be substituted by bot and then one final run on Category:Pages whose comments subpage can be redirected and this task will be totally finished. Thank you — Martin (MSGJ · talk) 20:45, 26 September 2016 (UTC)

@MSGJ:  Done — JJMC89 03:06, 27 September 2016 (UTC)

Thank you. One more go through Category:Assessment comments to be substituted by bot please. Note the format of the comments pages is slightly different with this batch: either /CommentsBB or /Comments (baseball). — Martin (MSGJ · talk) 20:36, 6 October 2016 (UTC)

Poke ... when you get a chance please — Martin (MSGJ · talk) 11:36, 10 October 2016 (UTC)

@MSGJ: Thanks or the reminder. This is now  Done. — JJMC89 15:44, 10 October 2016 (UTC)

Deletion File:ArtofLoveCDCover.jpg

It is specifically said on Alchetron Topic Page of Art Supawatt Purdy Alchetron Topic Page for Art Supawatt PUrdy that the pictures of that topic can be used and distributed using this license (CC BY-SA 3.0), and I clearly give the credit to the author and provide the link to this picture in the description. Greekadoniz (talk) 22:05, 3 October 2016 (UTC)

That page has conflicting licensing. The bottom of the page indicate's that it is copyrighted. — JJMC89 02:28, 4 October 2016 (UTC)

My rv of your redirect of Art Supawatt Purdy

The article as it stands now is considerably different from the one the AfD was based on. The author came up with several sources that cover him in depth. They are all in print and in Thai so I asked him to quote the sections he used as references and provide his own translation to help with verification. There is a discussion about it on my talk page at User talk:Jbhunley#Art Supawatt Purdy. Cheers. Jbh^Talk 23:04, 3 October 2016 (UTC)

@Jbhunley: Thanks for the heads up. The discussion should be moved to the article's talk page. — JJMC89 02:25, 4 October 2016 (UTC)

Social Discovery Ventures. Copyright

Hello JJMC89. I have a problem with the article Social Discovery Ventures. What can I do to resolve this situation? I have translated by myself my article from english to russian. And what about that link with article that you marked as a copyright issue, Actually these two articles are NOT the same, it's two different texts. Some matches are possible just because press release of company posted on that website. Please help to resolve this question. MoscowFF (talk) 10:22, 4 October 2016 (UTC)

@MoscowFF: I did not mark the article with any copyright issues. I provided attribution for the translation in this edit summary after Justlettersandnumbers blanked the article for copyright issues. I have not fully investigated the copyright concerns. The directions on the page provide a place that the article can be rewritten. You cannot copy text found online; it must be written in your own words. Currently there is text copied from the website indicated on the page, which can be seen here. — JJMC89 15:52, 4 October 2016 (UTC)

Could you say, may I edit the article by myself to replace the disputable part? MoscowFF (talk) 13:43, 11 October 2016 (UTC)

@MoscowFF: No, you may not. As it says on the page, only an administrator, copyright clerk or OTRS agent may edit the page. — JJMC89 14:19, 11 October 2016 (UTC)

User:Nickyjamlaindustrua inc

Hey, I noticed on RC patrol that you blanked the page with WP:FAKEARTICLE as the comments. Could you use template:db-band instead, or whichever is appropriate? Thanks! FalconK (talk) 03:26, 5 October 2016 (UTC)

No. {{db-band}} is only for articles. — JJMC89 03:43, 5 October 2016 (UTC)

Sorry about Template:citar web et al.

Sorry about jumping the gun with {{citar web}}. I had tried substing a few examples copied from articles in my sandbox, and they worked, so I figured we were ready to go. After seeing all of the reverts I made you do (sorry again), I am going to continue to experiment in the template's sandbox. Feel free to drop a trout my way. – Jonesey95 (talk) 03:55, 6 October 2016 (UTC)

By the way, I have noticed that for reasons I do not yet understand, some dates were not translated during the substing. These dates will be taken care of by BattyBot, which usually runs monthly. – Jonesey95 (talk) 04:21, 6 October 2016 (UTC)

@Jonesey95: Consider yourself trouted. From a brief look, HTML comments need to be <noinclude>...</noinclude> and all parser functions, including #invoke, need to be SAFESUBST:<noinclude />. I can go through it before you try again if you want. Also, please make sure all of the parameters are up to date. This edit removed some parameters used in {{cita news}}. — JJMC89 04:23, 6 October 2016 (UTC)

I see that parameter-dropping in {{cita news}}. It looks like the template was designed to translate Portuguese and Italian, but these template parameters are Spanish. The canonical Spanish template name is "Cita noticia", but "Cita news" is a redirect, so we'll have to account for that. I have a script that replaces parameters it knows about and leaves ones that it doesn't recognize (instead of dropping them); maybe I'll use that for now.

As for the HTML comments and other cosmetic quirks, I haven't been able to figure out why {{Cytuj stronę}} substituted only the parameters that were present, but {{Citar web}} inserted a long list of blank parameters. This might be over my head, template-programming-wise. – Jonesey95 (talk) 04:31, 6 October 2016 (UTC)

@Jonesey95: {{Cytuj stronę}} has a special subst version like {{Cita news}}. Search for Susbst format or Subst format, respectively, in the source. {{Citar web}} is not coded that way. — JJMC89 04:42, 6 October 2016 (UTC)

Ah, that's what that does. I will convert {{Cita news}} and {{Citar web}} with my own script then, and clean up after myself as parameters that are not supported by the templates are turned up. These translation templates are clever but flawed, in that they do not have the built-in error-checking that the CS1 templates have, and they do not report the presence of "unsupported" parameters.

I think it may be better to have all of these templates as redirects to the appropriate cite templates, and then have a bot convert the foreign-language parameters to their English-language equivalents. I convert a few copy-pasted foreign cite templates almost every day using a script. Maybe I'll bring this up at the appropriate forum. Thanks for all of your help, and for the tasty trout. – Jonesey95 (talk) 04:48, 6 October 2016 (UTC)

RfC for page patroller qualifications

Following up from the consensus reached here, the community will now establish the user right criteria. You may wish to participate in this discussion. --Kudpung กุดผึ้ง (talk) 12:57, 6 October 2016 (UTC)

hello stub template

You didn't have to revert, you could've just told me and I would have done em :) Thanks for letting me..I will fix. Saadkhan12345 (talk) 02:14, 7 October 2016 (UTC)

Here is this good enough? so i can continue. Saadkhan12345 (talk) 12:41, 7 October 2016 (UTC)

@Saadkhan12345: That is the correct way to add them, yes. — JJMC89 15:39, 7 October 2016 (UTC)

This IBDB linkage is now incorrect...

On Joan Blondell the User:JJMC89 bot removed {{IBDB name|32322}} (which gave this result) and replaced it with {{IBDB name}} which gives a 404 - File not found result. Shearonink (talk) 03:57, 7 October 2016 (UTC)

Thanks for the heads up, Shearonink. Fixed on Wikidata. Blondell has two IBDB pages (79996). — JJMC89 04:22, 7 October 2016 (UTC)

I admit it, I don't understand that much about Wikidata...can you link to the change there? Why does it work now here and it didn't work before?... Shearonink (talk) 05:31, 7 October 2016 (UTC)

@Shearonink: The change. Now it works, because now one of the values have been set as "better" value, previosly both values had the same "priority". JJMC89, probably such articles would be good to skip or at least fix before bot run. Can give you a query later to find such Wikidata items. --Edgars2007 (talk/contribs) 05:41, 7 October 2016 (UTC)

Ok, well knew that, that the value has been set to a better value...but where has that value been set? Somewhere in Wikidata? A link to the Wikidata edit is what I would like to see. I'm looking at the Joan Blondell article and nothing was changed there...see, the questions I ask are so elementary... Shearonink (talk) 07:13, 7 October 2016 (UTC)

@Shearonink: but I did gave you link to edit. As we don't need to save space :) will give you it once more: the change. --Edgars2007 (talk/contribs) 07:44, 7 October 2016 (UTC)

Duh, missed that first blue-link. Thx for yr patience. Shearonink (talk) 07:57, 7 October 2016 (UTC)

Thanks Edgars2007 for answering while I slept. I agree that instances like that should be fixed prior to running or skipped. That was the first one of these IDs that I have seen with multiple property values on Wikidata. {{WikidataCheck}} doesn't catch it since it only looks at the first property value. A query to find these would be useful. Maybe I should figure out how to use Wikidata in Pywikibot and rewrite the bot in Python. — JJMC89 16:10, 7 October 2016 (UTC)

Break

Not so good news. Query for IBDB shows, that there are potentially 256 broken articles. You can query also for a category, of course. Don't forget to change property ID in "Other sources" tab. Easy fix is to use Module:Wikidata, which will display only the first value. In a perfect world, we should fix that in Wikidata, marking values as preferred. And if we could have a list of old ID values here on enwp :D --Edgars2007 (talk/contribs) 16:48, 7 October 2016 (UTC)

Getting WD data, while you're in Wikipedia, is simple in pwb - something like this. --Edgars2007 (talk/contribs) 17:03, 7 October 2016 (UTC)

@Edgars2007: The module gives "72449, 72450" on Nancy Reagan, which is the same as {{#property}}. Am I missing something? — JJMC89 02:48, 8 October 2016 (UTC)

All fixed on Wikidata now. — JJMC89 03:58, 8 October 2016 (UTC)

Good, thanks. Sorry about Wikidata module, didn't had time to test it and I thought, that it would return only one value. Now I know, that it's not true :D That means, that checking previous templates is more important / we need such functionality in module. --Edgars2007 (talk/contribs) 04:20, 8 October 2016 (UTC)

Yes, ideally a module to get the first property value of the highest priority would be the solution for external links templates. I don't know Lua, so I'll leave that to someone else. — JJMC89 22:55, 8 October 2016 (UTC)

Hello

Can you check this page and tell me what wrong with it (how can I improve it).? Saadkhan12345 (talk) 22:39, 7 October 2016 (UTC)

shouldnt the stub template go on top of the page where people (outsiders) can see that its a stub and should be help wikipedia by improving it.? — Preceding unsigned comment added by Saadkhan12345 (talk • contribs) 14:52, 8 October 2016 (UTC)

@Saadkhan12345: It doesn't have any references – you need to cite your sources. No, stub templates go at the end of the article, see MOS:SECTIONORDER. — JJMC89 22:42, 8 October 2016 (UTC)

what else needs to be fixed...Saadkhan12345 (talk)

I suggesting asking at the Teahouse. — JJMC89 20:40, 9 October 2016 (UTC)

Can you also tell me how to propose stub categoriesSaadkhan12345 (talk) 19:40, 9 October 2016 (UTC)

I have already pointed it out to you multiple times. You need to follow the stub proposal procedure. — JJMC89 20:40, 9 October 2016 (UTC)

Twitter --> Wikidata

Was there a public discussion about this change that your bot is making to English Wikipedia pages? I am also seeing Infobox proposals to move to Wikidata. I am very concerned about the lack of transparency and notification about these items. Please advise. -- Erika aka BrillLyle (talk) 18:24, 9 October 2016 (UTC)

Yes there was. Please stop spreading false accusations, in multiple venues, of "lack of transparency and notification", and assume good faith. Your edit on Template talk:Twitter, for example, was made immediately after this one; I suggest you review the earlier version of the page. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 20:33, 9 October 2016 (UTC)

@Erika: It was proposed on the template's talk page by Pigsonthewing. Since there were no comments, my bot removed the template parameters. This page has information about that bot task. I don't have anything to do with moving/adding the data to Wikidata or infoboxes. — JJMC89 20:35, 9 October 2016 (UTC)

Thanks for the work, JJMC89! Sorry for the FUD. Nemo 20:46, 9 October 2016 (UTC)

Thanks for the response and explanation JJMC89. Appreciate you taking the time to let me know. -- Erika aka BrillLyle (talk) 00:41, 10 October 2016 (UTC)

Thaaaaaank you!

Re: these copyvio removals, thank you very much!! I greatly appreciate the time donation. Cyphoidbomb (talk) 03:43, 12 October 2016 (UTC)

No problem, Cyphoidbomb. There could be more problems with the article, I only took out the most blatant copy and paste issues. If the user that wrote the article is a serial copyright violator, a WP:CCI may be warranted. Justlettersandnumbers may be able to take a more in-depth look and advise if a CCI is needed. — JJMC89 04:15, 12 October 2016 (UTC)

Good to know, thank you. I'll try to follow up on that soonish. Regards, Cyphoidbomb (talk) 04:20, 12 October 2016 (UTC)

Redirecting Sevyn Streeter singles to the artist article

I don't really think redirecting article's for the singles by Sevyn Streeter to her article is very necassary so I really hope you reconsider and let me reimprove them so they can be open.