Jump to content

Wikipedia talk:Tools/Navigation popups: Difference between revisions

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
Content deleted Content added
Camion (talk | contribs)
We have the same problem in the French wiki : Professional, technical or scientific jargon often use English words which are removed by this popup (also see default popup)
Line 67: Line 67:
::Which would be [[phab:T138803]] btw.. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 18:52, 13 September 2017 (UTC)
::Which would be [[phab:T138803]] btw.. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 18:52, 13 September 2017 (UTC)
:::Believe it or not, I have some (horrible) code that somewhat works for that ticket, but it's been stuck in development hell forever - the popups code is so fragile. It's one of those things that I return to on a monthly basis, though, so I definitely have hope that this'll land Pretty Soon™. [[User:Enterprisey|Enterprisey]]&nbsp;([[User talk:Enterprisey|talk!]]) 07:11, 25 September 2017 (UTC)
:::Believe it or not, I have some (horrible) code that somewhat works for that ticket, but it's been stuck in development hell forever - the popups code is so fragile. It's one of those things that I return to on a monthly basis, though, so I definitely have hope that this'll land Pretty Soon™. [[User:Enterprisey|Enterprisey]]&nbsp;([[User talk:Enterprisey|talk!]]) 07:11, 25 September 2017 (UTC)


{{ping|nenntmichruhigip|TheDJ|Enterprisey}} I also raised [https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Questions_techniques/semaine_5_2018#Bug_:_mod%C3%A8le(s?)_escamot%C3%A9(s?)_des_bulles_de_pr%C3%A9visualisation_quand_on_survole_les_liens the same problem on the French wiki]. There are many situation where professional, technical or scientific jargon use English words which are often more used than the local term and appear in articles introductions, and those are removed by this popup. There is also the default popup (in preferences/appearance which (in Fr) shows the hidden text, but without it's formatting, while it shows the formatting for non template content) -- [[User:Camion|Camion]] ([[User talk:Camion|talk]]) 09:59, 3 February 2018 (UTC)


== Live updates cause problems with popups ==
== Live updates cause problems with popups ==

Revision as of 09:59, 3 February 2018

This page is for discussing Navigation popups and reporting bugs you encounter with it. Please be aware that the original author of Popups (Lupin) is no longer active on Wikipedia. All issues are handled at the discretion of other experienced editors. Note that this project has an associated Phabricator project where implementation-related discussion happens.

Not sure how to explain your problem clearly? Read How to Report Bugs Effectively for some general pointers.

Some common questions are answered in the FAQ.


Missing user info if no contributions

When hovering on a User: link for an account that has made any edits, the popup includes a footer line with a list of permissions bits, the edit-count, the date the account was created, and the date of the most recent edit. If the account has not made any edits, that footer is missing altogether. When tracking vandals (especially possible sleepers at SPI) it would be useful to see the account-creation date. And it would also be useful to see an explicit "0" for edit-count, to help distinguish this actual piece of data from the popup stalling before completely rendering itself. And it also is important to see tags like "blocked" and "locked" so I don't waste my time trying to clean up a mess that has already been cleaned up. DMacks (talk) 21:11, 8 April 2017 (UTC)[reply]

The account that prompted this is both suppressed and globally hidden, so I don't think that the Popups script can even see the account. Thankfully, this is a rare case, and I don't know if there's any graceful way for Popups to handle it. However, I agree that it would be useful if Popups could display complete information for other accounts without any edits, as that's an issue I frequently encounter as well. ​—DoRD (talk)​ 21:24, 8 April 2017 (UTC)[reply]
In Special:Block for that account, MediaWiki:Centralauth-block-already-locked ("...is already locked globally.") is noted. But other than that, it's true that the account does not have a block in its log and there is no pink box on its contributions page. DMacks (talk) 21:33, 8 April 2017 (UTC)[reply]
Good idea! Edit request filed. Enterprisey (talk!) 19:32, 28 June 2017 (UTC)[reply]
And it's done, so the feature should be live. Enterprisey (talk!) 20:33, 28 June 2017 (UTC)[reply]

suggestions

make the hoverzoom boxes show more.

need more info! less file descrptiony stuff too. — Preceding unsigned comment added by Rhodechill (talkcontribs) 04:16, 28 April 2017 (UTC)[reply]

Will this work with mobile devices?

Not finding anything in the FAQ or talk archives on this, so might as well ask: does this only work if you are using a mouse/trackball/trackpad, or will it work for touchscreen users? Beeblebrox (talk) 18:21, 29 April 2017 (UTC)[reply]

I don't think anyone has figured out how to implement tooltips when hovering on clickable links on mobile (touch) devices. -- Michael Bednarek (talk) 01:54, 30 April 2017 (UTC)[reply]
@Beeblebrox and Michael Bednarek: A long tap, after exiting the menu your phone opens, shows the popup. melo kol haaretz kevodi (talk) 21:10, 28 June 2017 (UTC)[reply]

Sometimes when a red link is shown, a page already exists with a differently spelled title. To discover this, an editor could search the wiki (in the same namespace) for the link text. Could someone add a search link to the menu for red links? --Bdijkstra (talk) 09:27, 17 May 2017 (UTC)[reply]

Popups only working on some pages

For some reason popups are not working for me on most pages but are on some. Right now they work on Special:Mycontributions and Special:Watchlist, but nowhere else including articles and WP pages. Anyone else have this problem or know how to fix it? Reywas92Talk 18:12, 17 May 2017 (UTC)[reply]

Most probably it’s caused by one of your user scripts (vector.js or monobook.js, depending on your skin). The easiest fix is to wrap the whole script in a call beginning with mw.loader.using( 'mediawiki.legacy.wikibits', function () { and ending with } );, but it’s only a temporary fix, since wikibits.js will go away entirely after some time. If you would like to have a permanent fix, you might do it yourself (here are the replacements) or ask for assistance on the village pump. (These JavaScript subpages can be edited only by you and by admins.) --Tacsipacsi (talk) 18:44, 17 May 2017 (UTC)[reply]
If it doesn’t work, then there are other errors too (these files do have errors for sure) which produce error messages shown on the browser console. Those show exactly where the error occurred and help correcting them. (N.B. I can help you finding the errors, but I don’t have any rights to actually correct them; you need admins for that.) --Tacsipacsi (talk) 12:45, 18 May 2017 (UTC)[reply]

Seeing whether a page is on your watchlist from the navpop

It would be helpful to be able to see whether an article was on your watchlist without having to click it. Would it be possible to add a similar star to the navpop of articles so that you can see if the article is on your watchlist (and maybe even add it to your watchlist)? Absolutelypuremilk (talk) 07:28, 14 June 2017 (UTC)[reply]

Sure, that sounds like a good feature to add an option for. Tracked on Phab. Enterprisey (talk!) 16:37, 28 June 2017 (UTC)[reply]

Hello, good afternoon. It would be great if through the popup i'd be able to view a review of the article in other languages the same way i view in the original language, or at least be able to jump to another language through the popup. can someone add a link to other languages inside the popup that would enable it? melo kol haaretz kevodi (talk) 20:09, 28 June 2017 (UTC)[reply]

killTemplates only for some templates

On dewiki, there’s the request to somehow get the content of formating templates (like Template:lang) visible in Navpopups. As possible solution to this, I’m suggesting

  • a wiki-specific list of templates, which will be displayed as if popupPreviewKillTemplates=false would have been set (to avoid having templates like infoboxes make Navpopups useless) or maybe even
  • such a list with at least one parameter per template in that list, to only display the content of that parameter.

--nenntmichruhigip (Diskussion) 18:01, 13 September 2017 (UTC)[reply]

My opinion is that someone should finally rewrite popups, and then remove infoboxes from a properly rendered blob, instead of trying to reimplement a wikitext parser in JS. :) —TheDJ (talkcontribs) 18:46, 13 September 2017 (UTC)[reply]
Which would be phab:T138803 btw.. —TheDJ (talkcontribs) 18:52, 13 September 2017 (UTC)[reply]
Believe it or not, I have some (horrible) code that somewhat works for that ticket, but it's been stuck in development hell forever - the popups code is so fragile. It's one of those things that I return to on a monthly basis, though, so I definitely have hope that this'll land Pretty Soon™. Enterprisey (talk!) 07:11, 25 September 2017 (UTC)[reply]


@Nenntmichruhigip, TheDJ, and Enterprisey: I also raised the same problem on the French wiki. There are many situation where professional, technical or scientific jargon use English words which are often more used than the local term and appear in articles introductions, and those are removed by this popup. There is also the default popup (in preferences/appearance which (in Fr) shows the hidden text, but without it's formatting, while it shows the formatting for non template content) -- Camion (talk) 09:59, 3 February 2018 (UTC)[reply]

Live updates cause problems with popups

Navigation popups gadget is very useful with Recent Changes, because, among other things, it lets you preview diffs of changes without having to visit the page in question.

However, with implementation of "Live updates" feature, tracked in T167743, the gadget popup tends to get "stuck", meaning that individual overlays will hang around on the screen. In Live Updates mode, when a popup gets stuck, there's no obvious way to get rid of it. You can scroll away or click elsewhere on the page. The only thing that clears it is a page reload. The overlay is untethered to its link, and even stays on top when you open a some other menu. This problem is tracked in T172957, and in the comments of that ticket you can see that same problem occurs with MediaWiki's live preview.

This gadget claims to have support for MediaWiki's live preview, VisualEditor's saves and Echo's flyout. This is added through dynamicContentHandler handler, subscribed to wikipage.content hook. But, when wikipage content gets changed, callback triggered, setupTooltips is called. This is where addTooltip is called not only for newly fetched links, but for all the links. I think this is the place where above explained problem occurs. onmouseout event does not get triggered, leaving Navigation popup without it's position checker hook (posCheckerHook), and after that only way of closing popup is using menu Popups > Reset, or reloading the page, as mentioned above.

The solution that I propose is traversing all the visible Navigation popups in the doIt method, and attaching the position checker hooks. That way, normal behavior is restored, and listeners aren't duplicated. You can see my proposal on my User Page. Unless some of you guys think there is easier/better/faster solution to this problem.

But, since there are few people active on this gadget maintenance, and I see opinions to rewrite it, my solution would probably be quickfix to above problems. --User:Petar.petkovic

@User:Petar.petkovic I inserted your sig for you; I use Navpops on a daily basis, so you will be hearing from at least one user if I see any problems. --Ancheta Wis   (talk | contribs) 18:43, 22 September 2017 (UTC)[reply]
done —TheDJ (talkcontribs) 13:49, 4 October 2017 (UTC)[reply]
I accidentally had broken this again, due to the fix for the issue one topic below this one, but it's repaired now. —TheDJ (talkcontribs) 11:51, 10 October 2017 (UTC)[reply]

Error

Javascript was not loading properly for me, and when I tried to find out what it was, I saw this: Uncaught TypeError: Cannot read property 'getParamValue' of undefined and the link next to it was the Popups script.

   at autoEdit (/w/index.php?title=MediaWiki:Gadget-popups.js&action=raw&ctype=text/javascript:1097)
   at HTMLDocument.<anonymous> (/w/index.php?title=MediaWiki:Gadget-popups.js&action=raw&ctype=text/javascript:7837)
   at fire (load.php:45)
   at Object.fireWith [as resolveWith] (load.php:46)
   at Function.ready (load.php:49)
   at completed (load.php:49)

-- 1989 04:53, 28 September 2017 (UTC)[reply]

Note for later. "if (!setupPopups.completed) { setupPopups(); }" setupPopups is async, seems that autoEdit doesn't wait for it to be completed. —TheDJ (talkcontribs) 13:40, 28 September 2017 (UTC)[reply]
It is my hope that my latest change fixes this. —TheDJ (talkcontribs) 19:17, 6 October 2017 (UTC)[reply]

JavaScript error

Hello. Intermittently (about 1 time in 6) popups fail to load for me on a Wikipedia page. It doesn't seem to be restricted to any namespace or any particular type of page, nor is it consistent on any individual page. The popups load if I do a Ctrl+F5. Happens on latest Chrome and on latest Firefox.

When popups have failed to load, the JavaScript console reports the following error.

ReferenceError: addPortletLink is not defined
    at eval (eval at <anonymous> (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:4), <anonymous>:1:228)
    at HTMLDocument.<anonymous> (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:179)
    at fire (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:45)
    at Object.add [as done] (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:45)
    at jQuery.fn.init.jQuery.fn.ready (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:49)
    at new jQuery.fn.init (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:41)
    at jQuery (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:1)
    at load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:179
    at eval (eval at <anonymous> (load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:4), <anonymous>:1:203)
    at eval (<anonymous>)}}

Have I configured something incorrectly? Or have I found a problem? Grateful for any help anyone can offer. --RobertGtalk 09:08, 3 October 2017 (UTC)[reply]

@RobertG: Yes, this kind of behavior (random javascript initiated elements going missing) is usually due to errors in a script, which most of the time is your own script. I've corrected a script of yours which was of an outdated form. I think it will be better for you now. —TheDJ (talkcontribs) 20:36, 3 October 2017 (UTC)[reply]
@TheDJ: I think that has done the trick. Many thanks. --RobertGtalk 13:01, 4 October 2017 (UTC)[reply]

Revert edit summary no longer autopopulating

Beginning today, on multiple computers and multiple browsers, popups no longer autopopulates the edit summary when I use it to revert edits. Any ideas what may be going wrong and how I can fix it? ElKevbo (talk) 02:33, 6 October 2017 (UTC)[reply]

I noticed the same thing (Firefox and Chrome). -- Michael Bednarek (talk) 05:43, 6 October 2017 (UTC)[reply]
This seems like a very significant issue. I've had another issue - discussed above in " Reverts/edits no longer autosaving" - for about six months now. If this tool is no longer being maintained then we shouldn't include it as an option for all (logged in) editors to use. ElKevbo (talk) 15:41, 6 October 2017 (UTC)[reply]
If that was the bar, we wouldn't have any gadgets left. Most are unmaintained. —TheDJ (talkcontribs) 18:41, 6 October 2017 (UTC)[reply]
If they're still working as intended then it may not be an immediate problem. This tool is not working as intended so it is an immediate problem. ElKevbo (talk) 20:04, 6 October 2017 (UTC)[reply]
The problem is that if we remove it as an option, it's gone for all 47000 people who currently have it installed (plus probably as many users on wiki's that reuse directly include this specific version) and there is no undo button for that action. So while adding things is easy, removing them is much more difficult. I for one do not intend on pissing off potentially 47000+ users. —TheDJ (talkcontribs) 20:16, 6 October 2017 (UTC)[reply]

Has popups gone down?

Popups seems to have disappeared completely for me—hovering now just brings up the browser tooltip and nothing else. I've tried enabling it on my User:Iridescent 3 account which has all preferences at default and a completely blank vector.js file and they don't work there either, and also tried using a different browser with no effect, so it's not a malfunctioning or clashing script at my end. Is this a system-wide fault, or my computer playing up? ‑ Iridescent 20:19, 22 October 2017 (UTC)[reply]

Me too. TheDJ modified the script an hour ago, so something should have gone wrong. --Tacsipacsi (talk) 20:22, 22 October 2017 (UTC)[reply]
(edit conflict) @Iridescent: I just noticed this, too. I'm getting nothing but tooltip and I'm halfway through the troubleshooting steps. Chris Troutman (talk) 20:23, 22 October 2017 (UTC)[reply]
Down for me as well. I linked to an old version of popups in my user JS file and the script's working again, so the most recent change is definitely the culprit. —k6ka 🍁 (Talk · Contributions) 20:31, 22 October 2017 (UTC)[reply]
lemm get to that. —TheDJ (talkcontribs) 20:36, 22 October 2017 (UTC)[reply]
Just reverted all of it, will have to double check what's going wrong here. —TheDJ (talkcontribs) 20:50, 22 October 2017 (UTC)[reply]
Took me a bit to figure out what was wrong, but it seems that unlike userscripts, gadget pages check aggressively on ES5 compatibility and die hard on reserved keywords (in this case new), with little feedback. Redeployed a fixed version now. :For those who are following along.. I'm slowly reworking large parts of Navigation popups, to get rid of some cruft and to slowly bring it a bit up to date with more modern standards. The gadget hasn't had major work done to its underpinnings since 2007-2008'ish, and that made it increasingly hard to maintain. This will be a long process, with several intermediate steps. so please whenever you find a problem, please ping me. —TheDJ (talkcontribs) 22:02, 22 October 2017 (UTC)[reply]
Ping. Thanks for fixing that. I'm now seeing some JSON-type code when hovering over redlinks. -- zzuuzz (talk) 22:06, 22 October 2017 (UTC)[reply]
Ah, that's new. Thx for reporting. —TheDJ (talkcontribs) 22:09, 22 October 2017 (UTC)[reply]
When I point at a section arrow on my watchlist, the pop up opens with text like "{"batchcomplete":"","query":{"normalized":[{"from":"Wikipedia:Reference_desk/Science","to":"Wikipedia:Reference desk/Science"}],"pages":{"2535910":{"pageid":2535910,"ns":4,"title":"Wikipedia:Reference desk/Science"}}}} " in it. DuncanHill (talk) 22:28, 22 October 2017 (UTC)[reply]
I can reproduce this on this page, by hovering over someones contributions and then over a section arrow.--JohnBlackburnewordsdeeds 22:34, 22 October 2017 (UTC)[reply]
Both those issues should be fixed now. —TheDJ (talkcontribs) 23:12, 22 October 2017 (UTC)[reply]
Thanks, working as expected for me now. DuncanHill (talk) 23:15, 22 October 2017 (UTC)[reply]
Working for me to, thanks.--JohnBlackburnewordsdeeds 00:43, 23 October 2017 (UTC)[reply]

Empty pages still show JSON (see top of Special:ShortPages). --Tacsipacsi (talk) 11:29, 24 October 2017 (UTC)[reply]

Blegh, i so hate weak typed languages sometimes... —TheDJ (talkcontribs) 11:35, 24 October 2017 (UTC)[reply]
And also interwiki links. Example:
{"batchcomplete":true,"query":{"normalized":[{"fromencoded":false,"from":"en:Public_domain","to":"en:Public domain"}],"interwiki":[{"title":"en:Public domain","iw":"en"}]},"limits":{"images":5000,"categories":5000}}
(I don't know why was it normalized, as the wikitext was [[en:Public domain]], with space.)
P.S. Thanks for your efforts for modernizing Popups, I really appreciate it! --Tacsipacsi (talk) 18:53, 28 October 2017 (UTC)[reply]
@TheDJ: And also for Wikidata (main and property namespace). I don't know if it should be fixed globally or locally, neither have I any idea what should it show—maybe label, description and aliases? Or statements and/or sitelinks too? --Tacsipacsi (talk) 19:25, 1 November 2017 (UTC)[reply]
@Tacsipacsi: Can you please give actual examples ? There are so many variations possible, please just say which link on which specific page gives you a problem. I tried several on the interwiki help page, and I was unable to reproduce your problems so far. —TheDJ (talkcontribs) 12:58, 2 November 2017 (UTC)[reply]
I forgot to mention that the interwiki problem appears only when hovering over a link in the edit box (en:Public domain in the above example), as the result HTML—both in preview and on actual saved pages—contains a real external link (i.e. the host name is really the other domain). Also it seems to work on enwiki with the en: prefix, but changing the prefix to de: or hovering over this link in dewiki shows the problem. --Tacsipacsi (talk) 21:37, 2 November 2017 (UTC)[reply]

Hello everyone, and hope I'm posting in the right place.

I am among the 14 thousand or so users trying out the so-called "2017 wikitext editor". However, I find out that when this beta feature is enabled, the revert link in the navigation popups does not function. When I click this option, I am instead taken to the 2017 wikitext editor which always displays the current version of the page, instead of the revision I am trying to revert to. One of the users at MediaWiki suggested posting here for help, so I would like to inquire if anyone else is noticing this happening and if so, what can be done to resolve it?

Regards, ««« SOME GADGET GEEK »»» (talk) 15:00, 6 November 2017 (UTC)[reply]

No, you are among the 47 thousand users using this gadget—it doesn’t work with the old edit interface either. I see that the gadget uses a URL like /w/index.php?title=Title&action=edit&undo=123456789, while the normal (PHP-generated) links look like /w/index.php?title=Title&action=edit&undoafter=123456788&undo=123456789. --Tacsipacsi (talk) 16:52, 6 November 2017 (UTC)[reply]

History list on watchlist page

Anyone else notice the history list popup doesn't refresh properly on the new watchlist screen? Take an active page like WP:ANI, bring up the history popup, wait an interval, click "View newest changes", bring up the popup again and it won't have updated even though there are new edits to the page. Sometimes the popup is hours out of date. --NeilN talk to me 00:29, 14 December 2017 (UTC)[reply]

It’s by design – NavPopups caches everything, which is useful in most cases (popups load immediately). In this specific case there could be an exception to invalidate cache on every soft refresh. Until it’s implemented, you can use Popups→Reset. --Tacsipacsi (talk) 12:52, 14 December 2017 (UTC)[reply]
This additional caching is actually one of the things that i'm considering removing. It was added in 2008 'ash, when internet and computer speeds were still MUCH slower, but with pages getting more dynamic, it's going to be a bigger problem. It also adds a layer of complexity that makes it harder convert the code to a more modern architecture, so maybe i should just get rid of it. —TheDJ (talkcontribs) 13:14, 14 December 2017 (UTC)[reply]
I'm pretty sure this wasn't the behavior with the old watchlist. But that probably reloaded the whole page. --NeilN talk to me 13:20, 14 December 2017 (UTC)[reply]
This is the behavior at least for the past few years. I think generally caching is good – average internet speed might changed a lot, but many people still don’t have gigabit internet, especially in developing countries. --Tacsipacsi (talk) 21:41, 14 December 2017 (UTC)[reply]
I also have some doubts whether less reliance on cached data and more immediate fetching is desirable. As Tacsipacsi pointed out, internet speeds vary across regions, and volume charging is widely used. As TheDJ mentioned, Popups→Reset can be used if needed. -- Michael Bednarek (talk) 02:15, 15 December 2017 (UTC)[reply]
I’m from the "developing" country germany :-) Sometimes without caching NavPopups wouldn’t really be useful at all because of our glorious internet connection. And I’m not even on a mobile connection or anything weird. --nenntmichruhigip (Diskussion) 13:12, 16 December 2017 (UTC)[reply]